Skip to content

[web_ui] Clean up dead unreferenced declarations - #191164

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
kevmoo:cleanup-web-ui-dead-code
Aug 18, 2026
Merged

[web_ui] Clean up dead unreferenced declarations#191164
auto-submit[bot] merged 4 commits into
flutter:masterfrom
kevmoo:cleanup-web-ui-dead-code

Conversation

@kevmoo

@kevmookevmoo commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Remove dead declarations and unused code identified during reachability audit:

  • Delete svg.dart (legacy HTML debris)
  • Delete onscreen_logging.dart (dead debug helper)
  • Delete image_decoding_manager.dart and its isolated test
  • Delete unused conversion helpers and CanvasKitError in canvaskit_api.dart & util.dart
  • Delete unused DOM wrappers (DomWebSocket, DomMutationObserver, DomFileReader, etc.) and unused HTTP POST helpers in dom.dart
  • Clean up orphaned export directives in engine.dart

@kevmoo
[web_ui] Clean up dead unreferenced declarations
973adf9
Remove dead declarations and unused code identified during reachability audit:
- Delete `svg.dart` (legacy HTML debris)
- Delete `onscreen_logging.dart` (dead debug helper)
- Delete `image_decoding_manager.dart` and its isolated test
- Delete unused conversion helpers and CanvasKitError in `canvaskit_api.dart` & `util.dart`
- Delete unused DOM wrappers (DomWebSocket, DomMutationObserver, DomFileReader, etc.) and unused HTTP POST helpers in `dom.dart`
- Clean up orphaned export directives in `engine.dart`
@github-actionsgithub-actionsBot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically team-web Owned by Web platform team labels Aug 16, 2026
kevmoo
kevmoo commented Aug 16, 2026
View reviewed changes
Comment threadengine/src/flutter/lib/web_ui/lib/src/engine/canvaskit/canvaskit_api.dart Outdated
kevmoo
kevmoo commented Aug 16, 2026
View reviewed changes
Comment threadengine/src/flutter/lib/web_ui/lib/src/engine/canvaskit/util.dart Outdated
@kevmoo
kevmoo marked this pull request as ready for review August 16, 2026 04:43
gemini-code-assist[bot]
gemini-code-assistBot reviewed Aug 16, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the Flutter Web Engine codebase by removing several unused files, helper functions, and JS interop bindings. Specifically, it deletes the image decoding manager, onscreen logging, and SVG-related utilities, along with their associated tests and exports. It also removes obsolete APIs and DOM bindings from canvaskit_api.dart, util.dart, and dom.dart. I have no feedback to provide as there are no review comments to evaluate.

@kevmoo
kevmoo requested a review from mdebbarAugust 16, 2026 04:46
@kevmookevmoo added the CICD Run CI/CD label Aug 16, 2026
harryterkelsen
harryterkelsen previously approved these changes Aug 17, 2026
View reviewed changes

@harryterkelsenharryterkelsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmookevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2026
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2026
@auto-submit

auto-submitBot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/191164, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmookevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2026
@kevmoo

kevmoo commented Aug 18, 2026

Copy link
Copy Markdown
ContributorAuthor

@harryterkelsen - i think I need another approval from you!

@auto-submit
auto-submitBot added this pull request to the merge queueAug 18, 2026
Merged via the queue into flutter:master with commit a1185feAug 18, 2026
22 checks passed
@flutter-dashboardflutter-dashboardBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2026
@kevmoo
kevmoo deleted the cleanup-web-ui-dead-code branch August 18, 2026 15:49
This was referenced Aug 18, 2026
Closed
Closed
Closed
This was referenced Aug 19, 2026
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdebbarmdebbarmdebbar approved these changes
@harryterkelsenharryterkelsenharryterkelsen left review comments
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICDRun CI/CDengineflutter/engine related. See also e: labels.platform-webWeb applications specificallyteam-webOwned by Web platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevmoo@mdebbar@harryterkelsen