Skip to content

[camera_avfoundation] Wrappers swift migration - part 1 - #10119

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
leancodepl:feature/camera-wrappers-swift-migration-part1
Oct 21, 2025
Merged

[camera_avfoundation] Wrappers swift migration - part 1#10119
auto-submit[bot] merged 2 commits into
flutter:mainfrom
leancodepl:feature/camera-wrappers-swift-migration-part1

Conversation

@RobertOdrowaz

@RobertOdrowazRobertOdrowaz commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

Migrates camera wrappers as part of flutter/flutter#119109

This PR migrates wrappers to Swift:

  • FLTCamConfiguration
  • FLTCamMediaSettingsAVWrapper
  • FLTCaptureOutput
  • FLTCapturePhotoOutput
  • FLTCaptureVideoDataOutput

In line with Swift conventions, the FLT prefixes are removed. The Default class implementations are replaced with protocol conformance on base AV classes.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2↩3

@RobertOdrowaz
RobertOdrowaz marked this pull request as ready for review September 29, 2025 15:15
@RobertOdrowaz
RobertOdrowazforce-pushed the feature/camera-wrappers-swift-migration-part1 branch from 9cda6e1 to a84d272CompareSeptember 29, 2025 15:29
@stuartmorgan-gstuartmorgan-g added the triage-ios Should be looked at in iOS triage label Oct 1, 2025
hellohuanlin
hellohuanlin reviewed Oct 1, 2025
View reviewed changes

@hellohuanlinhellohuanlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed half of the PR. I wonder if you can split this into multiple PRs so it's easier review? Thanks!

Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/FLTCamSetFlashModeTests.swift Outdated
Comment thread...es/camera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockCaptureVideoDataOutput.swift
Comment thread...mera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CamConfiguration.swift Outdated
Comment thread...a_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraConfiguration.swift
Comment thread...mera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CamConfiguration.swift Outdated
Comment thread...mera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CamConfiguration.swift Outdated
Comment thread...mera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CamConfiguration.swift Outdated
Comment thread...mera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CamConfiguration.swift Outdated
Comment thread.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CaptureOutput.swift Outdated
@RobertOdrowaz
RobertOdrowazforce-pushed the feature/camera-wrappers-swift-migration-part1 branch 2 times, most recently from e008a0a to bf2e952CompareOctober 21, 2025 13:50
@RobertOdrowaz
Migrate FLTCamConfiguration, FLTCamMediaSettingsAVWrapper, FLTCapture…
8b57a08
…Output, FLTCapturePhotoOutput, FLTCaptureVideoDataOutput to Swift
@RobertOdrowaz
RobertOdrowazforce-pushed the feature/camera-wrappers-swift-migration-part1 branch from bf2e952 to 8b57a08CompareOctober 21, 2025 13:54
hellohuanlin
hellohuanlin approved these changes Oct 21, 2025
View reviewed changes
Comment threadpackages/camera/camera_avfoundation/CHANGELOG.md Outdated
Comment thread...a_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraConfiguration.swift Outdated
Comment thread.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift Outdated
Comment thread...a_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraConfiguration.swift Outdated
@RobertOdrowazRobertOdrowaz added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 21, 2025
@auto-submit
auto-submitBot merged commit 37f0bb0 into flutter:mainOct 21, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 22, 2025
@engine-flutter-autoroll
37f0bb0[camera_avfoundation] Wrappers swift migration - part 1 (flut…
f1c5d81
…ter/packages#10119)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Oct 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 22, 2025
@engine-flutter-autoroll
37f0bb0[camera_avfoundation] Wrappers swift migration - part 1 (flut…
8a571ac
…ter/packages#10119)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Oct 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2025
@engine-flutter-autoroll
37f0bb0[camera_avfoundation] Wrappers swift migration - part 1 (flut…
1a59f4a
…ter/packages#10119)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Oct 23, 2025
Merged
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Oct 23, 2025
@engine-flutter-autoroll
Roll Packages fromd113bbcto9ec29b6(12 revisions) (#177455)
63a925f
flutter/packages@d113bbc...9ec29b6
2025-10-22 omar_hanafy@icloud.com [go_router] Support for top level
`onEnter` callback. (flutter/packages#8339)
2025-10-22 katelovett@google.com [go_router_builder] Ignore experimental
features (flutter/packages#10275)
2025-10-22 engine-flutter-autoroll@skia.org Roll Flutter from
2d34167 to 75004a6 (39 revisions) (flutter/packages#10279)
2025-10-22 47866232+chunhtai@users.noreply.github.com [ci]Adds mechanism
for packages to opt in to batched release (flutter/packages#10237)
2025-10-22 1063596+reidbaker@users.noreply.github.com [tool] Change
gradle-check logic to enforce alignment of java versions and a minimum
(17) (flutter/packages#10206)
2025-10-22 eternalkaif@gmail.com [various] Migrate example Radio groups
to new RadioGroup API (flutter/packages#10155)
2025-10-22 davidmartos96@gmail.com [mustache_template] Emoji support
(flutter/packages#10110)
2025-10-22 38378650+hgraceb@users.noreply.github.com [image_picker] Fix
typos in error messages for android (flutter/packages#10188)
2025-10-22 38378650+hgraceb@users.noreply.github.com [image_picker] Fix
typos in error messages for platform interface (flutter/packages#10211)
2025-10-21 robert.odrowaz@leancode.pl [camera_avfoundation] Wrappers
swift migration - part 1 (flutter/packages#10119)
2025-10-21 NearTox@outlook.com [go_router_builder] expand supported
versions of analyzer, build and source_gen (flutter/packages#10078)
2025-10-20 engine-flutter-autoroll@skia.org Roll Flutter from
891d7d5 to 2d34167 (18 revisions) (flutter/packages#10268)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Oct 24, 2025
@engine-flutter-autoroll
Roll Packages fromd113bbcto9ec29b6(12 revisions) (#177455)
8c67d8c
flutter/packages@d113bbc...9ec29b6
2025-10-22 omar_hanafy@icloud.com [go_router] Support for top level
`onEnter` callback. (flutter/packages#8339)
2025-10-22 katelovett@google.com [go_router_builder] Ignore experimental
features (flutter/packages#10275)
2025-10-22 engine-flutter-autoroll@skia.org Roll Flutter from
2d34167 to 75004a6 (39 revisions) (flutter/packages#10279)
2025-10-22 47866232+chunhtai@users.noreply.github.com [ci]Adds mechanism
for packages to opt in to batched release (flutter/packages#10237)
2025-10-22 1063596+reidbaker@users.noreply.github.com [tool] Change
gradle-check logic to enforce alignment of java versions and a minimum
(17) (flutter/packages#10206)
2025-10-22 eternalkaif@gmail.com [various] Migrate example Radio groups
to new RadioGroup API (flutter/packages#10155)
2025-10-22 davidmartos96@gmail.com [mustache_template] Emoji support
(flutter/packages#10110)
2025-10-22 38378650+hgraceb@users.noreply.github.com [image_picker] Fix
typos in error messages for android (flutter/packages#10188)
2025-10-22 38378650+hgraceb@users.noreply.github.com [image_picker] Fix
typos in error messages for platform interface (flutter/packages#10211)
2025-10-21 robert.odrowaz@leancode.pl [camera_avfoundation] Wrappers
swift migration - part 1 (flutter/packages#10119)
2025-10-21 NearTox@outlook.com [go_router_builder] expand supported
versions of analyzer, build and source_gen (flutter/packages#10078)
2025-10-20 engine-flutter-autoroll@skia.org Roll Flutter from
891d7d5 to 2d34167 (18 revisions) (flutter/packages#10268)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
@engine-flutter-autoroll@reidbaker
Roll Packages fromd113bbcto9ec29b6(12 revisions) (flutter#177455)
f886f57
flutter/packages@d113bbc...9ec29b6
2025-10-22 omar_hanafy@icloud.com [go_router] Support for top level
`onEnter` callback. (flutter/packages#8339)
2025-10-22 katelovett@google.com [go_router_builder] Ignore experimental
features (flutter/packages#10275)
2025-10-22 engine-flutter-autoroll@skia.org Roll Flutter from
2d34167 to 75004a6 (39 revisions) (flutter/packages#10279)
2025-10-22 47866232+chunhtai@users.noreply.github.com [ci]Adds mechanism
for packages to opt in to batched release (flutter/packages#10237)
2025-10-22 1063596+reidbaker@users.noreply.github.com [tool] Change
gradle-check logic to enforce alignment of java versions and a minimum
(17) (flutter/packages#10206)
2025-10-22 eternalkaif@gmail.com [various] Migrate example Radio groups
to new RadioGroup API (flutter/packages#10155)
2025-10-22 davidmartos96@gmail.com [mustache_template] Emoji support
(flutter/packages#10110)
2025-10-22 38378650+hgraceb@users.noreply.github.com [image_picker] Fix
typos in error messages for android (flutter/packages#10188)
2025-10-22 38378650+hgraceb@users.noreply.github.com [image_picker] Fix
typos in error messages for platform interface (flutter/packages#10211)
2025-10-21 robert.odrowaz@leancode.pl [camera_avfoundation] Wrappers
swift migration - part 1 (flutter/packages#10119)
2025-10-21 NearTox@outlook.com [go_router_builder] expand supported
versions of analyzer, build and source_gen (flutter/packages#10078)
2025-10-20 engine-flutter-autoroll@skia.org Roll Flutter from
891d7d5 to 2d34167 (18 revisions) (flutter/packages#10268)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@RobertOdrowaz
[camera_avfoundation] Wrappers swift migration - part 1 (flutter#10119)
4b28e5f
Migrates camera wrappers as part of flutter/flutter#119109
This PR migrates wrappers to Swift:
* `FLTCamConfiguration`
* `FLTCamMediaSettingsAVWrapper`
* `FLTCaptureOutput`
* `FLTCapturePhotoOutput`
* `FLTCaptureVideoDataOutput`
In line with Swift conventions, the `FLT` prefixes are removed. The `Default` class implementations are replaced with protocol conformance on base `AV` classes.
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g left review comments
@hellohuanlinhellohuanlinhellohuanlin approved these changes
@vashworthvashworthAwaiting requested review from vashworth

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: cameraplatform-iosplatform-macostriage-iosShould be looked at in iOS triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RobertOdrowaz@stuartmorgan-g@hellohuanlin