Bumping CI to Test Against JDK 21 by jesswrd · Pull Request #10193 · flutter/packages

jesswrd · 2025-10-08T17:13:21Z

Bumping CI to Test Against JDK 21. This is part of the setup to use a robolectric version that supports SDK 36. This new robolectric version requires JDK 21 at minimum.

Edit: On JDK 21+ an error is thrown for this-escape warning due to: https://bugs.openjdk.org/browse/JDK-8015831. Addressing the warning requires removing the abstract funciton createExoPlayerEventListener in base class VideoPlayer.java, which could cause unknown regressions. Keeping the behavior as-is since the plugin works as expected.

Addresses flutter/flutter#163071
Addresses flutter/flutter#177674

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩² ↩³

gemini-code-assist

Code Review

I've reviewed the changes to update the JDK version in the CI configuration. The changes are straightforward and align with the goal of preparing for a Robolectric upgrade. I have a couple of suggestions to improve build reproducibility by pinning the JDK to a more specific version, which is a common best practice and seems to be followed for other dependencies in this file. Please see my detailed comments below.

mboetger · 2025-10-21T16:55:57Z

Are changelogs needed?

jesswrd · 2025-10-21T16:57:58Z

Are changelogs needed?

Yes that would be good to add. This is meant to be in draft mb.

This reverts commit 3431488.

jesswrd · 2025-11-10T20:47:03Z

Are changelogs needed?

done

mboetger

nit: Could you add documentation why suppressing the this-escape warning is not a concern?

jesswrd · 2025-11-10T23:17:40Z

nit: Could you add documentation why suppressing the this-escape warning is not a concern?

done

auto-submit · 2025-11-10T23:40:02Z

autosubmit label was removed for flutter/packages/10193, because - The status or check suite Mac_arm64 ios_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter/packages@7063d75...e5ecaf7 2025-11-12 124445418+zhoda-lii@users.noreply.github.com [google_sign_in_android] Fix typos in README.md (flutter/packages#10402) 2025-11-12 10687576+bparrishMines@users.noreply.github.com [image_picker] Fixes README description of plugin suggesting that only Android and iOS is supported. (flutter/packages#10385) 2025-11-12 stuartmorgan@google.com [pigeon] Deprecate dartHostTestHandler (flutter/packages#10403) 2025-11-11 jessiewong401@gmail.com Bumping CI to Test Against JDK 21 (flutter/packages#10193) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bumping CI to Test Against JDK 21. This is part of the setup to use a robolectric version that supports SDK 36. This new robolectric version requires JDK 21 at minimum. Edit: On JDK 21+ an error is thrown for this-escape warning due to: https://bugs.openjdk.org/browse/JDK-8015831. Addressing the warning requires removing the abstract funciton `createExoPlayerEventListener` in base class `VideoPlayer.java`, which could cause unknown regressions. Keeping the behavior as-is since the plugin works as expected. Addresses flutter/flutter#163071 Addresses flutter/flutter#177674 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

packages ci updated to test against jdk 21
12f90b3

gemini-code-assistBot reviewed Oct 8, 2025
View reviewed changes

Comment thread.ci.yaml
Comment thread.ci.yaml

jesswrd added 2 commits October 8, 2025 15:24

ensure we are not calling overrideable methods from the constructor
7c9f7e4

updated mockito plugin
75a93bb

jesswrd requested review from ash2moon, camsim99 and mboetger as code owners October 16, 2025 20:54

Merge branch 'main' into ci-to-jdk-21
a2789ea

github-actionsBot added p: camera p: google_sign_in p: local_auth platform-android labels Oct 16, 2025

jesswrd marked this pull request as draft October 21, 2025 16:56

jesswrd changed the title ~~Bumping CI to Test Against JDK 21~~[WIP] Bumping CI to Test Against JDK 21Oct 21, 2025

jesswrdand others added 4 commits October 23, 2025 14:11

Merge branch 'main' into ci-to-jdk-21
3518973

Merge branch 'main' into ci-to-jdk-21
313e9a0

fixed mockito tests failing from using old mockito vers
715c989

more fitting name
cfd0c1d

jesswrd marked this pull request as ready for review November 4, 2025 22:24

jesswrd marked this pull request as draft November 4, 2025 22:25

remove this escape
3431488

github-actionsBot added the p: video_player label Nov 4, 2025

jesswrd added 4 commits November 5, 2025 10:38

better name
0e2318c

fixed java mockito problems should pass ci now
0ac19d6

Revert "remove this escape"
2aa3115
This reverts commit 3431488.

revert addressing this-escape change and use suppress warning instead
b8ed77b

github-actionsBot added the p: file_selector label Nov 5, 2025

Merge branch 'main' into ci-to-jdk-21
0384011

jesswrdand others added 3 commits November 6, 2025 10:56

Merge branch 'main' into ci-to-jdk-21
c28c24e

Merge branch 'main' into ci-to-jdk-21
c357171

updated pubspec and changelog
9b7f6f1

jesswrd marked this pull request as ready for review November 10, 2025 18:10

jesswrd changed the title ~~[WIP] Bumping CI to Test Against JDK 21~~Bumping CI to Test Against JDK 21Nov 10, 2025

This was referenced Nov 10, 2025
☔ Android 16 api 36 topline tracking bug flutter/flutter#163071
Closed
[Android 16] Upgrade to Robolectric 4.16 flutter/flutter#177674
Closed

mboetger approved these changes Nov 10, 2025
View reviewed changes

added comment above suppress warning
051b702

jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 10, 2025

auto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 10, 2025

jesswrd mentioned this pull request Nov 11, 2025
Add test for logging deprecation warning for API 36 flutter/flutter#165220
Closed

jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 11, 2025

auto-submitBot merged commit 0aa4d9d into flutter:mainNov 11, 2025
81 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2025
0aa4d9dBumping CI to Test Against JDK 21 (flutter/packages#10193)
9e87d53

engine-flutter-autoroll mentioned this pull request Nov 12, 2025
Roll Packages from 7063d75d552e to e5ecaf770c8f (4 revisions) flutter/flutter#178377
Merged

Navigation Menu

Uh oh!

Bumping CI to Test Against JDK 21 - #10193

Bumping CI to Test Against JDK 21#10193
auto-submit[bot] merged 18 commits into
flutter:mainfrom
jesswrd:ci-to-jdk-21

jesswrd commented Oct 8, 2025•
edited
Loading

Uh oh!

gemini-code-assistBot left a comment

Uh oh!

Uh oh!

Uh oh!

mboetger commented Oct 21, 2025

Uh oh!

jesswrd commented Oct 21, 2025

Uh oh!

jesswrd commented Nov 10, 2025

Uh oh!

mboetger left a comment

Uh oh!

jesswrd commented Nov 10, 2025

Uh oh!

auto-submitBot commented Nov 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jesswrd commented Oct 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assistBot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

mboetger commented Oct 21, 2025

Uh oh!

jesswrd commented Oct 21, 2025

Uh oh!

jesswrd commented Nov 10, 2025

Uh oh!

mboetger left a comment

Choose a reason for hiding this comment

Uh oh!

jesswrd commented Nov 10, 2025

Uh oh!

auto-submitBot commented Nov 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jesswrd commented Oct 8, 2025•
edited
Loading