[camera_avfoundation] Adds support for video stabilization by ruicraveiro · Pull Request #10367 · flutter/packages

ruicraveiro · 2025-11-06T02:33:32Z

Implements getSupportedVideoStabilizationModes() and setVideoStabilizationMode() methods in AVFoundationCamera.

Address issue flutter/flutter#89525.
It is the camera_avfoundation sub-PR for #7108.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩² ↩³

gemini-code-assist

Code Review

This pull request adds support for video stabilization, which is a great new feature. The implementation looks solid across Dart, Swift, and Objective-C. I've found a minor issue in the Dart implementation related to a copy-paste error in a comment and a suggestion for a safer fallback value for forward compatibility. The rest of the changes, including the native implementation and tests, are well done.

gemini-code-assist · 2025-11-06T02:35:06Z

+ /// Returns a [ResolutionPreset]'s Pigeon representation.
+ PlatformVideoStabilizationMode? _pigeonVideoStabilizationMode(
+ VideoStabilizationMode videoStabilizationMode,
+ ) {
+ switch (videoStabilizationMode) {
+ case VideoStabilizationMode.off:
+ return PlatformVideoStabilizationMode.off;
+ case VideoStabilizationMode.level1:
+ return PlatformVideoStabilizationMode.standard;
+ case VideoStabilizationMode.level2:
+ return PlatformVideoStabilizationMode.cinematic;
+ case VideoStabilizationMode.level3:
+ return PlatformVideoStabilizationMode.cinematicExtended;
+ }
+ // The enum comes from a different package, which could get a new value at
+ // any time, so provide a fallback that ensures this won't break when used
+ // with a version that contains new values. This is deliberately outside
+ // the switch rather than a `default` so that the linter will flag the
+ // switch as needing an update.
+ // ignore: dead_code
+ return PlatformVideoStabilizationMode.cinematic;
+ }


There are a couple of improvements that can be made in this method:
The documentation comment appears to be a copy-paste error and refers to ResolutionPreset instead of VideoStabilizationMode.
The fallback return value for unknown VideoStabilizationMode values is PlatformVideoStabilizationMode.cinematic. It would be safer to return null here. The function has a nullable return type, and the calling method _getSupportedVideoStabilizationModeMap already handles null by correctly treating the mode as unsupported. This would prevent new enum values from being incorrectly mapped to cinematic mode.
/// Returns a [VideoStabilizationMode]'s Pigeon representation.PlatformVideoStabilizationMode?_pigeonVideoStabilizationMode( VideoStabilizationMode videoStabilizationMode, ) { switch (videoStabilizationMode) { caseVideoStabilizationMode.off:returnPlatformVideoStabilizationMode.off; caseVideoStabilizationMode.level1:returnPlatformVideoStabilizationMode.standard; caseVideoStabilizationMode.level2:returnPlatformVideoStabilizationMode.cinematic; caseVideoStabilizationMode.level3:returnPlatformVideoStabilizationMode.cinematicExtended; } // The enum comes from a different package, which could get a new value at// any time, so provide a fallback that ensures this won't break when used// with a version that contains new values. This is deliberately outside// the switch rather than a `default` so that the linter will flag the// switch as needing an update.// ignore: dead_codereturnnull; }

LongCatIsLooong · 2025-11-17T19:37:17Z

cc @hellohuanlin from ios triage

ruicraveiro · 2025-11-21T18:33:41Z

Hi, I have been updating this PR so that it is based on the latest commit in main, but I wonder if there is any point in doing so if the PR takes much longer to be reviewed. Please advise me when you're close to start the review and I'll be happy to rebase once again.

okorohelijah · 2025-11-24T19:44:41Z

@hellohuanlin review- from triage meeting

LouiseHsu · 2026-01-05T20:10:46Z

 buildConfiguration = "Debug"
 selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
 selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+ customLLDBInitFile = "$(SRCROOT)/Flutter/ephemeral/flutter_lldbinit"


do you know why this change is needed?

This is a leftover after running the example project. I included this by mistake, so I will be removing it.

LouiseHsu · 2026-01-05T20:16:23Z

+ completion(
+ FlutterError(
+ code: "VIDEO_STABILIZATION_ERROR",
+ message: "Unavailable video stabilization mode.",


nitpick - maybe something like
FlutterError( code: "VIDEO_STABILIZATION_ERROR", message: "The requested stabilization mode is not supported.", details: [ "requested_mode": stabilizationMode.rawValue, ] )

LouiseHsu · 2026-01-05T20:17:34Z

+/// Sets the video stabilization mode.
+- (void)setVideoStabilizationMode:(FCPPlatformVideoStabilizationMode)mode
+ completion:(void (^)(FlutterError *_Nullable))completion;
+/// Sets the video stabilization mode.


this should probably be like /// Gets if the video stabilization mode is supported.

LouiseHsu · 2026-01-05T20:18:04Z

+ @ObjCSelector('setVideoStabilizationMode:')
+ void setVideoStabilizationMode(PlatformVideoStabilizationMode mode);
+
+ /// Sets the video stabilization mode.


this comment should be updated too :)

LouiseHsu · 2026-01-05T20:19:38Z

@@ -1,3 +1,7 @@
+## 0.10.0
+
+* Adds video stabilization.


Could you add a bit more detail? Maybe make a reference to the AVCaptureVideoStabilizationMode api you added.

I don't know how much more detail it makes sense to add to the CHANGELOG, so I just added a mention to the 2 methods added to the Dart classes. Let me know if you need even more details.

LouiseHsu · 2026-01-22T22:41:30Z

From triage: Are you planning to address the feedback? :)

ruicraveiro · 2026-01-22T22:43:38Z

From triage: Are you planning to address the feedback? :)

Hi, yes, but I still haven't found the time. Maybe next week.

ruicraveiro · 2026-01-29T02:37:47Z

Hi @LouiseHsu, I just force-pushed an updated commit. It contains changes to address all your feedback. It also contains the changes needed after rebasing from the current main branch (the biggest of which was the migration of CameraProperties to swift). So, this commit also has getAvCaptureVideoStabilizationMode ported from ObjectiveC to Swift.

hellohuanlin

The pigeon part may conflict with #10939
CC @RobertOdrowaz

hellohuanlin · 2026-02-02T23:10:00Z

+ ) {
+ captureSessionQueue.async { [weak self] in
+
+ if let isSupported = self?.camera?.isVideoStabilizationModeSupported(mode) {


it's a bit confusing to do if let isSupported, since it's a boolean type. Can you do if let camera = ... and get isSupported from inside the if statement?

Hi, improved.

hellohuanlin · 2026-02-02T23:10:24Z

+ switch videoStabilizationMode {
+ case .off:
+ return .off
+


nit: remove these blank lines

Done. Thanks!

LouiseHsu

LGTM once @hellohuanlin comments have been addressed + merge conflicts.

ruicraveiro · 2026-02-10T21:02:50Z

Hi, just in case it went unnoticed, I made all the requested adjustments a few days ago.

- Implements getSupportedVideoStabilizationModes() and setVideoStabilizationMode() methods in AVFoundationCamera.

…lutter/packages#10367)

flutter/packages@af1d610...09104b0 2026-02-12 8490712+ruicraveiro@users.noreply.github.com [camera_avfoundation] Adds support for video stabilization (flutter/packages#10367) 2026-02-12 stuartmorgan@google.com [google_maps_flutter] Add README section about SDK versions (flutter/packages#11005) 2026-02-12 stuartmorgan@google.com [url_launcher] Modernize `url_launcher_ios` example (flutter/packages#11002) 2026-02-12 107683152+OlehSv@users.noreply.github.com [google_maps_flutter] Improved perfomance of clusterization (flutter/packages#10562) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#182383) flutter/packages@af1d610...09104b0 2026-02-12 8490712+ruicraveiro@users.noreply.github.com [camera_avfoundation] Adds support for video stabilization (flutter/packages#10367) 2026-02-12 stuartmorgan@google.com [google_maps_flutter] Add README section about SDK versions (flutter/packages#11005) 2026-02-12 stuartmorgan@google.com [url_launcher] Modernize `url_launcher_ios` example (flutter/packages#11002) 2026-02-12 107683152+OlehSv@users.noreply.github.com [google_maps_flutter] Improved perfomance of clusterization (flutter/packages#10562) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…0367) Implements getSupportedVideoStabilizationModes() and setVideoStabilizationMode() methods in AVFoundationCamera. Address issue flutter/flutter#89525. It is the camera_avfoundation sub-PR for flutter#7108. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

ruicraveiro requested review from hellohuanlin and vashworth as code owners November 6, 2025 02:33

github-actionsBot added p: camera platform-ios platform-macos labels Nov 6, 2025

gemini-code-assistBot reviewed Nov 6, 2025
View reviewed changes

ruicraveiro force-pushed the main branch 5 times, most recently from 6b092c1 to 187b287Compare November 10, 2025 23:51

stuartmorgan-g added federated: partial_changes PR that contains changes for only a single package of a federated plugin change triage-ios Should be looked at in iOS triage labels Nov 11, 2025

ruicraveiro force-pushed the main branch 7 times, most recently from 797cbeb to 881874fCompare November 17, 2025 13:34

ruicraveiro force-pushed the main branch from 881874f to 939d5c4Compare November 18, 2025 04:09

stuartmorgan-g mentioned this pull request Nov 18, 2025
[camera] add video stabilization #7108
Merged
11 tasks

ruicraveiro force-pushed the main branch 4 times, most recently from d5dc938 to cf4fa8cCompare November 21, 2025 18:31

ruicraveiro force-pushed the main branch from cf4fa8c to c71efb8Compare November 22, 2025 09:41

ruicraveiro force-pushed the main branch 2 times, most recently from 68b305f to fbe0583Compare December 19, 2025 20:26

LouiseHsu requested changes Jan 5, 2026
View reviewed changes

ruicraveiro force-pushed the main branch from fbe0583 to a88976cCompare January 29, 2026 02:32

ruicraveiro force-pushed the main branch 2 times, most recently from 635aaab to 4d9a89aCompare January 30, 2026 13:36

hellohuanlin approved these changes Feb 2, 2026
View reviewed changes

okorohelijah requested a review from LouiseHsu February 5, 2026 22:45

LouiseHsu approved these changes Feb 6, 2026
View reviewed changes

ruicraveiro force-pushed the main branch 5 times, most recently from f249f53 to c01d1d7Compare February 10, 2026 21:01

[camera_avfoundation] Adds support for video stabilization
89552d4
- Implements getSupportedVideoStabilizationModes() and setVideoStabilizationMode() methods in AVFoundationCamera.

ruicraveiro force-pushed the main branch from c01d1d7 to 89552d4Compare February 12, 2026 20:30

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2026

auto-submitBot merged commit 09104b0 into flutter:mainFeb 12, 2026
81 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 13, 2026
09104b08c [camera_avfoundation] Adds support for video stabilization (f…
6d6162d
…lutter/packages#10367)

engine-flutter-autoroll mentioned this pull request Feb 13, 2026
Roll Packages from af1d610094c3 to 09104b08c326 (4 revisions) flutter/flutter#182373
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 13, 2026
09104b08c [camera_avfoundation] Adds support for video stabilization (f…
41ee07c
…lutter/packages#10367)

engine-flutter-autoroll mentioned this pull request Feb 13, 2026
Roll Packages from af1d610094c3 to 09104b08c326 (4 revisions) flutter/flutter#182383
Merged

Uh oh!

Conversation

ruicraveiro commented Nov 6, 2025

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assistBot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assistBotNov 6, 2025

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong commented Nov 17, 2025

Uh oh!

ruicraveiro commented Nov 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

okorohelijah commented Nov 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ruicraveiroJan 29, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LouiseHsu commented Jan 22, 2026

Uh oh!

ruicraveiro commented Jan 22, 2026

Uh oh!

ruicraveiro commented Jan 29, 2026

Uh oh!

hellohuanlin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LouiseHsu left a comment

Choose a reason for hiding this comment

Uh oh!

ruicraveiro commented Feb 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ruicraveiro commented Nov 21, 2025•
edited
Loading

ruicraveiroJan 29, 2026•
edited
Loading