Skip to content

Updates pigeon dependencies to the latest version (^26.1.0) - #10448

Closed
bkonyi wants to merge 7 commits into
mainfrom
update_pigeon_dependencies
Closed

Updates pigeon dependencies to the latest version (^26.1.0)#10448
bkonyi wants to merge 7 commits into
mainfrom
update_pigeon_dependencies

Conversation

@bkonyi

Copy link
Copy Markdown
Contributor

Unblocks the flutter/flutter pub package roll, which requires support for analyzer >= 8.0.0.

Bumps versions for in_app_purchase_android, in_app_purchase_storekit, path_provider_android, url_launcher_android, url_launcher_ios, url_launcher_linux, url_launcher_macos, and url_launcher_windows, which are the packages currently causing dependency resolution to fail due to their outdated pigeon dependencies.

Unblocks the flutter/flutter pub package roll, which requires support
for analyzer >= 8.0.0.
Bumps versions for `in_app_purchase_android`, `in_app_purchase_storekit`,
`path_provider_android`, `url_launcher_android`, `url_launcher_ios`,
`url_launcher_linux`, `url_launcher_macos`, and `url_launcher_windows`,
which are the packages currently causing dependency resolution to fail
due to their outdated pigeon dependencies.

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pigeon dependency to ^26.1.0 across multiple packages. This is a necessary update to support newer versions of the analyzer package.

However, a critical step is missing: after updating the pigeon dependency, the corresponding generated files (.g.dart, .kt, etc.) must be regenerated. The current generated files still show older pigeon versions in their headers. For example, packages/camera/camera_android/lib/src/messages.g.dart still indicates it was generated with v22.4.1. Please run the pigeon generator for all affected packages to ensure the generated code is up-to-date with the new dependency version.

Additionally, there's a formatting issue in one of the pubspec.yaml files that makes it invalid, which I've commented on separately.

Comment threadpackages/interactive_media_ads/pubspec.yaml Outdated
@bkonyibkonyi mentioned this pull request Nov 17, 2025
9 tasks
@stuartmorgan-g

stuartmorgan-g commented Nov 17, 2025

Copy link
Copy Markdown
Collaborator

Pigeon is a code generator, so updates should regenerate the code as well. I can prep a full PR (we have a repo tool command, update-dependency, that can do this automatically).

@bkonyi

Copy link
Copy Markdown
ContributorAuthor

Pigeon is a code generator, so updates should regenerate the code as well. I can prep a full PR.

Yeah, I was in the process of rerunning the generator for the repo. I seem to have some static errors now in a few of the projects though.

@reidbakerreidbaker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reidbaker
reidbaker requested review from reidbaker and removed request for reidbakerNovember 17, 2025 16:15
@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

I have a version of this that does the whole repo at #10450 since I already had it underway when I saw that you'd pushed fixes for the errors you mentioned.

@bkonyi

Copy link
Copy Markdown
ContributorAuthor

Closing in favor of #10450

@bkonyibkonyi closed this Nov 17, 2025
@bkonyi
bkonyi deleted the update_pigeon_dependencies branch November 17, 2025 17:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bkonyi@stuartmorgan-g@reidbaker