[in_app_purchase_storekit] Fix Xcode 26.2 analyzer warnings

[jmagman]

Seen in https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8695102947197916049/+/u/Run_package_tests/native_test/stdout

I opened in Xcode 26.2 and let it "Fix".

FIAPPaymentQueueDeleteTests.swift:87:7: warning: 'TARGET_OS_*' preprocessor macros are not available in Swift; use 'os(iOS)' instead
#if TARGET_OS_IOS
^~~~~~~~~~~~~

InAppPurchaseStoreKit2PluginTests.swift:396:25: warning: immutable value 'purchase' was never used; consider replacing with '_' or removing it
case .success(let purchase):
~~~~^~~~~~~~
_

TranslatorTests.swift:18:9: warning: variable 'map' was never mutated; consider changing to 'let' constant
var map: [String: Any] = [
~~~ ^
let

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under¹.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩²↩³

[gemini-code-assist]

Code Review

This pull request correctly addresses three analyzer warnings from Xcode 26.2 by updating a preprocessor macro, removing an unused variable, and changing a mutable variable to a constant. The CHANGELOG.md has also been updated. One minor style issue regarding indentation has been pointed out for improvement.

[LouiseHsu]

The tests are failing - Im guessing you might need to keep the "let purchase" because of IAP sandbox shennanigans. I think if you dont handle the VerificationResult it freaks out. Maybe we can do this instead

case .success(let purchase):
_ = purchase 

[jmagman]

Weird, this test passes on Xcode 26.2 locally.

[jmagman]

And also passed on 16.4 locally...

[LouiseHsu]

oh thats scary

[jmagman]

And it passed in CI when run a second time.

[LouiseHsu]

ugh the tests are flaky :( thats not good

[LouiseHsu]

lol flutter/flutter#174478