Uh oh!
There was an error while loading. Please reload this page.
[rfw] Workaround IconData parameters must be const - #10858
Closed
dcharkes wants to merge 2 commits into
Closed
Conversation
dcharkes
commented
Jan 22, 2026
ContributorAuthor
@yjbanov Would you happen to know who owns this and can explain to me how the icon fonts work in RFW? |
github-merge-queueBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 24, 2026
2026-03-18 update, no push-back on the breaking changes. Migrations done downstream: * fluttercommunity/font_awesome_flutter#297 * PiotrRogulski/kanji_app@76973c7 * flutter/packages#11216 * FaFre/WebLibre#214 * flutter/devtools#9718 ----------- Applying breaking changes: * #181342 * #181344 See the issue descriptions for the motivation. cc @Piinks It seems we have a non-const use in the Remote Flutter Widgets: https://github.com/flutter/packages/blob/d0c7d1fad77331724882614345137221c77d5758/packages/rfw/lib/src/flutter/argument_decoders.dart#L801-L811 The package itself makes no mention of it not work with the Flutter Icon Tree Shaker. If it's a know issue that the icon tree shaker is not supported with `package:rfw` we can add `// ignore: non_const_argument_for_const_parameter`. (flutter/packages#10858)
mboetger pushed a commit
to mboetger/flutter
that referenced
this pull request
Mar 26, 2026
2026-03-18 update, no push-back on the breaking changes. Migrations done downstream: * fluttercommunity/font_awesome_flutter#297 * PiotrRogulski/kanji_app@76973c7 * flutter/packages#11216 * FaFre/WebLibre#214 * flutter/devtools#9718 ----------- Applying breaking changes: * flutter#181342 * flutter#181344 See the issue descriptions for the motivation. cc @Piinks It seems we have a non-const use in the Remote Flutter Widgets: https://github.com/flutter/packages/blob/d0c7d1fad77331724882614345137221c77d5758/packages/rfw/lib/src/flutter/argument_decoders.dart#L801-L811 The package itself makes no mention of it not work with the Flutter Icon Tree Shaker. If it's a know issue that the icon tree shaker is not supported with `package:rfw` we can add `// ignore: non_const_argument_for_const_parameter`. (flutter/packages#10858)
ahmedsameha1 pushed a commit
to ahmedsameha1/flutter
that referenced
this pull request
Apr 14, 2026
2026-03-18 update, no push-back on the breaking changes. Migrations done downstream: * fluttercommunity/font_awesome_flutter#297 * PiotrRogulski/kanji_app@76973c7 * flutter/packages#11216 * FaFre/WebLibre#214 * flutter/devtools#9718 ----------- Applying breaking changes: * flutter#181342 * flutter#181344 See the issue descriptions for the motivation. cc @Piinks It seems we have a non-const use in the Remote Flutter Widgets: https://github.com/flutter/packages/blob/d0c7d1fad77331724882614345137221c77d5758/packages/rfw/lib/src/flutter/argument_decoders.dart#L801-L811 The package itself makes no mention of it not work with the Flutter Icon Tree Shaker. If it's a know issue that the icon tree shaker is not supported with `package:rfw` we can add `// ignore: non_const_argument_for_const_parameter`. (flutter/packages#10858)
Piinks
commented
Apr 20, 2026
Contributor
dcharkes
commented
Apr 21, 2026
ContributorAuthor
I forgot about this PR and made a duplicate one that was landed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A patch for:
IconDatafinaland@mustBeConstflutter#181345I am assuming that the remote flutter widgets cannot be used together with the icon tree shaker?