Uh oh!
There was an error while loading. Please reload this page.
[video_player] Update Android to exoplayer 1.9.1 - #10904
Conversation
stuartmorgan-g
commented
Jan 26, 2026
Oddly we don't seem to have gotten a dependabot PR for the 1.8.0->1.9.0 update. |
There was a problem hiding this comment.
Code Review
This pull request updates the androidx.media3:media3-exoplayer dependency to version 1.9.1. As part of this update, the unit tests have been refactored to use Robolectric with real ExoPlayer instances, since mocking is no longer straightforward with the new version. The changes are consistent across the build files, changelog, and tests. My feedback focuses on ensuring proper resource cleanup in the updated tests.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
flutter/packages@f83926f...59f905c 2026-02-18 52160996+FMorschel@users.noreply.github.com [camera][google_fonts] Fixes future warning for `await`ing `Future` returns in `async` bodies inside `try` blocks (flutter/packages#11009) 2026-02-18 robert.odrowaz@leancode.pl [camera_avfoundation] Pigeon swift migration - part 2 (flutter/packages#10980) 2026-02-17 8490712+ruicraveiro@users.noreply.github.com [camera_android_camerax] Adds support for video stabilization (flutter/packages#11020) 2026-02-17 nateshmbhat1@gmail.com [video_player] Adds audio track metadata fetching and audio track selection feature (flutter/packages#9925) 2026-02-17 stuartmorgan@google.com [video_player] Update Android to exoplayer 1.9.1 (flutter/packages#10904) 2026-02-17 joonas.kerttula@codemate.com [google_maps_flutter_android] Add advanced markers support (flutter/packages#10381) 2026-02-17 stuartmorgan@google.com [google_maps_flutter] Standardize iOS class and file names (flutter/packages#10964) 2026-02-17 stuartmorgan@google.com [google_sign_in] Simply Kotlin/Java interop utils (flutter/packages#11011) 2026-02-17 engine-flutter-autoroll@skia.org Roll Flutter from 9bda20a to 6e4a481 (103 revisions) (flutter/packages#11041) 2026-02-17 stuartmorgan@google.com [ci] Update repo for 3.41 (flutter/packages#11017) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…er#182547) flutter/packages@f83926f...59f905c 2026-02-18 52160996+FMorschel@users.noreply.github.com [camera][google_fonts] Fixes future warning for `await`ing `Future` returns in `async` bodies inside `try` blocks (flutter/packages#11009) 2026-02-18 robert.odrowaz@leancode.pl [camera_avfoundation] Pigeon swift migration - part 2 (flutter/packages#10980) 2026-02-17 8490712+ruicraveiro@users.noreply.github.com [camera_android_camerax] Adds support for video stabilization (flutter/packages#11020) 2026-02-17 nateshmbhat1@gmail.com [video_player] Adds audio track metadata fetching and audio track selection feature (flutter/packages#9925) 2026-02-17 stuartmorgan@google.com [video_player] Update Android to exoplayer 1.9.1 (flutter/packages#10904) 2026-02-17 joonas.kerttula@codemate.com [google_maps_flutter_android] Add advanced markers support (flutter/packages#10381) 2026-02-17 stuartmorgan@google.com [google_maps_flutter] Standardize iOS class and file names (flutter/packages#10964) 2026-02-17 stuartmorgan@google.com [google_sign_in] Simply Kotlin/Java interop utils (flutter/packages#11011) 2026-02-17 engine-flutter-autoroll@skia.org Roll Flutter from 9bda20a to 6e4a481 (103 revisions) (flutter/packages#11041) 2026-02-17 stuartmorgan@google.com [ci] Update repo for 3.41 (flutter/packages#11017) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…er#182547) flutter/packages@f83926f...59f905c 2026-02-18 52160996+FMorschel@users.noreply.github.com [camera][google_fonts] Fixes future warning for `await`ing `Future` returns in `async` bodies inside `try` blocks (flutter/packages#11009) 2026-02-18 robert.odrowaz@leancode.pl [camera_avfoundation] Pigeon swift migration - part 2 (flutter/packages#10980) 2026-02-17 8490712+ruicraveiro@users.noreply.github.com [camera_android_camerax] Adds support for video stabilization (flutter/packages#11020) 2026-02-17 nateshmbhat1@gmail.com [video_player] Adds audio track metadata fetching and audio track selection feature (flutter/packages#9925) 2026-02-17 stuartmorgan@google.com [video_player] Update Android to exoplayer 1.9.1 (flutter/packages#10904) 2026-02-17 joonas.kerttula@codemate.com [google_maps_flutter_android] Add advanced markers support (flutter/packages#10381) 2026-02-17 stuartmorgan@google.com [google_maps_flutter] Standardize iOS class and file names (flutter/packages#10964) 2026-02-17 stuartmorgan@google.com [google_sign_in] Simply Kotlin/Java interop utils (flutter/packages#11011) 2026-02-17 engine-flutter-autoroll@skia.org Roll Flutter from 9bda20a to 6e4a481 (103 revisions) (flutter/packages#11041) 2026-02-17 stuartmorgan@google.com [ci] Update repo for 3.41 (flutter/packages#11017) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Updates from 1.8.0 to the just-released 1.9.1. `ExoPlayer` 1.9 is no longer trivially mockable, so I followed the [team's general guidance](androidx/media#2985 (comment)) to use a real ExoPlayer in a Robolectric test instead of mocking it. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…er#182547) flutter/packages@f83926f...59f905c 2026-02-18 52160996+FMorschel@users.noreply.github.com [camera][google_fonts] Fixes future warning for `await`ing `Future` returns in `async` bodies inside `try` blocks (flutter/packages#11009) 2026-02-18 robert.odrowaz@leancode.pl [camera_avfoundation] Pigeon swift migration - part 2 (flutter/packages#10980) 2026-02-17 8490712+ruicraveiro@users.noreply.github.com [camera_android_camerax] Adds support for video stabilization (flutter/packages#11020) 2026-02-17 nateshmbhat1@gmail.com [video_player] Adds audio track metadata fetching and audio track selection feature (flutter/packages#9925) 2026-02-17 stuartmorgan@google.com [video_player] Update Android to exoplayer 1.9.1 (flutter/packages#10904) 2026-02-17 joonas.kerttula@codemate.com [google_maps_flutter_android] Add advanced markers support (flutter/packages#10381) 2026-02-17 stuartmorgan@google.com [google_maps_flutter] Standardize iOS class and file names (flutter/packages#10964) 2026-02-17 stuartmorgan@google.com [google_sign_in] Simply Kotlin/Java interop utils (flutter/packages#11011) 2026-02-17 engine-flutter-autoroll@skia.org Roll Flutter from 9bda20a to 6e4a481 (103 revisions) (flutter/packages#11041) 2026-02-17 stuartmorgan@google.com [ci] Update repo for 3.41 (flutter/packages#11017) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Updates from 1.8.0 to the just-released 1.9.1. `ExoPlayer` 1.9 is no longer trivially mockable, so I followed the [team's general guidance](androidx/media#2985 (comment)) to use a real ExoPlayer in a Robolectric test instead of mocking it. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Updates from 1.8.0 to the just-released 1.9.1.
ExoPlayer1.9 is no longer trivially mockable, so I followed the team's general guidance to use a real ExoPlayer in a Robolectric test instead of mocking it.Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2↩3