Skip to content

[quick_actions] Convert example to Swift - #10970

Merged
auto-submit[bot] merged 8 commits into
flutter:mainfrom
stuartmorgan-g:quick-actions-swift-example
Feb 7, 2026
Merged

[quick_actions] Convert example to Swift#10970
auto-submit[bot] merged 8 commits into
flutter:mainfrom
stuartmorgan-g:quick-actions-swift-example

Conversation

@stuartmorgan-g

@stuartmorgan-gstuartmorgan-g commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator

Replaces the Obj-C example app with Swift. Rather than attempt to modify the example in place, I started clean from the Swift template:

  • deleted the ios/ directory.
  • ran flutter create --platforms=ios . using current stable (3.38.9).
  • re-did the RunnerUITest setup process, and swapped in the existing test files for that and RunnerTest.
  • ran native tests and the example app to capture the auto-migration steps for CocoaPods.

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2↩3

@stuartmorgan-gstuartmorgan-g added the override: no versioning needed Override the check requiring version bumps for most changes label Feb 5, 2026
@stuartmorgan-gstuartmorgan-g added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Feb 5, 2026
@stuartmorgan-g

stuartmorgan-g commented Feb 5, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Changelog/version override: only affects example app config that's not relevant to clients.

stuartmorgan-g
stuartmorgan-g commented Feb 5, 2026
View reviewed changes
Comment thread...ctions/quick_actions_ios/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
BlueprintIdentifier = "686BE82C25E58CCF00862533"
BuildableName = "RunnerUITests.xctest"
BlueprintName = "RunnerUITests"
BlueprintIdentifier = "331C8080294A63A400263BE5"

@stuartmorgan-gstuartmorgan-gFeb 5, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I remade things, there is a fair amount of thrashing in the diffs around Xcode-generated identifiers, order of entries in the project file, etc. I didn't try to smooth those out since they don't really matter.

gemini-code-assist[bot]
gemini-code-assistBot reviewed Feb 5, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the iOS example application for the quick_actions package from Objective-C to Swift. The ios directory has been regenerated using a modern Swift-based Flutter project template. Changes include updating the Xcode project file (.pbxproj), configuration files (.xcconfig, .plist), and build schemes (.xcscheme) to reflect the new project structure and settings. The Objective-C AppDelegate has been replaced with a Swift equivalent. Existing native test files have been re-integrated into the new project. This is a valuable maintenance update that modernizes the example.

Comment threadpackages/quick_actions/quick_actions_ios/example/ios/Runner.xcodeproj/project.pbxproj Outdated
Comment threadpackages/quick_actions/quick_actions_ios/example/ios/Runner.xcodeproj/project.pbxproj Outdated
Comment threadpackages/quick_actions/quick_actions_ios/example/ios/Runner.xcodeproj/project.pbxproj Outdated
stuartmorgan-g
stuartmorgan-g commented Feb 5, 2026
View reviewed changes
Comment thread...uick_actions_ios/example/ios/Runner/Assets.xcassets/AppIcon.appiconset/Icon-App-20x20@1x.png

@stuartmorgan-gstuartmorgan-gFeb 5, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here; we could keep the old icons, but we already have copies of the new icons in the repo so in terms of repo size this is basically a no-op, and helps us standardize on current state.

LongCatIsLooong
LongCatIsLooong approved these changes Feb 6, 2026
View reviewed changes
Comment threadpackages/quick_actions/quick_actions_ios/example/ios/Runner/AppDelegate.swift Outdated
didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
) -> Bool {
GeneratedPluginRegistrant.register(with: self)
return super.application(application, didFinishLaunchingWithOptions: launchOptions)

@LongCatIsLooongLongCatIsLooongFeb 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The objc implementation returns NO here. Is the change intended?

@stuartmorgan-gstuartmorgan-gFeb 7, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I missed that it wasn't quite a stock AppDelegate.m. Great catch! I tracked this back to flutter-team-archive/plugins#3811

I'll change it, and add a comment so that it's more obvious to the next person looking at this code :)

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 7, 2026
@auto-submit
auto-submitBot merged commit ebacd56 into flutter:mainFeb 7, 2026
81 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 9, 2026
@engine-flutter-autoroll
ebacd563b [quick_actions] Convert example to Swift (flutter/packages#…
5ff2c5c
…10970)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Feb 9, 2026
Merged
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Feb 9, 2026
@engine-flutter-autoroll
Roll Packages from 7805d3e2d654 to 3d5eaa507f2d (3 revisions) (#182083)
f6a9598
flutter/packages@7805d3e...3d5eaa5
2026-02-08 engine-flutter-autoroll@skia.org Roll Flutter from
f916dd6 to e8f9dc5 (34 revisions) (flutter/packages#10979)
2026-02-07 stuartmorgan@google.com [quick_actions] Convert example to
Swift (flutter/packages#10970)
2026-02-07 robert.odrowaz@leancode.pl [camera_avfoundation] Pigeon swift
migration - part 1 (flutter/packages#10939)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter-zl pushed a commit to flutter-zl/flutter that referenced this pull request Feb 10, 2026
@engine-flutter-autoroll@flutter-zl
Roll Packages from 7805d3e2d654 to 3d5eaa507f2d (3 revisions) (flutte…
c75851b
…r#182083)
flutter/packages@7805d3e...3d5eaa5
2026-02-08 engine-flutter-autoroll@skia.org Roll Flutter from
f916dd6 to e8f9dc5 (34 revisions) (flutter/packages#10979)
2026-02-07 stuartmorgan@google.com [quick_actions] Convert example to
Swift (flutter/packages#10970)
2026-02-07 robert.odrowaz@leancode.pl [camera_avfoundation] Pigeon swift
migration - part 1 (flutter/packages#10939)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@stuartmorgan-gstuartmorgan-g mentioned this pull request Feb 11, 2026
Merged
11 tasks
rickhohler pushed a commit to rickhohler/flutter that referenced this pull request Feb 19, 2026
@engine-flutter-autoroll@rickhohler
Roll Packages from 7805d3e2d654 to 3d5eaa507f2d (3 revisions) (flutte…
708d081
…r#182083)
flutter/packages@7805d3e...3d5eaa5
2026-02-08 engine-flutter-autoroll@skia.org Roll Flutter from
f916dd6 to e8f9dc5 (34 revisions) (flutter/packages#10979)
2026-02-07 stuartmorgan@google.com [quick_actions] Convert example to
Swift (flutter/packages#10970)
2026-02-07 robert.odrowaz@leancode.pl [camera_avfoundation] Pigeon swift
migration - part 1 (flutter/packages#10939)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Mar 26, 2026
@engine-flutter-autoroll@mboetger
Roll Packages from 7805d3e2d654 to 3d5eaa507f2d (3 revisions) (flutte…
5a1776d
…r#182083)
flutter/packages@7805d3e...3d5eaa5
2026-02-08 engine-flutter-autoroll@skia.org Roll Flutter from
f916dd6 to e8f9dc5 (34 revisions) (flutter/packages#10979)
2026-02-07 stuartmorgan@google.com [quick_actions] Convert example to
Swift (flutter/packages#10970)
2026-02-07 robert.odrowaz@leancode.pl [camera_avfoundation] Pigeon swift
migration - part 1 (flutter/packages#10939)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@stuartmorgan-g
[quick_actions] Convert example to Swift (flutter#10970)
a29f05e
Replaces the Obj-C example app with Swift. Rather than attempt to modify the example in place, I started clean from the Swift template:
- deleted the ios/ directory.
- ran `flutter create --platforms=ios .` using current `stable` (3.38.9).
- re-did the [RunnerUITest setup process](https://github.com/flutter/flutter/blob/master/docs/ecosystem/testing/Plugin-Tests.md#enabling-xcuitests), and swapped in the existing test files for that and RunnerTest.
- ran native tests and the example app to capture the auto-migration steps for CocoaPods.
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LongCatIsLooongLongCatIsLooongLongCatIsLooong approved these changes
@LouiseHsuLouiseHsuAwaiting requested review from LouiseHsu
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appoverride: no changelog neededOverride the check requiring CHANGELOG updates for most changesoverride: no versioning neededOverride the check requiring version bumps for most changesp: quick_actionsplatform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g@LongCatIsLooong