Skip to content

[local_auth] Convert example app to Swift - #11003

Merged
auto-submit[bot] merged 8 commits into
flutter:mainfrom
stuartmorgan-g:local-auth-swift-example
Feb 18, 2026
Merged

[local_auth] Convert example app to Swift#11003
auto-submit[bot] merged 8 commits into
flutter:mainfrom
stuartmorgan-g:local-auth-swift-example

Conversation

@stuartmorgan-g

@stuartmorgan-gstuartmorgan-g commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

Replaces the Obj-C example app with Swift. Rather than attempt to modify the example in place, I started clean from the Swift template:

  • deleted the ios/ directory.
  • ran flutter create --platforms=ios . using current stable (3.41.0).

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2↩3

@stuartmorgan-gstuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Feb 11, 2026
@stuartmorgan-g

stuartmorgan-g commented Feb 11, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Changelog/version override: Native example app template details are not relevant to clients.

gemini-code-assist[bot]
gemini-code-assistBot reviewed Feb 11, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request converts the iOS example app for local_auth_darwin from Objective-C to Swift by regenerating the project from the latest Flutter stable template, updating project files and configurations. However, a critical vulnerability was introduced: the NSFaceIDUsageDescription key is missing from the Info.plist file. This absence will cause the app to crash when attempting biometric authentication with Face ID, making the example app non-functional on supported iOS hardware. Restoring this key is essential for the app to function correctly.

Comment threadpackages/local_auth/local_auth_darwin/example/ios/Runner/Info.plist
Comment threadpackages/local_auth/local_auth_darwin/example/ios/Runner/Info.plist
@vashworthvashworth added the triage-ios Should be looked at in iOS triage label Feb 12, 2026
LouiseHsu
LouiseHsu approved these changes Feb 18, 2026
View reviewed changes

@LouiseHsuLouiseHsu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 18, 2026
@auto-submit
auto-submitBot merged commit 87ea370 into flutter:mainFeb 18, 2026
81 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2026
@engine-flutter-autoroll
87ea3704a [local_auth] Convert example app to Swift (flutter/packages…
6e9883d
…#11003)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Feb 19, 2026
Merged
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Feb 19, 2026
@engine-flutter-autoroll
Roll Packages from 59f905ced6b8 to 9da22bf24a36 (8 revisions) (#182611)
7008d4a
flutter/packages@59f905c...9da22bf
2026-02-19 mit@google.com [cupertino_ui, material_ui] Fix capitalization
in README section headers (flutter/packages#11058)
2026-02-18 engine-flutter-autoroll@skia.org Manual roll Flutter from
6e4a481 to c023e5b (17 revisions) (flutter/packages#11060)
2026-02-18 steven@landow.dev [vector_graphics_compiler] support
percentage units SVG shape attributes (flutter/packages#10577)
2026-02-18 stuartmorgan@google.com [local_auth] Convert example app to
Swift (flutter/packages#11003)
2026-02-18 stuartmorgan@google.com [ci] Fix syntax error in auto-labeler
(flutter/packages#11052)
2026-02-18 github-admin@google.com Refactor Github Action per
b/485167538 (flutter/packages#11051)
2026-02-18 katelovett@google.com [material_ui] Add material_ui package
(flutter/packages#11043)
2026-02-18 katelovett@google.com [cupertino_ui] Add cupertino_ui package
(flutter/packages#11042)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ahmedsameha1 pushed a commit to ahmedsameha1/flutter that referenced this pull request Feb 27, 2026
@engine-flutter-autoroll@ahmedsameha1
Roll Packages from 59f905ced6b8 to 9da22bf24a36 (8 revisions) (flutte…
9ca2514
…r#182611)
flutter/packages@59f905c...9da22bf
2026-02-19 mit@google.com [cupertino_ui, material_ui] Fix capitalization
in README section headers (flutter/packages#11058)
2026-02-18 engine-flutter-autoroll@skia.org Manual roll Flutter from
6e4a481 to c023e5b (17 revisions) (flutter/packages#11060)
2026-02-18 steven@landow.dev [vector_graphics_compiler] support
percentage units SVG shape attributes (flutter/packages#10577)
2026-02-18 stuartmorgan@google.com [local_auth] Convert example app to
Swift (flutter/packages#11003)
2026-02-18 stuartmorgan@google.com [ci] Fix syntax error in auto-labeler
(flutter/packages#11052)
2026-02-18 github-admin@google.com Refactor Github Action per
b/485167538 (flutter/packages#11051)
2026-02-18 katelovett@google.com [material_ui] Add material_ui package
(flutter/packages#11043)
2026-02-18 katelovett@google.com [cupertino_ui] Add cupertino_ui package
(flutter/packages#11042)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah pushed a commit to okorohelijah/packages that referenced this pull request Mar 26, 2026
@stuartmorgan-g@okorohelijah
[local_auth] Convert example app to Swift (flutter#11003)
35a1b25
Replaces the Obj-C example app with Swift. Rather than attempt to modify the example in place, I started clean from the Swift template:
- deleted the ios/ directory.
- ran `flutter create --platforms=ios .` using current `stable` (3.41.0).
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Mar 26, 2026
@engine-flutter-autoroll@mboetger
Roll Packages from 59f905ced6b8 to 9da22bf24a36 (8 revisions) (flutte…
74cdd86
…r#182611)
flutter/packages@59f905c...9da22bf
2026-02-19 mit@google.com [cupertino_ui, material_ui] Fix capitalization
in README section headers (flutter/packages#11058)
2026-02-18 engine-flutter-autoroll@skia.org Manual roll Flutter from
6e4a481 to c023e5b (17 revisions) (flutter/packages#11060)
2026-02-18 steven@landow.dev [vector_graphics_compiler] support
percentage units SVG shape attributes (flutter/packages#10577)
2026-02-18 stuartmorgan@google.com [local_auth] Convert example app to
Swift (flutter/packages#11003)
2026-02-18 stuartmorgan@google.com [ci] Fix syntax error in auto-labeler
(flutter/packages#11052)
2026-02-18 github-admin@google.com Refactor Github Action per
b/485167538 (flutter/packages#11051)
2026-02-18 katelovett@google.com [material_ui] Add material_ui package
(flutter/packages#11043)
2026-02-18 katelovett@google.com [cupertino_ui] Add cupertino_ui package
(flutter/packages#11042)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@stuartmorgan-g
[local_auth] Convert example app to Swift (flutter#11003)
1198964
Replaces the Obj-C example app with Swift. Rather than attempt to modify the example in place, I started clean from the Swift template:
- deleted the ios/ directory.
- ran `flutter create --platforms=ios .` using current `stable` (3.41.0).
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LouiseHsuLouiseHsuLouiseHsu approved these changes
@okorohelijahokorohelijahAwaiting requested review from okorohelijah
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appoverride: no changelog neededOverride the check requiring CHANGELOG updates for most changesoverride: no versioning neededOverride the check requiring version bumps for most changesp: local_authplatform-iosplatform-macostriage-iosShould be looked at in iOS triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stuartmorgan-g@LouiseHsu@vashworth