Skip to content

[video_player_android] Remove usesCleartextTraffic - #11075

Merged
auto-submit[bot] merged 5 commits into
flutter:mainfrom
mboetger:remove-uses-cleartext-traffic-video-player-android
Feb 25, 2026
Merged

[video_player_android] Remove usesCleartextTraffic#11075
auto-submit[bot] merged 5 commits into
flutter:mainfrom
mboetger:remove-uses-cleartext-traffic-video-player-android

Conversation

@mboetger

@mboetgermboetger commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

Removes deprecated usesCleartextTraffic.

Addresses: flutter/flutter#182553

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@mboetgermboetger changed the title Remove uses cleartext traffic video player android[video_player_android] Remove usesCleartextTrafficFeb 19, 2026

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request removes the android:usesCleartextTraffic="true" attribute from the AndroidManifest.xml in the debug example application. This change addresses the deprecation of cleartext traffic usage, enhancing the security posture of the application by preventing unencrypted network communication. The change is minimal and directly targets the stated issue.

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

test-exempt: configuration change

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

This one should get an equivalent network config to allow for re-enabling

someday.

@mboetger

Copy link
Copy Markdown
ContributorAuthor

This one should get an equivalent network config to allow for re-enabling

someday.

This one already has a network security config actually, which is why I didn't add it - just hooked up the AndroidManifest.xml:

https://github.com/flutter/packages/blob/main/packages/video_player/video_player_android/example/android/app/src/main/res/xml/network_security_config.xml#L4

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice. LGTM

@mboetgermboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 25, 2026
@auto-submit
auto-submitBot merged commit b9ee0b3 into flutter:mainFeb 25, 2026
81 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 26, 2026
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Feb 26, 2026
flutter/packages@acd9adb...e1d0169
2026-02-26 katelovett@google.com [rfw] Remove outdated info from README
(flutter/packages#11123)
2026-02-25 stuartmorgan@google.com [local_auth] Federate READMEs
(flutter/packages#11112)
2026-02-25 matt.boetger@gmail.com [google_sign_in] Remove
usersCleartextTraffic (flutter/packages#11121)
2026-02-25 srawlins@google.com Tidy up some contributing text, and note
tools needed for formatting. (flutter/packages#11113)
2026-02-25 matt.boetger@gmail.com [video_player_android] Remove
usesCleartextTraffic (flutter/packages#11075)
2026-02-25 stuartmorgan@google.com Adjust the version/changelog
checklist entries (flutter/packages#11120)
2026-02-25 stuartmorgan@google.com [camera] Convert iOS event channel to
Pigeon (flutter/packages#11109)
2026-02-25 8490712+ruicraveiro@users.noreply.github.com [camera] add
video stabilization (flutter/packages#7108)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Feb 26, 2026
flutter/packages@acd9adb...e1d0169
2026-02-26 katelovett@google.com [rfw] Remove outdated info from README
(flutter/packages#11123)
2026-02-25 stuartmorgan@google.com [local_auth] Federate READMEs
(flutter/packages#11112)
2026-02-25 matt.boetger@gmail.com [google_sign_in] Remove
usersCleartextTraffic (flutter/packages#11121)
2026-02-25 srawlins@google.com Tidy up some contributing text, and note
tools needed for formatting. (flutter/packages#11113)
2026-02-25 matt.boetger@gmail.com [video_player_android] Remove
usesCleartextTraffic (flutter/packages#11075)
2026-02-25 stuartmorgan@google.com Adjust the version/changelog
checklist entries (flutter/packages#11120)
2026-02-25 stuartmorgan@google.com [camera] Convert iOS event channel to
Pigeon (flutter/packages#11109)
2026-02-25 8490712+ruicraveiro@users.noreply.github.com [camera] add
video stabilization (flutter/packages#7108)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ahmedsameha1 pushed a commit to ahmedsameha1/flutter that referenced this pull request Feb 27, 2026
…r#182946)
flutter/packages@acd9adb...e1d0169
2026-02-26 katelovett@google.com [rfw] Remove outdated info from README
(flutter/packages#11123)
2026-02-25 stuartmorgan@google.com [local_auth] Federate READMEs
(flutter/packages#11112)
2026-02-25 matt.boetger@gmail.com [google_sign_in] Remove
usersCleartextTraffic (flutter/packages#11121)
2026-02-25 srawlins@google.com Tidy up some contributing text, and note
tools needed for formatting. (flutter/packages#11113)
2026-02-25 matt.boetger@gmail.com [video_player_android] Remove
usesCleartextTraffic (flutter/packages#11075)
2026-02-25 stuartmorgan@google.com Adjust the version/changelog
checklist entries (flutter/packages#11120)
2026-02-25 stuartmorgan@google.com [camera] Convert iOS event channel to
Pigeon (flutter/packages#11109)
2026-02-25 8490712+ruicraveiro@users.noreply.github.com [camera] add
video stabilization (flutter/packages#7108)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
xxxOVALxxx pushed a commit to xxxOVALxxx/flutter that referenced this pull request Mar 10, 2026
…r#182946)
flutter/packages@acd9adb...e1d0169
2026-02-26 katelovett@google.com [rfw] Remove outdated info from README
(flutter/packages#11123)
2026-02-25 stuartmorgan@google.com [local_auth] Federate READMEs
(flutter/packages#11112)
2026-02-25 matt.boetger@gmail.com [google_sign_in] Remove
usersCleartextTraffic (flutter/packages#11121)
2026-02-25 srawlins@google.com Tidy up some contributing text, and note
tools needed for formatting. (flutter/packages#11113)
2026-02-25 matt.boetger@gmail.com [video_player_android] Remove
usesCleartextTraffic (flutter/packages#11075)
2026-02-25 stuartmorgan@google.com Adjust the version/changelog
checklist entries (flutter/packages#11120)
2026-02-25 stuartmorgan@google.com [camera] Convert iOS event channel to
Pigeon (flutter/packages#11109)
2026-02-25 8490712+ruicraveiro@users.noreply.github.com [camera] add
video stabilization (flutter/packages#7108)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah pushed a commit to okorohelijah/packages that referenced this pull request Mar 26, 2026
Removes deprecated usesCleartextTraffic. Addresses: #182553
## Pre-Review Checklist
mboetger pushed a commit to mboetger/flutter that referenced this pull request Mar 26, 2026
…r#182946)
flutter/packages@acd9adb...e1d0169
2026-02-26 katelovett@google.com [rfw] Remove outdated info from README
(flutter/packages#11123)
2026-02-25 stuartmorgan@google.com [local_auth] Federate READMEs
(flutter/packages#11112)
2026-02-25 matt.boetger@gmail.com [google_sign_in] Remove
usersCleartextTraffic (flutter/packages#11121)
2026-02-25 srawlins@google.com Tidy up some contributing text, and note
tools needed for formatting. (flutter/packages#11113)
2026-02-25 matt.boetger@gmail.com [video_player_android] Remove
usesCleartextTraffic (flutter/packages#11075)
2026-02-25 stuartmorgan@google.com Adjust the version/changelog
checklist entries (flutter/packages#11120)
2026-02-25 stuartmorgan@google.com [camera] Convert iOS event channel to
Pigeon (flutter/packages#11109)
2026-02-25 8490712+ruicraveiro@users.noreply.github.com [camera] add
video stabilization (flutter/packages#7108)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
Removes deprecated usesCleartextTraffic. Addresses: #182553
## Pre-Review Checklist
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: video_playerplatform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mboetger@stuartmorgan-g