Skip to content

Sync release-go_router to main - #11425

Closed
fluttergithubbot wants to merge 2 commits into
mainfrom
release-go_router
Closed

Sync release-go_router to main#11425
fluttergithubbot wants to merge 2 commits into
mainfrom
release-go_router

Conversation

@fluttergithubbot

Copy link
Copy Markdown
Contributor

This automated PR syncs the changes from the release branch release-go_router back to the main branch.

fluttergithubbotand others added 2 commits April 2, 2026 22:36
This PR was created automatically to batch release the `go_router`.
@fluttergithubbotfluttergithubbot added the post-release-go_router A label to indicate this is a clean up PR after go_router release label Apr 2, 2026
@github-actionsgithub-actionsBot added p: go_router triage-framework Should be looked at in framework triage labels Apr 2, 2026

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the go_router package to version 17.2.0, introducing a fix for navigation callbacks in Block.then() and Allow.then() and adding encoder, decoder, and compare parameters to the TypedQueryParameter annotation. A review comment suggests a more precise description in the changelog regarding the application of these parameters in type-safe route constructors.

## 17.2.0

- Fixes `Block.then()` and `Allow.then()` navigation callbacks being silently lost when triggered by `refreshListenable` due to re-entrant route processing.
- Adds `encoder`, `decoder` and `compare` parameters to `TypedQueryParameter` annotation for custom encoding, decoding and comparison of query parameters in `TypedGoRoute` constructors.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrasing "TypedGoRoute constructors" is slightly inaccurate and potentially confusing. TypedGoRoute is the annotation class itself, and its constructor does not accept these parameters. The TypedQueryParameter annotation is actually used on parameters within the constructors of user-defined classes that extend GoRouteData (or RelativeGoRouteData). Referring to them as "type-safe route constructors" or "GoRouteData constructors" would be more precise and consistent with the documentation for this feature.

Suggested change
- Adds `encoder`, `decoder` and `compare` parameters to `TypedQueryParameter` annotation for custom encoding, decoding and comparison of query parameters in `TypedGoRoute` constructors.
- Adds `encoder`, `decoder` and `compare` parameters to `TypedQueryParameter` annotation for custom encoding, decoding and comparison of query parameters in type-safe route constructors.

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtaichunhtai added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Apr 2, 2026
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2026
@auto-submit

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/11425, because - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtai

Copy link
Copy Markdown
Contributor

blocked on #11429

@chunhtaichunhtai closed this Apr 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICDRun CI/CDp: go_routerpost-release-go_routerA label to indicate this is a clean up PR after go_router releasetriage-frameworkShould be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@fluttergithubbot@chunhtai