Uh oh!
There was an error while loading. Please reload this page.
[go_router] Fix assertion failure on URLs with hash fragments missing leading slash - #11431
Merged
auto-submit[bot] merged 3 commits intoApr 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies RouteConfiguration.normalizeUri to ensure paths consistently start with a leading slash and removes trailing slashes for paths longer than one character. It includes new unit and widget tests to verify these changes and ensure that query parameters and fragments are preserved. A review comment suggests optimizing the normalization process by returning the original URI when no path changes are required to avoid unnecessary object allocation.
Uh oh!
There was an error while loading. Please reload this page.
chunhtaiforce-pushed
the
fix-assertion-missing-slash
branch
from
April 21, 2026 22:45
f5a9d3a to
65d4f39CompareUh oh!
There was an error while loading. Please reload this page.
vashworth pushed a commit
to vashworth/flutter
that referenced
this pull request
Apr 22, 2026
…r#185417) flutter/packages@7c8e13e...4a2091d 2026-04-21 47866232+chunhtai@users.noreply.github.com [go_router] Fix assertion failure on URLs with hash fragments missing leading slash (flutter/packages#11431) 2026-04-21 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Tear down ProxyAPIRegistrar in `applicationWillTerminate` (flutter/packages#11484) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixesflutter/flutter#184109
Fixesflutter/flutter#181629