Skip to content

[flutter_svg] Remove generated CMake files - #11459

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:missed-plugin-cmake-removal
Apr 7, 2026
Merged

[flutter_svg] Remove generated CMake files#11459
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:missed-plugin-cmake-removal

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Removes files that were missed in
#11455, causing pub publish checks to fail due to a mismatch between checked in and ignored files.

Removes files that were missed in
flutter#11455, causing `pub publish`
checks to fail due to a mismatch between checked in and ignored files.
@stuartmorgan-gstuartmorgan-g added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Apr 7, 2026
@github-actionsgithub-actionsBot added p: flutter_svg triage-engine Should be looked at in engine triage labels Apr 7, 2026

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes generated CMake configuration files for Linux and Windows plugin management from the ephemeral directory. I have no feedback to provide.

@bparrishMinesbparrishMines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-gstuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. labels Apr 7, 2026
@flutter-dashboard

Copy link
Copy Markdown

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@auto-submit
auto-submitBot merged commit d9a2050 into flutter:mainApr 7, 2026
80 of 81 checks passed
@stuartmorgan-g
stuartmorgan-g deleted the missed-plugin-cmake-removal branch April 7, 2026 18:26
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2026
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Apr 9, 2026
flutter/packages@0e0a032...1aa892c
2026-04-09 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_android] Adds support to opt out of Android inset
changes (flutter/packages#11192)
2026-04-08 engine-flutter-autoroll@skia.org Roll Flutter from
a0924c7 to 05e0ae0 (24 revisions) (flutter/packages#11470)
2026-04-08 stuartmorgan@google.com [pigeon] Make Kotlin FlutterError a
runtime error (flutter/packages#11469)
2026-04-08 stuartmorgan@google.com [path_provider] Remove dependency on
engine PathUtils (flutter/packages#11467)
2026-04-07 1063596+reidbaker@users.noreply.github.com [all] Prepare
packages for skills (flutter/packages#11430)
2026-04-07 engine-flutter-autoroll@skia.org Roll Flutter from
9cd60b5 to a0924c7 (13 revisions) (flutter/packages#11463)
2026-04-07 elitree@gmail.com [google_maps_flutter] Android cluster pin
info window onTap callback not firing (flutter/packages#11390)
2026-04-07 stuartmorgan@google.com [flutter_svg] Remove generated CMake
files (flutter/packages#11459)
2026-04-07 stuartmorgan@google.com [various] Convert remaining Groovy
files to Kotlin (flutter/packages#11443)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mbcorona pushed a commit to mbcorona/flutter that referenced this pull request Apr 15, 2026
…r#184829)
flutter/packages@0e0a032...1aa892c
2026-04-09 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_android] Adds support to opt out of Android inset
changes (flutter/packages#11192)
2026-04-08 engine-flutter-autoroll@skia.org Roll Flutter from
a0924c7 to 05e0ae0 (24 revisions) (flutter/packages#11470)
2026-04-08 stuartmorgan@google.com [pigeon] Make Kotlin FlutterError a
runtime error (flutter/packages#11469)
2026-04-08 stuartmorgan@google.com [path_provider] Remove dependency on
engine PathUtils (flutter/packages#11467)
2026-04-07 1063596+reidbaker@users.noreply.github.com [all] Prepare
packages for skills (flutter/packages#11430)
2026-04-07 engine-flutter-autoroll@skia.org Roll Flutter from
9cd60b5 to a0924c7 (13 revisions) (flutter/packages#11463)
2026-04-07 elitree@gmail.com [google_maps_flutter] Android cluster pin
info window onTap callback not firing (flutter/packages#11390)
2026-04-07 stuartmorgan@google.com [flutter_svg] Remove generated CMake
files (flutter/packages#11459)
2026-04-07 stuartmorgan@google.com [various] Convert remaining Groovy
files to Kotlin (flutter/packages#11443)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
Removes files that were missed in
flutter#11455, causing `pub publish` checks to fail due to a mismatch between checked in and ignored files.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDemergencyOverride tree-status signal (land even with closed tree), combine with the autosubmit label.override: no changelog neededOverride the check requiring CHANGELOG updates for most changesp: flutter_svgtriage-engineShould be looked at in engine triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g@bparrishMines