Skip to content

[tool] Update java formatter - #11508

Merged
auto-submit[bot] merged 6 commits into
flutter:mainfrom
stuartmorgan-g:update-java-formatter
Apr 15, 2026
Merged

[tool] Update java formatter#11508
auto-submit[bot] merged 6 commits into
flutter:mainfrom
stuartmorgan-g:update-java-formatter

Conversation

@stuartmorgan-g

@stuartmorgan-gstuartmorgan-g commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator

Updates the Java formatter from 1.3 to 1.28, which is the latest version of the formatter that can be run with Java 17. Version 1.3 doesn't understand newer Java syntax that we could be using in plugins now that they all require Java 17, such as pattern expressions and switch expressions.

The changes outside of script/tool/ ware made by:

  • Running the repo tool format command with the new version.
  • Asking Gemini to fix up some bad comment wrapping in the autoformat changes (committed as a separate commit, for ease of reviewing). The new formatter enforces line length limits on comments, but doesn't re-wrap later lines after adding breaks, resulting in some comments like: 
    // Some long comment whose first line was slightly too// long// and then a bit more.

@stuartmorgan-gstuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes triage-android Should be looked at in Android triage labels Apr 14, 2026
@stuartmorgan-g

stuartmorgan-g commented Apr 14, 2026

Copy link
Copy Markdown
CollaboratorAuthor

CHANGELOG/version override: These are just format changes in native code, so there is value to clients in releasing them.

@stuartmorgan-gstuartmorgan-g added the CICD Run CI/CD label Apr 14, 2026
gemini-code-assist[bot]
gemini-code-assistBot reviewed Apr 14, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Java formatter to version 1.28.0 in the tool script and applies various formatting and documentation improvements across multiple Android plugin packages, including camera, file_selector, google_maps_flutter, image_picker, in_app_purchase, quick_actions, shared_preferences, url_launcher, video_player, webview_flutter, and pigeon-generated code. I have no feedback to provide.

@github-actionsgithub-actionsBot removed the CICD Run CI/CD label Apr 15, 2026
@stuartmorgan-gstuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Apr 15, 2026
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2026
@auto-submit

auto-submitBot commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/11508, because Pull request flutter/packages/11508 is not in a mergeable state.

@stuartmorgan-gstuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD and removed CICD Run CI/CD labels Apr 15, 2026
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label Apr 15, 2026
@auto-submit
auto-submitBot merged commit a9d6c1c into flutter:mainApr 15, 2026
82 checks passed
@stuartmorgan-g
stuartmorgan-g deleted the update-java-formatter branch April 15, 2026 14:38
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 20, 2026
Merged
pullBot pushed a commit to Klomgor/flutter that referenced this pull request Apr 20, 2026
@engine-flutter-autoroll
Roll Packages from c2e3d1f86b5b to 01c505f1db24 (21 revisions) (flutt…
57fc438
…er#185287)
flutter/packages@c2e3d1f...01c505f
2026-04-20 engine-flutter-autoroll@skia.org Roll Flutter from
8e8a194 to 2844af6 (13 revisions) (flutter/packages#11531)
2026-04-17 stuartmorgan@google.com [google_maps_fluter] Switch to Kotlin
Pigeon (flutter/packages#11522)
2026-04-17 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
db50e20 to cc0734a (8 revisions) (flutter/packages#11525)
2026-04-17 engine-flutter-autoroll@skia.org Roll Flutter from
31f1802 to 8e8a194 (22 revisions) (flutter/packages#11523)
2026-04-17 stuartmorgan@google.com [google_maps_flutter] Fix various
Java warnings (flutter/packages#11516)
2026-04-16 srawlins@google.com [google_maps_flutter] Use super
parameters in more places in examples (flutter/packages#11517)
2026-04-16 engine-flutter-autoroll@skia.org Roll Flutter from
c1b14e9 to 31f1802 (46 revisions) (flutter/packages#11518)
2026-04-15 stuartmorgan@google.com [tool] Update java formatter
(flutter/packages#11508)
2026-04-15 stuartmorgan@google.com [quick_actions] Remove manual thread
hop in Android response (flutter/packages#11445)
2026-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump
lewagon/wait-on-check-action from 1.6.0 to 1.7.0 in the
all-github-actions group (flutter/packages#11510)
2026-04-14 magder@google.com Skip dependabot updates for minor versions
of gradle and kotlin (flutter/packages#11509)
2026-04-14 chick.developer@gmail.com [go_router] Fix pop() restoring
stale configuration when route has onExit (flutter/packages#11241)
2026-04-14 stuartmorgan@google.com [url_launcher] Switch to Kotlin
Pigeon (flutter/packages#11473)
2026-04-14 okorohelijah@google.com [pr-fix] Run all flutter/packages
macOS tests using Xcode 26 and iOS 26 simulator (flutter/packages#10635)
2026-04-14 bolling.ludwig@gmail.com [camera_platform_interface] Add
setJpegImageQuality method (flutter/packages#11454)
2026-04-14 engine-flutter-autoroll@skia.org Roll Flutter from
2fa45e0 to c1b14e9 (19 revisions) (flutter/packages#11506)
2026-04-14 stuartmorgan@google.com [local_auth] Switch to Kotlin Pigeon
(flutter/packages#11482)
2026-04-13 fluttergithub-bot@google.com Sync release-go_router to main
(flutter/packages#11499)
2026-04-13 slater.jay@gmail.com [mustache_template] Fix auto-generated
specification tests, run with `dart test` (flutter/packages#11056)
2026-04-13 engine-flutter-autoroll@skia.org Roll Flutter from
bf18e39 to 2fa45e0 (19 revisions) (flutter/packages#11497)
2026-04-10 engine-flutter-autoroll@skia.org Roll Flutter from
81c87ea to bf18e39 (18 revisions) (flutter/packages#11488)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@stuartmorgan-g
[tool] Update java formatter (flutter#11508)
21f1831
Updates the Java formatter from 1.3 to 1.28, which is the latest version of the formatter that can be run with Java 17. Version 1.3 doesn't understand newer Java syntax that we could be using in plugins now that they all require Java 17, such as pattern expressions and switch expressions.
The changes outside of script/tool/ ware made by:
- Running the repo tool `format` command with the new version.
- Asking Gemini to fix up some bad comment wrapping in the autoformat changes (committed as a separate commit, for ease of reviewing). The new formatter enforces line length limits on comments, but doesn't re-wrap later lines after adding breaks, resulting in some comments like:
```java
// Some long comment whose first line was slightly too
// long
// and then a bit more.
```
Istiak-Ahmed78 pushed a commit to Istiak-Ahmed78/packages that referenced this pull request Jun 19, 2026
@stuartmorgan-g@Istiak-Ahmed78
[tool] Update java formatter (flutter#11508)
d8e2ad8
Updates the Java formatter from 1.3 to 1.28, which is the latest version of the formatter that can be run with Java 17. Version 1.3 doesn't understand newer Java syntax that we could be using in plugins now that they all require Java 17, such as pattern expressions and switch expressions.
The changes outside of script/tool/ ware made by:
- Running the repo tool `format` command with the new version.
- Asking Gemini to fix up some bad comment wrapping in the autoformat changes (committed as a separate commit, for ease of reviewing). The new formatter enforces line length limits on comments, but doesn't re-wrap later lines after adding breaks, resulting in some comments like:
```java
// Some long comment whose first line was slightly too
// long
// and then a bit more.
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbakerreidbakerreidbaker approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appoverride: no changelog neededOverride the check requiring CHANGELOG updates for most changesoverride: no versioning neededOverride the check requiring version bumps for most changesp: camerap: espressop: file_selectorp: flutter_plugin_android_lifecyclep: google_maps_flutterp: image_pickerp: in_app_purchasep: pigeonp: quick_actionsp: shared_preferencesp: url_launcherp: video_playerp: webview_flutterplatform-androidtriage-androidShould be looked at in Android triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g@reidbaker