Uh oh!
There was an error while loading. Please reload this page.
[google_maps_flutter] Fix styles on web - #11629
Merged
Merged
Conversation
Fixes a regression from flutter#7882 that caused non-cloud map styling not be applied on web, since the app-facing package changed to sending '' rather than null when a cloud mapId wasn't provided, and the web implementation didn't handle that case. Fixesflutter/flutter#185171
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in the Google Maps Flutter Web implementation where non-cloud styles were not being applied when an empty string was passed as a map ID. The changes ensure that an empty map ID is treated as null, allowing custom styles to be correctly applied. Additionally, the PR includes updated integration tests to verify this behavior and minor documentation cleanup. A suggestion was made to simplify the logic for handling the map ID string to improve readability.
Uh oh!
There was an error while loading. Please reload this page.
mdebbar
approved these changes
May 1, 2026
…onvert.dart Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
autosubmit label was removed for flutter/packages/11629, because - The status or check suite Mac_x64 ios_build_all_packages stable has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Uh oh!
There was an error while loading. Please reload this page.
This was referenced May 4, 2026
pullBot
pushed a commit
to mikeyhodl/flutter
that referenced
this pull request
May 4, 2026
…r#186002) flutter/packages@daf30f8...a2ad7e3 2026-05-04 stuartmorgan@google.com [tool] Extract most conformance checks to separate validator classes (flutter/packages#11610) 2026-05-01 fluttergithubbot@gmail.com Sync release-go_router-17.2.3 to main (flutter/packages#11633) 2026-05-01 engine-flutter-autoroll@skia.org Roll Flutter from 81bc3d6 to 707dbc0 (85 revisions) (flutter/packages#11630) 2026-05-01 stuartmorgan@google.com [google_maps_flutter] Fix styles on web (flutter/packages#11629) 2026-05-01 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 02085fe to 00b0c91 (3 revisions) (flutter/packages#11627) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
Fixes a regression from flutter#7882 that caused non-cloud map styling not be applied on web, since the app-facing package changed to sending '' rather than null when a cloud mapId wasn't provided, and the web implementation didn't handle that case. Fixesflutter/flutter#185171 *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression from #7882 that caused non-cloud map styling not be applied on web, since the app-facing package changed to sending '' rather than null when a cloud mapId wasn't provided, and the web implementation didn't handle that case.
Fixesflutter/flutter#185171
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2