Uh oh!
There was an error while loading. Please reload this page.
[video_player] Add missing swift_version to podspec - #11670
Conversation
Adds a `swift_version` to the podspec of `video_player_avfoundation`, to fix a build error when building with CocoaPods in a project that doesn't itself have a Swift version set. Updates the repo tooling `podspec-check` command to check for this, so that we don't forget it in future migrations. Also fixes some missing ignores in `podspec-check` that caused false positives when running the check locally in a tree that has built plugins. Fixesflutter/flutter#186232
There was a problem hiding this comment.
Code Review
This pull request updates the video_player_avfoundation package to include a Swift version in its podspec and enhances the podspec-check tool to enforce this requirement for all plugins containing Swift code. The tool's logic was also updated to ignore build directories during file discovery. Review feedback suggests refining the path-checking logic to prevent false positives when the repository resides in a directory named 'build', simplifying path segment comparisons, and making the Swift version regex more specific to avoid matching comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…r#186350) flutter/packages@92552b1...19ec8b8 2026-05-11 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 6.0.1 to 6.1.0 in the all-github-actions group (flutter/packages#11686) 2026-05-08 suojae.developer@gmail.com [flutter_svg] add imageBuilder property to SvgPicture (flutter/packages#11615) 2026-05-08 katelovett@google.com [material_ui, cupertino_ui, infra] Support skipping golden files for the design migration (flutter/packages#11649) 2026-05-08 stuartmorgan@google.com [video_player] Add missing swift_version to podspec (flutter/packages#11670) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Adds a `swift_version` to the podspec of `video_player_avfoundation`, to fix a build error when building with CocoaPods in a project that doesn't itself have a Swift version set. Updates the repo tooling `podspec-check` command to check for this, so that we don't forget it in future migrations. Also fixes some missing ignores in `podspec-check` that caused false positives when running the check locally in a tree that has built plugins. Fixesflutter/flutter#186232 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Adds a
swift_versionto the podspec ofvideo_player_avfoundation, to fix a build error when building with CocoaPods in a project that doesn't itself have a Swift version set.Updates the repo tooling
podspec-checkcommand to check for this, so that we don't forget it in future migrations.Also fixes some missing ignores in
podspec-checkthat caused false positives when running the check locally in a tree that has built plugins.Fixesflutter/flutter#186232
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2