Sync analysis_options.yaml with flutter/flutter

[stuartmorgan-g]

Pulls in changes from flutter/flutter's analysis_options.yaml since the last since at the end of 2023.

• invalid_runtime_check_with_js_interop_types is disabled for now; see [various] invalid_runtime_check_with_js_interop_types violations in web packages flutter#187454
• dart fix --apply has been run on all packages, which auto-fixed a lot of cases of unnecessary_underscores, and a handful of avoid_final_parameters

[gemini-code-assist]

Code Review

This pull request updates the analysis_options.yaml configuration to align with a newer version of the Flutter repository, enabling several linter rules including avoid_final_parameters and unnecessary_underscores. To comply with these new rules, the changes replace multi-underscore unused parameters with single underscores and remove the final keyword from parameter declarations across multiple packages. There are no review comments to address, and no additional feedback is provided.

[justinmc]

LGTM 👍 . Thank you for the help here!

[justinmc]

Looks like there's still some analyzer errors:

 info - lib/src/common/pub_version_finder.dart:54:12 - Parameters should not be marked as 'final'. Try removing the keyword 'final'. - avoid_final_parameters
info - lib/src/fetch_deps_command.dart:290:5 - Parameters should not be marked as 'final'. Try removing the keyword 'final'. - avoid_final_parameters
info - test/common/output_utils_test.dart:99:16 - Unnecessary use of multiple underscores. Try using '_'. - unnecessary_underscores
info - test/common/output_utils_test.dart:99:20 - Unnecessary use of multiple underscores. Try using '_'. - unnecessary_underscores
info - test/license_check_command_test.dart:477:11 - Don't use adjacent strings in a list literal. Try adding a comma between the strings. - no_adjacent_strings_in_list
info - test/util.dart:366:16 - Unnecessary use of multiple underscores. Try using '_'. - unnecessary_underscores
info - test/util.dart:366:20 - Unnecessary use of multiple underscores. Try using '_'. - unnecessary_underscores

[stuartmorgan-g]

Version/changelog override: the source changes here are clearly no-ops for runtime behavior, so we'll skip releasing for this, and they aren't interesting to clients so don't need to be in the changelog.

[stuartmorgan-g]

(I know this is currently failing the autoformat check; I didn't bother formatting since I want to land #11692 first and then update this, rather than landing this first and causing conflicts there that require yet another round of reformatting the entire repo.)

[justinmc]

Looks like a single analyzer failure:

 info - test/license_check_command_test.dart:427:11 - Don't use adjacent strings in a list literal. Try adding a comma between the strings. - no_adjacent_strings_in_list

And a test failure in the pigeon package. I don't know what that's about.

[stuartmorgan-g]

The pigeon failure is a known flake, unrelated to the PR.

[auto-submit]

autosubmit label was removed for flutter/packages/11823, because - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

[justinmc]

I just re-ran the failed test. It was happening in a package that was not touched by this PR. Not sure if it's a flake but worth a shot.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8679925651609296113/+/u/Run_package_tests/drive_examples/stdout

The following PathNotFoundException was thrown running a test:
Cannot open file, path =
'/Users/chrome-bot/Library/Caches/dev.flutter.plugins.pathProviderExample/temporaryDirectory' (OS
Error: No such file or directory, errno = 2)
When the exception was thrown, this was the stack:
#0 _File.throwIfError (dart:io/file_impl.dart:779:7)
#1 _File.openSync (dart:io/file_impl.dart:572:5)
#2 _File.writeAsBytesSync (dart:io/file_impl.dart:744:31)
#3 _File.writeAsStringSync (dart:io/file_impl.dart:772:5)
#4 _verifySampleFile (file:///Volumes/Work/s/w/ir/x/w/packages/packages/path_provider/path_provider/example/integration_test/path_provider_test.dart:124:8)
#5 main.<anonymous closure> (file:///Volumes/Work/s/w/ir/x/w/packages/packages/path_provider/path_provider/example/integration_test/path_provider_test.dart:15:5)
<asynchronous suspension>
#6 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:192:15)
<asynchronous suspension>
#7 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1953:5)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)
The test description was:
getTemporaryDirectory

[stuartmorgan-g]

Yeah, I've run it several times. Same with another PR I have open right now. I filed flutter/flutter#187563 this morning, and I am about to start seeing if I can fix it.

[stuartmorgan-g]

Seems like #11841 did the trick 🎉

[justinmc]

Great, I'm updating #11669!