[pigeon] Report a clear error for enhanced enums

[theprantadutta]

Pigeon's input parser silently ignored the extra syntax in enhanced enums (constructors, fields, methods, or arguments on values), reading only the value names. This produced confusing generated output — as described in the linked issue, the enum's fields were effectively coalesced into the next class — with no indication that the input was unsupported.

This change detects enhanced enums in visitEnumDeclaration and reports a clear, source-located error:

Pigeon doesn't support enhanced enums ("Enum1"). Use a plain enum without a constructor, fields, methods, or arguments on its values.

Implementation notes:

• The enum is still registered by its value names so that classes referencing it don't produce additional cascading "Unknown type" errors — the user sees exactly one actionable message, and recording the error already prevents code generation.
• The visitor no longer walks the enhanced enum's body. Its class-like members aren't expected outside of a class by the rest of the visitor; in particular, a getter inside an enum previously crashed the parser on a null parameter list (visitMethodDeclaration's node.parameters!). One of the new tests covers this case.
• Plain enums (including the legal trailing-semicolon form enum E { a, b; }) are unaffected; a test guards against false positives.

The scope follows the approach discussed and agreed in the issue thread (silent failure → clear error; no attempt to actually support enhanced enums).

Fixesflutter/flutter#160827

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I followed the version and CHANGELOG instructions, using semantic versioning and the repository CHANGELOG style, or I have commented below to indicate which documented exception this PR falls under.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under.
• All existing and new tests are passing.

Four new tests in pigeon_lib_test.dart: enhanced enum with constructor+fields, enhanced enum with only arguments on values, enhanced enum with a getter (the previous parser-crash case), and a plain enum with a trailing semicolon (false-positive guard). The full pigeon_lib_test.dart suite (113 tests) and version_test.dart pass locally.

[gemini-code-assist]

Code Review

This pull request updates Pigeon to version 27.0.1 and introduces detection for unsupported enhanced enums in Dart input files. When an enhanced enum (defined by having members or constant arguments) is detected, Pigeon now emits a clear error message and avoids visiting its children to prevent parser crashes. Feedback on these changes suggests expanding the enhanced enum detection to also check for type parameters, mixins, and implemented interfaces to ensure all unsupported cases are caught.

[gemini-code-assist]

Enhanced enums in Dart can also declare type parameters, implement interfaces, or use mixins (using with or implements clauses). The current check only detects enhanced enums with members or constant arguments. To fully prevent unsupported enhanced enums from causing issues, we should also check for node.typeParameters, node.withClause, and node.implementsClause.

finalbool hasEnumMembers = node.body.members.isNotEmpty;
finalbool hasConstantArguments = node.body.constants.any(
(dart_ast.EnumConstantDeclaration e) => e.arguments !=null,
);
finalbool isEnhancedEnum = hasEnumMembers ||
hasConstantArguments ||
node.typeParameters !=null||
node.withClause !=null||
node.implementsClause !=null;

[theprantadutta]

Rebased onto latest main to clear the merge conflict. The only conflict was the version bump — re-bumped from 27.0.1 to 27.1.1 (stacked above the current 27.1.0) in pubspec.yaml, generator_tools.dart, and CHANGELOG.md. No behavior changes; the enhanced-enum detection and tests are unchanged.

Re-ran the suite after rebasing — dart analyze is clean and the enhanced-enum tests pass:

• enhanced enum with a constructor and fields is an error
• enum with a mixin or interface is an error
• plain enum with a trailing semicolon is not an error
• enhanced enum with a getter is an error and does not crash
• enum with arguments on its values is an error

Ready for review whenever you have a chance.

[theprantadutta]

Gentle bump @tarrinneal — this was rebased onto main (pigeon v27.1.1) on June 17 with all local tests passing, and I believe it's just waiting on triage/CI now. Happy to rebase again if it has drifted in the meantime. Thanks!

[auto-submit]

autosubmit label was removed for flutter/packages/11880, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

• Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

[tarrinneal]

@stuartmorgan-g for 2nd

[theprantadutta]

Thanks for the review @tarrinneal — and for applying the comment trims directly; I kept your commit as-is. On top of that I rebased onto main and bumped to 27.1.2, since 27.1.1 was taken by #11894 landing yesterday (CHANGELOG entries stacked accordingly). Analyzer clean and the enhanced-enum tests pass after the rebase.

[stuartmorgan-g]

LGTM

[auto-submit]

autosubmit label was removed for flutter/packages/11880, because - The status or check suite Mac_x64 ios_build_all_packages master has failed. Please fix the issues identified (or deflake) before re-applying this label.