Skip to content

[video_player_platform_interface] Improve seek performance on Android - #11932

Merged
auto-submit[bot] merged 5 commits into
flutter:mainfrom
sailendrabathi:video_player_platform_interface_seek
Jul 6, 2026
Merged

[video_player_platform_interface] Improve seek performance on Android#11932
auto-submit[bot] merged 5 commits into
flutter:mainfrom
sailendrabathi:video_player_platform_interface_seek

Conversation

@sailendrabathi

@sailendrabathisailendrabathi commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Adds backBufferDurationMs to video_player_platform_interface

This PR has only the platform interface package changes from the main PR: #11810.

Following PR split as per Changing federated plugins

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

gemini-code-assist[bot]
gemini-code-assistBot reviewed Jun 18, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces backBufferDurationMs to VideoPlayerOptions to configure ExoPlayer's back buffer duration on Android, and adds videoPlayerOptions to VideoCreationOptions. Feedback suggests updating the assertion to allow a value of 0 (enabling developers to disable back buffering) and correcting the markdown spacing in the documentation comment for proper bold rendering.

Comment threadpackages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart
Comment threadpackages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart Outdated
@sailendrabathisailendrabathi mentioned this pull request Jun 18, 2026
Merged
11 tasks
@mboetgermboetger added the CICD Run CI/CD label Jun 22, 2026
@sailendrabathi
sailendrabathiforce-pushed the video_player_platform_interface_seek branch from c686c5b to 3360f98CompareJune 23, 2026 08:59
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label Jun 23, 2026
@mboetgermboetger added the CICD Run CI/CD label Jun 23, 2026
mboetger
mboetger previously requested changes Jun 23, 2026
View reviewed changes

@mboetgermboetger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding on for ecosystem review

@stuartmorgan-gstuartmorgan-g added the federated: partial_changes PR that contains changes for only a single package of a federated plugin change label Jun 23, 2026
@sailendrabathi
sailendrabathiforce-pushed the video_player_platform_interface_seek branch from 3360f98 to 7811816CompareJune 26, 2026 18:15
@flutter-dashboardflutter-dashboardBot removed the CICD Run CI/CD label Jun 26, 2026
@sailendrabathi

sailendrabathi commented Jun 26, 2026

Copy link
Copy Markdown
ContributorAuthor

@mboetger, I updated the PR after approval from ecosystem reviewer.

Comment link for reference: #11810 (review)

@sailendrabathi@gemini-code-assist
Apply suggestion from@gemini-code-assist[bot]
d55829f
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
stuartmorgan-g
stuartmorgan-g requested changes Jul 1, 2026
View reviewed changes
Comment threadpackages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart Outdated
Comment threadpackages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart Outdated
Comment threadpackages/video_player/video_player_platform_interface/CHANGELOG.md Outdated
Comment threadpackages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart
final VideoViewType viewType;

/// Additional configuration options for the video player.
final VideoPlayerOptions? videoPlayerOptions;

@stuartmorgan-gstuartmorgan-gJul 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composing the two different options classes seems potentially confusing, but it doesn't look like the API surface ever clearly distinguished these conceptually. Since VideoCreationOptions isn't exposed to app-level clients it's probably not a big deal.

@tarrinneal As part of revisiting the video_player API surface later, it would be good to better distinguish what classes are for what steps of the process (e.g., global vs player-level options, which may have been the original intent here?), and we should also fix the fact that some of these classes are being directly re-exported from the app-facing package, which we should stop doing.

@stuartmorgan-gstuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Jul 6, 2026
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2026
@auto-submit

auto-submitBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/11932, because This PR has not met approval requirements for merging. Changes were requested by {mboetger}, please make the needed changes and resubmit this PR.
The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@stuartmorgan-g
stuartmorgan-g dismissed mboetger’s stale reviewJuly 6, 2026 15:05

Requested change was just to hold for ecosystem review, which has now happened.

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2026
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2026
@auto-submit

auto-submitBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/11932, because - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@flutter-dashboardflutter-dashboardBot removed the CICD Run CI/CD label Jul 6, 2026
@stuartmorgan-gstuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Jul 6, 2026
@auto-submit
auto-submitBot merged commit fc00ceb into flutter:mainJul 6, 2026
89 checks passed
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jul 6, 2026
Merged
pullBot pushed a commit to safarmer/flutter that referenced this pull request Jul 6, 2026
@engine-flutter-autoroll
Roll Packages from 2fbe8734f450 to fc00cebca28e (1 revision) (flutter…
650564a
…#189007)
flutter/packages@2fbe873...fc00ceb
2026-07-06 44525804+sailendrabathi@users.noreply.github.com
[video_player_platform_interface] Improve seek performance on Android
(flutter/packages#11932)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kalyujniy pushed a commit to brickit-app/camera that referenced this pull request Jul 8, 2026
@sailendrabathi@kalyujniy
[video_player_platform_interface] Improve seek performance on Android (…
671575b
…flutter#11932)
Adds `backBufferDurationMs` to `video_player_platform_interface`
This PR has only the platform interface package changes from the main PR: flutter#11810.
Following PR split as per [Changing federated plugins](https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins)
## Pre-Review Checklist
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarrinnealtarrinnealtarrinneal approved these changes
@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@mboetgermboetgerAwaiting requested review from mboetger
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDfederated: partial_changesPR that contains changes for only a single package of a federated plugin changep: video_player

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sailendrabathi@stuartmorgan-g@mboetger@tarrinneal