Skip to content

[material_ui] Remove widgets import in dialog_test.dart, dropdown_menu_test.dart and sliver_app_bar_test.dart - #12002

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:enable_dialog_sliver_dropdown_menu_tests
Jun 26, 2026
Merged

[material_ui] Remove widgets import in dialog_test.dart, dropdown_menu_test.dart and sliver_app_bar_test.dart#12002
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:enable_dialog_sliver_dropdown_menu_tests

Conversation

@QuncCccccc

@QuncCcccccQuncCccccc commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#182636 and flutter/flutter#188395

This PR:

  • Removed the cross-import of widgets/semantics_tester.dart.
  • Removed @Skip tag, all tests in this file has passed. semantics_tester.dart has existed in material_ui, so we can directly import semantics_tester.dart;
  • Moved the file to test/ folder.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label Jun 25, 2026
@github-actionsgithub-actionsBot added triage-framework Should be looked at in framework triage p: material_ui labels Jun 25, 2026
gemini-code-assist[bot]
gemini-code-assistBot reviewed Jun 25, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @Skip annotations from dialog_test.dart, dropdown_menu_test.dart, and sliver_app_bar_test.dart to re-enable these test files. It also updates import paths, reorders imports, and wraps several asynchronous dialog-showing functions in unawaited calls in dialog_test.dart. There are no review comments, so I have no feedback to provide.

@QuncCcccccQuncCccccc mentioned this pull request Jun 25, 2026
Open
@QuncCccccc

QuncCccccc commented Jun 25, 2026

Copy link
Copy Markdown
ContributorAuthor

Used unawaited because of the same reason as #12001 (comment).

@QuncCccccc
QuncCcccccforce-pushed the enable_dialog_sliver_dropdown_menu_tests branch from f4aa3bc to e70deebCompareJune 25, 2026 20:24
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label Jun 25, 2026
@QuncCcccccQuncCccccc added the CICD Run CI/CD label Jun 25, 2026
chunhtai
chunhtai approved these changes Jun 26, 2026
View reviewed changes

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCcccccQuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2026
@auto-submit
auto-submitBot merged commit e19d0fc into flutter:mainJun 26, 2026
88 checks passed
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jun 29, 2026
Merged
Rushikesh1414 pushed a commit to Rushikesh1414/flutter that referenced this pull request Jun 29, 2026
@engine-flutter-autoroll
Roll Packages from c1f7d920c272 to 656ccaae4f49 (12 revisions) (flutt…
359fa32
…er#188728)
flutter/packages@c1f7d92...656ccaa
2026-06-26 21270878+elliette@users.noreply.github.com [material_ui]
Enable `icon_button_test` (flutter/packages#12015)
2026-06-26 21270878+elliette@users.noreply.github.com [material_ui]
Enable `list_tile_test` (flutter/packages#12017)
2026-06-26 21270878+elliette@users.noreply.github.com [material_ui]
Enable `calendar_date_picker_test` (flutter/packages#12006)
2026-06-26 21270878+elliette@users.noreply.github.com [material_ui]
Enable `filter_chip_test` (flutter/packages#12013)
2026-06-26 21270878+elliette@users.noreply.github.com [material_ui]
Enable `ink_well_test` (flutter/packages#12016)
2026-06-26 21270878+elliette@users.noreply.github.com [material_ui]
Enable `radio_list_tile_test` (flutter/packages#12019)
2026-06-26 21270878+elliette@users.noreply.github.com [material_ui]
Enable `tabs_test` (flutter/packages#12021)
2026-06-26 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `bottom_sheet_test.dart`
(flutter/packages#12001)
2026-06-26 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `dialog_test.dart`, `dropdown_menu_test.dart`
and `sliver_app_bar_test.dart` (flutter/packages#12002)
2026-06-26 stuartmorgan@google.com [various] Check in auto-upgrade to
analysis options (flutter/packages#11969)
2026-06-26 73310711+shrabanti722@users.noreply.github.com
[video_player_platform_interface] Add
preventsDisplaySleepDuringVideoPlayback option (flutter/packages#11546)
2026-06-26 nateshmbhat1@gmail.com [video_player_avfoundation] Add video
track selection support (flutter/packages#11476)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtaichunhtaichunhtai approved these changes
@justinmcjustinmcAwaiting requested review from justinmc
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDp: material_uitriage-frameworkShould be looked at in framework triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuncCccccc@chunhtai