Skip to content

[material_ui] Remove widgets/ import in flexible_space_bar_test.dart, app_bar_sliver_test.dart and partial fix in chip_test.dart - #12004

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:enable_flexible_space_app_bar_sliver_tests
Jun 25, 2026
Merged

[material_ui] Remove widgets/ import in flexible_space_bar_test.dart, app_bar_sliver_test.dart and partial fix in chip_test.dart#12004
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:enable_flexible_space_app_bar_sliver_tests

Conversation

@QuncCccccc

@QuncCcccccQuncCccccc commented Jun 25, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#182636 and flutter/flutter#188395

This PR:

  • Removed the cross-import of widgets/semantics_tester.dart.
  • Removed @Skip tag, all tests in this file has passed. semantics_tester.dart has existed in material_ui, so we can directly import semantics_tester.dart;
  • Moved the file to test/ folder.

Note: chip_test.dart only partially remove the widgets/ dependency and still stay in temporarily_disabled_tests folder. Once flutter/flutter#184279 is ported over, this file can be move out of the folder.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label Jun 25, 2026
@github-actionsgithub-actionsBot added triage-framework Should be looked at in framework triage p: material_ui labels Jun 25, 2026
gemini-code-assist[bot]
gemini-code-assistBot reviewed Jun 25, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @Skip annotations from app_bar_sliver_test.dart and flexible_space_bar_test.dart, updates the import path for semantics_tester.dart, and reorders the imports in both files. Additionally, the Navigator.push call in app_bar_sliver_test.dart is wrapped with unawaited. There are no review comments, and I have no feedback to provide.

@QuncCcccccQuncCccccc mentioned this pull request Jun 25, 2026
Open
@QuncCccccc
QuncCcccccforce-pushed the enable_flexible_space_app_bar_sliver_tests branch from 8b51276 to e111db9CompareJune 25, 2026 20:49
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label Jun 25, 2026
@QuncCcccccQuncCccccc changed the title [material_ui] Remove widgets/ import in flexible_space_bar_test.dart and app_bar_sliver_test.dart[material_ui] Remove widgets/ import in flexible_space_bar_test.dart, app_bar_sliver_test.dart and partial fix in chip_test.dartJun 25, 2026
@QuncCcccccQuncCccccc added the CICD Run CI/CD label Jun 25, 2026
@QuncCcccccQuncCccccc changed the title [material_ui] Remove widgets/ import in flexible_space_bar_test.dart, app_bar_sliver_test.dart and partial fix in chip_test.dart[material_ui] Remove widgets/ import in flexible_space_bar_test.dart, app_bar_sliver_test.dart and partial fix in chip_test.dartJun 25, 2026
Piinks
Piinks reviewed Jun 25, 2026
View reviewed changes
Comment threadpackages/material_ui/temporarily_disabled_tests/chip_test.dart
import 'package:flutter_test/flutter_test.dart';

import '../widgets/feedback_tester.dart';
import '../widgets/semantics_tester.dart';

@PiinksPiinksJun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this move out of the temp disabled directory?

@QuncCcccccQuncCcccccJun 25, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we still need to port the feedback_tester change flutter/flutter#184279. After that, this test can be enabled.

@PiinksPiinksJun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha!

Piinks
Piinks approved these changes Jun 25, 2026
View reviewed changes

@PiinksPiinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PiinksPiinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2026
@auto-submit
auto-submitBot merged commit 6ca02e8 into flutter:mainJun 25, 2026
89 checks passed
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jun 26, 2026
Merged
pullBot pushed a commit to Mattlk13/flutter that referenced this pull request Jun 26, 2026
@engine-flutter-autoroll
Roll Packages from 7ff3e1fac80d to c1f7d920c272 (13 revisions) (flutt…
f1a28aa
…er#188634)
flutter/packages@7ff3e1f...c1f7d92
2026-06-25 21270878+elliette@users.noreply.github.com [material_ui]
Enable `bottom_navigation_bar_test` (flutter/packages#12005)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove `widgets/` import in `flexible_space_bar_test.dart`,
`app_bar_sliver_test.dart` and partial fix in `chip_test.dart`
(flutter/packages#12004)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `animated_icon_test.dart` and
`autocomplete_test.dart` (flutter/packages#12000)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `app_bar_test.dart` (flutter/packages#11998)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `search_anchor_test.dart`
(flutter/packages#11997)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `menu_anchor_test.dart`
(flutter/packages#11995)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `scaffold_test.dart` (flutter/packages#11973)
2026-06-25 stuartmorgan@google.com [google_maps_flutter] Fix iOS &/&&
logic (flutter/packages#11994)
2026-06-25 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
e1fd963 to ad70ec4 (5 revisions) (flutter/packages#11985)
2026-06-25 katelovett@google.com [CI] Fix labeler for cupertino_ui PRs
(flutter/packages#11988)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `slider_test.dart` (flutter/packages#11977)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `drawer_test.dart` (flutter/packages#11976)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `navigation_rail_test.dart`
(flutter/packages#11974)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
andywolff pushed a commit to andywolff/flutter that referenced this pull request Jun 26, 2026
@engine-flutter-autoroll@andywolff
Roll Packages from 7ff3e1fac80d to c1f7d920c272 (13 revisions) (flutt…
8b542cd
…er#188634)
flutter/packages@7ff3e1f...c1f7d92
2026-06-25 21270878+elliette@users.noreply.github.com [material_ui]
Enable `bottom_navigation_bar_test` (flutter/packages#12005)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove `widgets/` import in `flexible_space_bar_test.dart`,
`app_bar_sliver_test.dart` and partial fix in `chip_test.dart`
(flutter/packages#12004)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `animated_icon_test.dart` and
`autocomplete_test.dart` (flutter/packages#12000)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `app_bar_test.dart` (flutter/packages#11998)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `search_anchor_test.dart`
(flutter/packages#11997)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `menu_anchor_test.dart`
(flutter/packages#11995)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `scaffold_test.dart` (flutter/packages#11973)
2026-06-25 stuartmorgan@google.com [google_maps_flutter] Fix iOS &/&&
logic (flutter/packages#11994)
2026-06-25 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
e1fd963 to ad70ec4 (5 revisions) (flutter/packages#11985)
2026-06-25 katelovett@google.com [CI] Fix labeler for cupertino_ui PRs
(flutter/packages#11988)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `slider_test.dart` (flutter/packages#11977)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `drawer_test.dart` (flutter/packages#11976)
2026-06-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `navigation_rail_test.dart`
(flutter/packages#11974)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PiinksPiinksPiinks approved these changes
@justinmcjustinmcAwaiting requested review from justinmc
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDp: material_uitriage-frameworkShould be looked at in framework triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuncCccccc@Piinks