Skip to content

[camera_web] Remove invalid @JS annotation on extension type constructors - #12384

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
mdebbar:fix-camera-web-js-interop-annotation
Aug 6, 2026
Merged

[camera_web] Remove invalid @JS annotation on extension type constructors#12384
auto-submit[bot] merged 2 commits into
flutter:mainfrom
mdebbar:fix-camera-web-js-interop-annotation

Conversation

@mdebbar

Copy link
Copy Markdown
Contributor

Removes invalid @JS() annotations from extension type constructors in packages/camera/camera_web.

Fixesflutter/flutter#190355

Description

In newer Dart SDKs (following Dart SDK commit dart-lang/sdk@cecd7ec rolled into Flutter in PR flutter/flutter#190158), placing @JS() annotations on extension type constructors has no effect and is now flagged as an error (invalid_js_annotation).

Removing these annotations resolves the error without altering runtime behavior.

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @JS annotations from the external factories of WebTweakMediaSettingsRange and WebTweakMediaTrackConstraints in pkg_web_tweaks.dart. There are no review comments, and I have no feedback to provide.

@mdebbar

Copy link
Copy Markdown
ContributorAuthor

Not sure what's wrong with GitHub Actions Scan. Any idea @stuartmorgan-g ?

@stuartmorgan-g

stuartmorgan-g commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

No clue I'm afraid; I don't know anything about the infrastructure for the new zizmor scans.

(I triggered a re-run to see if that helps, since it looked like some internal server issue.)

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbarmdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2026
@mdebbar

Copy link
Copy Markdown
ContributorAuthor

Github is having issues (https://www.githubstatus.com/)
image

@auto-submit
auto-submitBot merged commit 142990b into flutter:mainAug 6, 2026
17 of 18 checks passed
Subhanshu20135 pushed a commit to The-Developer-Diaries/flutter that referenced this pull request Aug 7, 2026
…r#190719)
flutter/packages@4e3f83d...fc22143
2026-08-07 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
058e0af to 6b182d2 (4 revisions) (flutter/packages#12394)
2026-08-07 269567208+reidbaker-agent@users.noreply.github.com
[camera_android_camerax][tool] Migrate complexity checks to
package:cognitive_complexity (flutter/packages#12356)
2026-08-06 mdebbar@google.com [camera_web] Remove invalid @js annotation
on extension type constructors (flutter/packages#12384)
2026-08-06 tarrinneal@gmail.com [pigeon] add support for analyzer 13 and
14 (flutter/packages#12358)
2026-08-06 katelovett@google.com [cupertino_ui, material_ui] Fix bad doc
references (flutter/packages#12381)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDp: cameraplatform-web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Packages roller blocked on JS interop errors

2 participants

@mdebbar@stuartmorgan-g