Skip to content

Inline error ignores in analysis_options - #12430

Merged
auto-submit[bot] merged 2 commits into
mainfrom
inline_error_ignores_analysis_options
Aug 11, 2026
Merged

Inline error ignores in analysis_options#12430
auto-submit[bot] merged 2 commits into
mainfrom
inline_error_ignores_analysis_options

Conversation

@sigurdm

Copy link
Copy Markdown
Contributor

This should help pana score for material_ui and cupertino_ui.

@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label Aug 11, 2026
@github-actionsgithub-actionsBot added triage-framework Should be looked at in framework triage p: cupertino_ui p: material_ui labels Aug 11, 2026

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the analysis_options.yaml files in both packages/cupertino_ui and packages/material_ui to ignore specific analyzer errors, including deprecated_member_use, deprecated_member_use_from_same_package, and doc_directive_unknown. There are no review comments, and I have no feedback to provide.

@sigurdm
sigurdm requested a review from PiinksAugust 11, 2026 13:56

@PiinksPiinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you very much!

@sigurdm

Copy link
Copy Markdown
ContributorAuthor

Oh - you also need to inline the formatter options

@sigurdm
sigurdm requested a review from PiinksAugust 11, 2026 14:50

@PiinksPiinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PiinksPiinks added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes autosubmit Merge PR when tree becomes green via auto submit App labels Aug 11, 2026
@auto-submit
auto-submitBot merged commit 3c2b1d8 into mainAug 11, 2026
13 checks passed
@auto-submit
auto-submitBot deleted the inline_error_ignores_analysis_options branch August 11, 2026 15:55
pullBot pushed a commit to Klomgor/flutter that referenced this pull request Aug 12, 2026
…r#191008)
flutter/packages@aaaf246...94485f1
2026-08-12 22373191+Hari-07@users.noreply.github.com
[in_app_purchase_storekit] Group purchases into a single event in
storekit2 (flutter/packages#12237)
2026-08-12 fluttergithubbot@gmail.com Sync release-material_ui-0.0.3+1
to main (flutter/packages#12439)
2026-08-11 katelovett@google.com [CI] Update deps script
(flutter/packages#12427)
2026-08-11 fluttergithubbot@gmail.com Sync release-go_router-17.5.0 to
main (flutter/packages#12417)
2026-08-11 piyushanand.1221@gmail.com [webview_flutter_android] Set
support for web authentication (flutter/packages#11681)
2026-08-11 nateshmbhat1@gmail.com [video_player] : Add video track
selection support for Android and iOS (flutter/packages#10688)
2026-08-11 sigurdm@google.com Inline error ignores in analysis_options
(flutter/packages#12430)
2026-08-11 fluttergithubbot@gmail.com Sync release-cupertino_ui-0.0.3+1
to main (flutter/packages#12426)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDoverride: no changelog neededOverride the check requiring CHANGELOG updates for most changesoverride: no versioning neededOverride the check requiring version bumps for most changesp: cupertino_uip: material_uitriage-frameworkShould be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sigurdm@Piinks