[google_fonts] support material ui by Segatti · Pull Request #12489 · flutter/packages

Segatti · 2026-08-17T21:09:21Z

Added Material UI support to Google Fonts.

List which issues are fixed by this PR. You must list at least one issue.
Fixesflutter/flutter#191067

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩²

gemini-code-assist

Code Review

This pull request replaces standard Flutter SDK imports (package:flutter/material.dart and package:flutter/cupertino.dart) with external third-party packages (package:material_ui/material_ui.dart and package:cupertino_ui/cupertino_ui.dart) and adds them as dependencies in pubspec.yaml. The reviewer flags these changes as critical security and correctness issues, noting that replacing built-in Flutter SDK libraries with external packages introduces supply chain risks and breaks compatibility, and recommends reverting back to the standard Flutter SDK libraries.

gemini-code-assist · 2026-08-17T21:10:27Z

+ cupertino_ui: ^1.0.0
 flutter:
 sdk: flutter
 http: ^1.0.0
+ material_ui: ^1.0.0


Replacing the standard Flutter SDK dependencies with external third-party packages like cupertino_ui and material_ui is a critical security and correctness issue. Flutter's Material and Cupertino libraries are built directly into the Flutter SDK. Using external packages instead of the official SDK libraries introduces severe security risks (such as supply chain attacks or typosquatting) and breaks compatibility.
flutter: sdk: flutterhttp: ^1.0.0

gemini-code-assist · 2026-08-17T21:10:27Z

 import'package:crypto/crypto.dart';
 import'package:flutter/foundation.dart'show kIsWeb;
-import'package:flutter/material.dart';
+import'package:material_ui/material_ui.dart';


Do not import material_ui from an external package. Use the standard Flutter SDK Material library instead.
Suggested change
import'package:material_ui/material_ui.dart';
import'package:flutter/material.dart';

gemini-code-assist · 2026-08-17T21:10:27Z

+import 'package:cupertino_ui/cupertino_ui.dart';
+import 'package:material_ui/material_ui.dart';


Do not import cupertino_ui or material_ui from external packages. Use the standard Flutter SDK Cupertino and Material libraries instead.
Suggested change
import'package:cupertino_ui/cupertino_ui.dart';
import'package:material_ui/material_ui.dart';
import'package:flutter/cupertino.dart';
import'package:flutter/material.dart';

stuartmorgan-g · 2026-08-18T18:41:32Z

Thanks for the contribution! You haven’t completed all of the items in the PR checklist above, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.

gemini-code-assist

Code Review

This pull request replaces the standard Flutter SDK imports and dependencies (package:flutter/material.dart and package:flutter/cupertino.dart) with external packages (material_ui and cupertino_ui) across the google_fonts package and its examples. Feedback from the reviewer highlights that these changes introduce critical compatibility issues, as google_fonts must rely on the official Flutter SDK's material and cupertino libraries to ensure type safety and compatibility with standard Flutter applications.

gemini-code-assist · 2026-08-18T22:35:43Z

 path_provider: ^2.0.0

 dev_dependencies:
+ cupertino_ui: ^1.0.0


Adding cupertino_ui as a dependency and replacing the standard package:flutter/cupertino.dart imports is incorrect. The package must use the official Flutter SDK's Cupertino library to maintain compatibility and type safety with standard Flutter applications.

Piinks

Hey @Segatti thanks for putting this together. It looks like some checks are failing, can you take a look?

Segatti · 2026-08-19T21:50:04Z

Hi @Piinks , do you mean the conflict between the Google Fonts versions, or the errors in other libraries (Google Maps, for example) that I didn’t modify?

Piinks · 2026-08-19T21:52:15Z

The dashboard checks here. They are in the middle of a fresh run right now.

Segatti · 2026-08-20T15:25:30Z

@Piinks Hi, why are the other checks still pending?

Piinks · 2026-08-20T19:33:09Z

Because they are waiting for a security check before running. :)

juampiq6 · 2026-08-24T13:12:26Z

Will this new code require for every user to migrate their apps to use and import material ui and cupertino ui?
We should mark this as BREAKING CHANGE and maybe a link to the dart migration tool?

Piinks · 2026-08-24T16:15:50Z

@juampiq6 this is still under review. We have already advised that packages migrating to material_ui and/or cupertino_ui should consider it a breaking change.

Piinks · 2026-08-24T16:17:00Z

+## 8.2.2
+
+- Adds support for the `material_ui` package so `TextStyle` and `TextTheme` types are compatible with Material Design widgets that use `material_ui`.
+- Updates minimum supported SDK version to Flutter 3.44/Dart 3.12.


Suggested change
## 8.2.2
-Adds support for the `material_ui` package so `TextStyle` and `TextTheme` types are compatible with Material Design widgets that use `material_ui`.
- Updates minimum supported SDK version to Flutter 3.44/Dart 3.12.
## 9.0.0
-Migrates to the `material_ui` package, not backwards compatible with package:flutter/material.dart.
- Updates minimum supported SDK version to Flutter 3.44/Dart 3.12.

Actually, instead of 9.0.0, let's mark this "Next". There is another PR out that introduces another breaking change. Rather than release 2 major versions, we'll aim to batch these changes together for one 9.0.0 release.
Let's make this "Next", and in pubspec.yaml, set publish_to: none.

Piinks · 2026-08-24T16:17:32Z

 repository: https://github.com/flutter/packages/tree/main/packages/google_fonts
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+google_fonts%22
-version: 8.2.1
+version: 8.2.2


Update to 9.0.0

Piinks · 2026-08-24T16:23:36Z

+## 8.2.2
+
+- Adds support for the `material_ui` package so `TextStyle` and `TextTheme` types are compatible with Material Design widgets that use `material_ui`.
+- Updates minimum supported SDK version to Flutter 3.44/Dart 3.12.


Actually, instead of 9.0.0, let's mark this "Next". There is another PR out that introduces another breaking change. Rather than release 2 major versions, we'll aim to batch these changes together for one 9.0.0 release.
Let's make this "Next", and in pubspec.yaml, set publish_to: none.

Piinks · 2026-08-24T16:26:20Z


 import 'dart:ui' as ui;
-import 'package:flutter/material.dart';
+import 'package:material_ui/material_ui.dart';


Did you run the generator for this? Or was this import updated manually/by dart fix? See comment at the top of the file.

I used this: dart fix --apply --code=migrate_design_widgets

feat: support material ui
df30db7

gemini-code-assistBot reviewed Aug 17, 2026
View reviewed changes

github-actionsBot added p: google_fonts triage-framework Should be looked at in framework triage labels Aug 17, 2026

stuartmorgan-g marked this pull request as draft August 18, 2026 18:41

stuartmorgan-g requested a review from Piinks August 18, 2026 18:41

fix: docs
ae9ceb3

Segatti marked this pull request as ready for review August 18, 2026 22:34

gemini-code-assistBot reviewed Aug 18, 2026
View reviewed changes

Piinks added the CICD Run CI/CD label Aug 19, 2026

Piinks reviewed Aug 19, 2026
View reviewed changes

Merge branch 'flutter:main' into main
50d3c4a

flutter-dashboardBot removed the CICD Run CI/CD label Aug 19, 2026

Piinks added the CICD Run CI/CD label Aug 19, 2026

github-actionsBot added triage-design Should be looked at in design triage and removed triage-framework Should be looked at in framework triage labels Aug 19, 2026

fix: min flutter version
d7c157b

flutter-dashboardBot removed the CICD Run CI/CD label Aug 20, 2026

vareversat mentioned this pull request Aug 20, 2026
chore(deps): update flutter to v3.47.0 vareversat/chabo-app#401
Open
1 task

Piinks added the CICD Run CI/CD label Aug 20, 2026

Piinks reviewed Aug 24, 2026
View reviewed changes

Piinks mentioned this pull request Aug 24, 2026
[google_fonts] Add google_fonts_lite file to allow tree-shaking of the other huge files #11433
Open

Piinks reviewed Aug 24, 2026
View reviewed changes

	import'package:material_ui/material_ui.dart';
	import'package:flutter/material.dart';

		import 'package:cupertino_ui/cupertino_ui.dart';
		import 'package:material_ui/material_ui.dart';

Uh oh!

Conversation

Segatti commented Aug 17, 2026• edited by dkwingsmt Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assistBot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assistBotAug 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assistBotAug 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assistBotAug 17, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Aug 18, 2026

Uh oh!

gemini-code-assistBot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assistBotAug 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Segatti commented Aug 19, 2026

Uh oh!

Piinks commented Aug 19, 2026

Uh oh!

Segatti commented Aug 20, 2026

Uh oh!

Piinks commented Aug 20, 2026

Uh oh!

juampiq6 commented Aug 24, 2026

Uh oh!

Piinks commented Aug 24, 2026

Uh oh!

PiinksAug 24, 2026

Choose a reason for hiding this comment

Uh oh!

PiinksAug 24, 2026

Choose a reason for hiding this comment

Uh oh!

PiinksAug 24, 2026

Choose a reason for hiding this comment

Uh oh!

PiinksAug 24, 2026

Choose a reason for hiding this comment

Uh oh!

PiinksAug 24, 2026

Choose a reason for hiding this comment

Uh oh!

SegattiAug 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Segatti commented Aug 17, 2026•
edited by dkwingsmt
Loading