Skip to content

[dynamic_layouts] Clean up remaining TODOs - #2639

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
Piinks:finishDynamic
Oct 20, 2022
Merged

[dynamic_layouts] Clean up remaining TODOs#2639
auto-submit[bot] merged 2 commits into
flutter:mainfrom
Piinks:finishDynamic

Conversation

@Piinks

@PiinksPiinks commented Sep 22, 2022

Copy link
Copy Markdown
Contributor

This cleans up the remaining TODOs in the dynamic_layouts package.

Filed flutter/flutter#112234 for follow up on the remaining garbage collection issue.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actionsgithub-actionsBot added the p: dynamic_layouts The dynamic_layouts package label Sep 22, 2022
goderbauer
goderbauer approved these changes Sep 23, 2022
View reviewed changes

@goderbauergoderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadpackages/dynamic_layouts/lib/src/dynamic_grid.dart Outdated
Comment threadpackages/dynamic_layouts/lib/src/render_dynamic_grid.dart Outdated
@stuartmorgan-g

stuartmorgan-g commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

Is this ready to land?

@Piinks

Piinks commented Oct 13, 2022

Copy link
Copy Markdown
ContributorAuthor

Sorry, no. I have a few nits to clean up. Updating now. :)

Piinks
Piinks commented Oct 20, 2022
View reviewed changes
Comment threadpackages/dynamic_layouts/lib/src/base_grid_layout.dart
Piinks
Piinks commented Oct 20, 2022
View reviewed changes
Comment threadpackages/dynamic_layouts/lib/src/base_grid_layout.dart
Piinks
Piinks commented Oct 20, 2022
View reviewed changes
Comment threadpackages/dynamic_layouts/lib/src/dynamic_grid.dart Outdated
Piinks
Piinks commented Oct 20, 2022
View reviewed changes
Comment threadpackages/dynamic_layouts/lib/src/render_dynamic_grid.dart Outdated
@PiinksPiinks added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 20, 2022
@auto-submit
auto-submitBot merged commit 9eec757 into flutter:mainOct 20, 2022
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@Piinks
[dynamic_layouts] Clean up remaining TODOs (flutter#2639)
ed681fd
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@Piinks
[dynamic_layouts] Clean up remaining TODOs (flutter#2639)
8b2737e
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauergoderbauergoderbauer approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: dynamic_layoutsThe dynamic_layouts package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piinks@stuartmorgan-g@goderbauer