[go_router] Add support for Iterable, List and Set to TypedGoRoute

[Skogsfrae]

Add support for Iterable, List and Set to TypedGoRoute

Changed signature of GoRouteData.$location for PR #2679
Resolves Issue #108437

Pre-launch Checklist

• I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• I read the [Tree Hygiene] wiki page, which explains my responsibilities.
• I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
• I signed the [CLA].
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I listed at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
• I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is [test-exempt].
• All existing and new tests are passing.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[stuartmorgan-g]

@chunhtai From triage: ping on this review.

[chunhtai]

Updates: this one is waiting on #2679

[chunhtai]

LGTM

[chunhtai]

Hi @Skogsfrae looks like there are ci failures and merge conflict. can you rebase off the latest main and fix the ci?

[Skogsfrae]

Hi @chunhtai I finally managed to make the ci work. I temporarily modified the analysis_options.yaml to skip go_router_builder example app .g.dart files. I'll restore it in the go_router_builder pr after this gets merged

[stuartmorgan-g]

We should not be turning off analysis for an entire directory. What problem is this intended to solve?

[Skogsfrae]

@stuartmorgan This pr changes the signature of a go_router method used in .g.dart generated files and causing problems in cyrrus ci analysis step when running the analyser for go_router_builder/example app.

Talking about that on discord, @chunhtai told me to temporarily disable the analysis for that example app so this pr can be merged and then reenable it in #2679
I first tried to disable the analysis only on those specific files, but then I faced another problem for updating a file of a library without increasing its version, so I had to revert it.

This are the cyrrus ci logs:
https://cirrus-ci.com/task/4546239256592384
https://cirrus-ci.com/task/6292642485501952

Running command: "dart analyze --fatal-infos" in /tmp/cirrus-ci-build/packages/go_router_builder
Analyzing go_router_builder...
info - example/lib/all_types.g.dart:205:61 - Unnecessary null checks. - unnecessary_null_checks
info - example/lib/all_types.g.dart:226:60 - Unnecessary null checks. - unnecessary_null_checks
info - example/lib/all_types.g.dart:244:63 - Unnecessary null checks. - unnecessary_null_checks
info - example/lib/main.g.dart:122:54 - Unnecessary null checks. - unnecessary_null_checks
4 issues found.

if [[ $CIRRUS_PR == "" ]]; then
./script/tool_runner.sh version-check --ignore-platform-interface-breaks
else
./script/tool_runner.sh version-check --check-for-missing-changes --pr-labels="$CIRRUS_PR_LABELS"
fi
Running for all packages that have diffs relative to "fdf708371f2e33f44189ebc43d896679b7ebf463"
Changed packages: go_router,go_router_builder
�[36m[0:00] Running for go_router...�[0m
5.2.0 -> 5.2.1
�[36m[0:00] Running for go_router_builder...�[0m
No version change.
�[31mNo CHANGELOG change found. If this PR needs an exemption from the standard policy of listing all changes in the CHANGELOG, comment in the PR to explain why the PR is exempt, and add (or ask your reviewer to add) the "override: no changelog needed" label. Otherwise, please add a NEXT entry in the CHANGELOG as described in the contributing guide.�[0m
�[31mThe following packages had errors:�[0m
�[31m go_router_builder:
Missing CHANGELOG change�[0m
�[31mSee above for full details.�[0m

[stuartmorgan-g]

then I faced another problem for updating a file of a library without increasing its version, so I had to revert it.

The second failure you linked to is only for not having a CHANGELOG entry, not lack of version update, and as the error message says that's trivially overridable when it makes sense to do so (as in this case). Local ignores and an override for the changelog would be much better than changing the root analysis configuration to opt everything out.

[Skogsfrae]

Sorry for that, I genuinely thought it was a versioning problem.
I fixed the pr, can you add the override: no changelog needed label? I can't do it

[Skogsfrae]

If someone can please add the override: no changelog needed I'll update the pr to solve the conflicts and the CI could run without the previous changelog problem

[stuartmorgan-g]

Overriding for go_router_builder; ignores are dev-only changes.

[Skogsfrae]

@chunhtai this is ready to be merged

[stuartmorgan-g]

@johnpryan Who should do the second review on this?

[stuartmorgan-g]

@chunhtai It looks like you reviewed this before, could you re-review as the second reviewer?

[chunhtai]

LGTM

[chunhtai]

@Skogsfrae can you rebase off latest main?

[Skogsfrae]

@chunhtai I rebased both this pr and the one on go_router_builder

[Skogsfrae]

@chunhtai I just rebased it again with the last release. Is there something else that needs to be done to merge this PR?

[Skogsfrae]

@chunhtai@stuartmorgan@johnpryan can this PR be merged so I can update the linked one and hopefully have that merged too?
I'm keeping this updated with upstream and I'd really like to be able to use this feature with go_router_builder

Thank you guys 🙏🏼

[stuartmorgan-g]

Based on the last comments from reviewers it looks like this is ready to land and just didn't get the label.