[video_player] Passing http headers to file constructor

[abdelaziz-mahdy]

Recreating PR from flutter/plugins flutter-team-archive/plugins#6213

when passing m3u8 file to videoplayer as videoplayercontroller.file links insided m3u8 file has to be used with http headers

so i passed it in the videoplayercontroller.file and changed all things related to it

issue flutter/flutter#119467

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I listed at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[camsim99]

Giving this a LGTM from my review of flutter-team-archive/plugins#6213 (which I actually never marked...oops). Looks like you need to bump the plugin version, though.

[abdelaziz-mahdy]

@camsim99 done

[abdelaziz-mahdy]

@tarrinneal done

[tarrinneal]

this all looks good to me, thanks for putting this together!

[stuartmorgan-g]

Looks good overall, just some small comments.

[abdelaziz-mahdy]

Looks good overall, just some small comments.

All of the review comments should be done now.

[abdelaziz-mahdy]

I did the changes,

but not sure if i understood both correctly can you check one more time?

[stuartmorgan-g]

LGTM!

[stuartmorgan-g]

We forgot to trigger an integration test run; looks like this broke those tests.

[abdelaziz-mahdy]

We forgot to trigger an integration test run; looks like this broke those tests.

I am sorry for not understanding,

But should I change something, or is it not related to me ?

[stuartmorgan-g]

This PR failed our postsubmit tests, so it will be reverted shortly. You'll need to submit a new PR once we do that undoes the revert but also fixes the broken tests.

Did the drive-examples repo tooling command pass for you locally?

[stuartmorgan-g]

Now that I'm at my work machine: the error is:

03-08 17:14:01.481: I/flutter(21632): The following PlatformException was thrown running a test:
03-08 17:14:01.481: I/flutter(21632): PlatformException(NullPointerException, java.lang.NullPointerException: Attempt to invoke interface
03-08 17:14:01.481: I/flutter(21632): method 'boolean java.util.Map.isEmpty()' on a null object reference, Cause: null, Stacktrace:
03-08 17:14:01.481: I/flutter(21632): java.lang.NullPointerException: Attempt to invoke interface method 'boolean java.util.Map.isEmpty()'
03-08 17:14:01.481: I/flutter(21632): on a null object reference
03-08 17:14:01.481: I/flutter(21632): at io.flutter.plugins.videoplayer.VideoPlayer.buildHttpDataSourceFactory(VideoPlayer.java:113)
03-08 17:14:01.481: I/flutter(21632): at io.flutter.plugins.videoplayer.VideoPlayer.<init>(VideoPlayer.java:82)
03-08 17:14:01.482: I/flutter(21632): at io.flutter.plugins.videoplayer.VideoPlayerPlugin.create(VideoPlayerPlugin.java:136)
03-08 17:14:01.482: I/flutter(21632): at
03-08 17:14:01.482: I/flutter(21632): io.flutter.plugins.videoplayer.Messages$AndroidVideoPlayerApi$-CC.lambda$setup$1(Messages.java:693)
03-08 17:14:01.482: I/flutter(21632): at
03-08 17:14:01.482: I/flutter(21632): io.flutter.plugins.videoplayer.Messages$AndroidVideoPlayerApi$$ExternalSyntheticLambda2.onMessage(Unknown
03-08 17:14:01.482: I/flutter(21632): Source:2)
03-08 17:14:01.482: I/flutter(21632): at
03-08 17:14:01.482: I/flutter(21632): io.flutter.plugin.common.BasicMessageChannel$IncomingMessageHandler.onMessage(BasicMessageChannel.java:217)
03-08 17:14:01.482: I/flutter(21632): at io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)
03-08 17:14:01.482: I/flutter(21632): at
03-08 17:14:01.482: I/flutter(21632): io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$DartMessenger(DartMessenger.java:322)
03-08 17:14:01.482: I/flutter(21632): at io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)
03-08 17:14:01.482: I/flutter(21632): at android.os.Handler.handleCallback(Handler.java:938)
03-08 17:14:01.482: I/flutter(21632): at android.os.Handler.dispatchMessage(Handler.java:99)
03-08 17:14:01.482: I/flutter(21632): at android.os.Looper.loop(Looper.java:223)
03-08 17:14:01.482: I/flutter(21632): at android.app.ActivityThread.main(ActivityThread.java:7664)
03-08 17:14:01.482: I/flutter(21632): at java.lang.reflect.Method.invoke(Native Method)
03-08 17:14:01.482: I/flutter(21632): at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
03-08 17:14:01.482: I/flutter(21632): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
03-08 17:14:01.483: I/flutter(21632): , null)

It looks like something is violating the @NonNull annotation.

[stuartmorgan-g]

In particular,
https://github.com/zezo357/packages/blob/3ed1bfa7fe2e844dc9b6577fbd7f3fc7f4921897/packages/video_player/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java#L140
is wrong. That should be fixed to pass an empty collection; that may be all we need here.

[stuartmorgan-g]

#3425 passed tests, so it looks like that's all it was. @zezo357 No need to submit another PR.

[abdelaziz-mahdy]

#3425 passed tests, so it looks like that's all it was. @zezo357 No need to submit another PR.

Thank you very much.