Skip to content

[flutter_migrate] Skip slow tests - #3270

Merged
stuartmorgan-g merged 1 commit into
flutter:mainfrom
stuartmorgan-g:migrate-disable-slow-tests
Feb 23, 2023
Merged

[flutter_migrate] Skip slow tests#3270
stuartmorgan-g merged 1 commit into
flutter:mainfrom
stuartmorgan-g:migrate-disable-slow-tests

Conversation

@stuartmorgan-g

@stuartmorgan-gstuartmorgan-g commented Feb 22, 2023

Copy link
Copy Markdown
Collaborator

Currently flutter_migrate unit tests take 10 minutes to run, which is 1/6 of our total time allowance for a Cirrus test run, and 1-2 orders of magnitude slower than all of our other unit tests.

This skips the slow tests, with references to a tracking issue. At some point when there are more eng resources on flutter_migrate someone can revisit these tests to speed them up and/or make them another type of test (such as a custom run_tests test).

Part of flutter/flutter#121257

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
[flutter_migrate] Skip slow tests
d23b9f2
Currently `flutter_migrate` unit tests take 10 minutes to run, which is
1/6 of our total time allowance for a Cirrus test run, and 1-2 orders of
magnitude slower than all of our other unit tests.
This skips the slow tests, with references to a tracking issue. At some
point when there are more eng resources on `flutter_migrate` someone can
revisit these tests to speed them up and/or make them another type of
test (such as a custom `run_tests` test).
Part of flutter/flutter#121257
bparrishMines
bparrishMines approved these changes Feb 23, 2023
View reviewed changes

@bparrishMinesbparrishMines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 23, 2023
@stuartmorgan-g

stuartmorgan-g commented Feb 23, 2023

Copy link
Copy Markdown
CollaboratorAuthor

submit-queue is stale; the tree is actually green. Landing manually.

@stuartmorgan-g
stuartmorgan-g merged commit 13ee644 into flutter:mainFeb 23, 2023
ditman added a commit to ditman/flutter-flutter that referenced this pull request Feb 24, 2023
@ditman
Roll Packages from6c04c74toad48ee5(28 revisions)
e3abb78
* ad48ee5 [go_router] Fix some broken links in doc (flutter/packages#3288)
* 58ac45e [go_router_builder] Add support for Iterable, List and Set to TypedGoRoute (flutter/packages#2679)
* 0edae25 Export super types in route_data.dart library (flutter/packages#3286)
* 8ad3fde [go_router] Add `GoRouter.maybeOf` (flutter/packages#3216)
* 13ee644 [flutter_migrate] Skip slow tests (flutter/packages#3270)
* 3cc754a Update .gitignore with missing values from flutter/plugins (flutter/packages#3265)
* c0f0a22 [ci] Re-enable pathified unit tests (flutter/packages#3268)
* 5834b4c [go_router]: implemented helpers for ShellRoute (flutter/packages#2730)
* af5906b [extension_gsi] Update extension to support gsi 5 and 6. (flutter/packages#3235)
* 195f4e8 Merge in plugin README and CONTRIBUTING (flutter/packages#3252)
* fab47af [go_router] Disable logging in tests (flutter/packages#3263)
* 25f0f70 [various] Update flutter/plugins links (flutter/packages#3256)
* 2e16733 Merge flutter/plugins (flutter/packages#3233)
* 324a7f2 Exclude more tests on Windows
* 334b58e Adjust test configs
* 69e6dac [go_router_builder] Generate replace method in RouteExtension (flutter/packages#2838)
* 193e454 Merge repository metadata
* 18715d7 Merge remote-tracking branch 'plugins-packages/main' into merge-flutter-plugins
* f2d802d Roll Flutter from ae8d051 to 7175de4 (4 revisions) (flutter/packages#3232)
* 6f1b1e8 Roll Flutter from 33e4d21 to ae8d051 (6 revisions) (flutter/packages#3229)
* a162a98 Roll Flutter from 0be7c3f to 33e4d21 (5 revisions) (flutter/packages#3227)
* ab5a8c0 [tool] Allow importing packages with NEXT (flutter/packages#3215)
* ce9c61b Roll Flutter from 170539f to 0be7c3f (38 revisions) (flutter/packages#3225)
* 9747469 Fix deprecation message for GoRouterState.namedLocation (flutter/packages#3092)
* 6e4431f [go_router] Bump example `compileSdkVersion` and `package_info_plus` dependency version (flutter/packages#3219)
* 925bea8 [pigeon] Validate generated files in CI (flutter/packages#3224)
* 3094867 Move iOS Swift unit tests back to Cirrus (flutter/packages#3221)
* 763d025 [pigeon] Eliminate some of the test pigeons (flutter/packages#3213)
@ditmanditman mentioned this pull request Feb 24, 2023
Merged
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@stuartmorgan-g@nploi
[flutter_migrate] Skip slow tests (flutter#3270)
96d4b8b
Currently `flutter_migrate` unit tests take 10 minutes to run, which is
1/6 of our total time allowance for a Cirrus test run, and 1-2 orders of
magnitude slower than all of our other unit tests.
This skips the slow tests, with references to a tracking issue. At some
point when there are more eng resources on `flutter_migrate` someone can
revisit these tests to speed them up and/or make them another type of
test (such as a custom `run_tests` test).
Part of flutter/flutter#121257
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@stuartmorgan-g
[flutter_migrate] Skip slow tests (flutter#3270)
127ca80
Currently `flutter_migrate` unit tests take 10 minutes to run, which is
1/6 of our total time allowance for a Cirrus test run, and 1-2 orders of
magnitude slower than all of our other unit tests.
This skips the slow tests, with references to a tracking issue. At some
point when there are more eng resources on `flutter_migrate` someone can
revisit these tests to speed them up and/or make them another type of
test (such as a custom `run_tests` test).
Part of flutter/flutter#121257
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@stuartmorgan-g
[flutter_migrate] Skip slow tests (flutter#3270)
8d174ff
Currently `flutter_migrate` unit tests take 10 minutes to run, which is
1/6 of our total time allowance for a Cirrus test run, and 1-2 orders of
magnitude slower than all of our other unit tests.
This skips the slow tests, with references to a tracking issue. At some
point when there are more eng resources on `flutter_migrate` someone can
revisit these tests to speed them up and/or make them another type of
test (such as a custom `run_tests` test).
Part of flutter/flutter#121257
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparrishMinesbparrishMinesbparrishMines approved these changes
@tarrinnealtarrinnealAwaiting requested review from tarrinneal
@GaryQianGaryQianAwaiting requested review from GaryQian

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: flutter_migrate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g@bparrishMines