Skip to content

[google_maps] Relax the Android renderer request test - #3364

Merged
stuartmorgan-g merged 1 commit into
flutter:mainfrom
stuartmorgan-g:maps-renderer-test-relaxation
Mar 3, 2023
Merged

[google_maps] Relax the Android renderer request test#3364
stuartmorgan-g merged 1 commit into
flutter:mainfrom
stuartmorgan-g:maps-renderer-test-relaxation

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Updates the "initialized with latest renderer" test to just test that the rest resulted in some valid response, since we can't actually control what the server returns; the request is non-binding, and there are cases where (e.g., depending on the device details) the legacy renderer will be returned regardless.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Loading
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@stuartmorgan-g@ditman@bparrishMines