Uh oh!
There was an error while loading. Please reload this page.
[go_router] Fix a typo in the ShellRoute docstring - #3378
Conversation
Remove an extraneous "that" and an unnecessary comma.
auto label is removed for flutter/packages, pr: 3378, due to - The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto label is removed for flutter/packages, pr: 3378, due to - The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
johnpryan
commented
Mar 7, 2023
Hmm, I'm wondering why we can't submit this? This shouldn't need version change, so we added the "override: no versioning needed" label, but it's saying that "the change to this package could not be verified to be exempt from version changes according to repository policy" |
chunhtai
commented
Mar 7, 2023
forgot to rerun the check after applying the label, rerunning |
[go_router] Fix a typo in the ShellRoute docstring
[go_router] Fix a typo in the ShellRoute docstring
[go_router] Fix a typo in the ShellRoute docstring
Remove an extraneous "that" and an unnecessary comma.
This is just a simple typo fix for the docstring comment above the ShellRoute class.
Assuming I am correct that this is a typo, I think it makes the documentation a little
more difficult to read.
There is no issue open to track this, but I can create one if it's really necessary.
I'm going to check the box in the pre-launch checklist anyways 🙈
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).