Uh oh!
There was an error while loading. Please reload this page.
Fix analyzer issues in bsdiff - #342
Merged
stuartmorgan-g merged 1 commit intoMay 5, 2021
Merged
Conversation
Fixes minor issues flagged by the analyzer in preparation for fixing the CI to run checks against the packages in third_party/packages.
stuartmorgan-g added a commit
to stuartmorgan-g/packages
that referenced
this pull request
May 10, 2021
Enabling the new publishing checks was done in a PR that touched at least one package, so didn't actually run on the whole repo, causing post-submit breakage. This fixes the publish errors: - Corrects a version mismatch in fuchsia_ctl and standardizes the format it uses for listing recent versions. - Removes all pre-release SDK requirements now that null safety is stable. - Fixes a publish warning about the use of 'docs' rather than 'doc' in pigeon. It also fixes the test in error in bsdiff by reverting flutter#342 and fixing it correctly. That change was completely wrong, but CI didn't catch it since it wasn't running any tests for third_party/packages/ yet.
11 tasks
stuartmorgan-g added a commit
that referenced
this pull request
May 10, 2021
Enabling the new publishing checks was done in a PR that touched at least one package, so didn't actually run on the whole repo, causing post-submit breakage. This fixes the publish errors: - Corrects a version mismatch in fuchsia_ctl and standardizes the format it uses for listing recent versions. - Removes all pre-release SDK requirements now that null safety is stable. - Fixes a publish warning about the use of 'docs' rather than 'doc' in pigeon. It also fixes the test in error in bsdiff by reverting #342 and fixing it correctly. That change was completely wrong, but CI didn't catch it since it wasn't running any tests for third_party/packages/ yet.
austinstoker pushed a commit
to austinstoker/packages
that referenced
this pull request
Apr 29, 2022
fix types, use Pattern
stuartmorgan-g pushed a commit
that referenced
this pull request
Oct 31, 2024
* Using SvgPicture.network with headers was not possible since headers were not passed to the http get request function * test * bump versions Co-authored-by: Max Oehme <max.oehme@init.de> Co-authored-by: Dan Field <dnfield@google.com>
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
Fixes minor issues flagged by the analyzer in preparation for fixing the CI to run checks against the packages in third_party/packages.
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
Enabling the new publishing checks was done in a PR that touched at least one package, so didn't actually run on the whole repo, causing post-submit breakage. This fixes the publish errors: - Corrects a version mismatch in fuchsia_ctl and standardizes the format it uses for listing recent versions. - Removes all pre-release SDK requirements now that null safety is stable. - Fixes a publish warning about the use of 'docs' rather than 'doc' in pigeon. It also fixes the test in error in bsdiff by reverting flutter#342 and fixing it correctly. That change was completely wrong, but CI didn't catch it since it wasn't running any tests for third_party/packages/ yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes minor issues flagged by the analyzer in preparation for fixing the
CI to run checks against the packages in third_party/packages.
Does not update metadata since nothing here warrants publishing.
Pre-launch Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy.CHANGELOG.mdto add a description of the change.///).