Skip to content

[image_picker_android] Improved Bitmap resize on Android - #3423

Merged
auto-submit[bot] merged 19 commits into
flutter:mainfrom
beroso:118383-improve-android-bitmap-resize
May 10, 2023
Merged

[image_picker_android] Improved Bitmap resize on Android#3423
auto-submit[bot] merged 19 commits into
flutter:mainfrom
beroso:118383-improve-android-bitmap-resize

Conversation

@beroso

@berosoberoso commented Mar 8, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Improves Bitmap load and resize on Android.

Original PR on flutter/plugins: flutter-team-archive/plugins#6947

Issue: flutter/flutter#118383

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@beroso
beroso requested a review from gmackall as a code ownerMarch 8, 2023 19:32
@gmackall

gmackall commented Mar 20, 2023

Copy link
Copy Markdown
Member

Re-requesting review from @tarrinneal and @stuartmorgan as you were both requested on the previous version of this PR.

@tarrinneal

tarrinneal commented Mar 20, 2023

Copy link
Copy Markdown
Contributor

Have you run any benchmarks to see if/how much this is better than the old behaviour?

stuartmorgan-g
stuartmorgan-g requested changes Mar 20, 2023
View reviewed changes
Comment threadpackages/image_picker/image_picker_android/CHANGELOG.md Outdated
Comment thread.../image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImageResizer.java
Comment thread.../image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImageResizer.java Outdated
Comment thread.../image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImageResizer.java Outdated
Comment thread.../image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImageResizer.java Outdated
@beroso
beroso requested review from stuartmorgan-g and removed request for gmackall and tarrinnealMarch 21, 2023 10:56
@beroso

beroso commented Mar 21, 2023

Copy link
Copy Markdown
ContributorAuthor

Sorry, guys. I clicked on "request review" button on @stuartmorgan requested changes, and accidentally removed @gmackall and @tarrinneal from review. It wasn't on purpose.

@beroso

beroso commented Mar 21, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Have you run any benchmarks to see if/how much this is better than the old behaviour?

@tarrinneal , I just ran manual tests. I didn't do any benchmark test to compare the performance.

Before I tried to pick an 12000 x 9000 px, ~10MB image using the example app and it crashed due to an OutOfMemory error (even when the resize was not necessary).

This patch skips Bitmap decoding when resize or quality changes are not needed. Plus it can improve the resize process by subsampling image decoding depending on the maximum requested dimension.

Do you have any tips on how to benchmark it?

@berosoberoso mentioned this pull request Mar 22, 2023
Merged
tarrinneal
tarrinneal reviewed Apr 13, 2023
View reviewed changes
Comment threadpackages/image_picker/image_picker_android/CHANGELOG.md Outdated
tarrinneal
tarrinneal requested changes Apr 13, 2023
View reviewed changes

@tarrinnealtarrinneal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little nit for the changelog, tagging @stuartmorgan for second review.

stuartmorgan-g
stuartmorgan-g requested changes Apr 20, 2023
View reviewed changes
Comment thread.../image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImageResizer.java Outdated
Comment thread.../image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImageResizer.java Outdated
Comment thread.../image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImageResizer.java
Comment thread.../image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImageResizer.java Outdated
@reidbaker

reidbaker commented May 4, 2023

Copy link
Copy Markdown
Contributor

@beroso is this something you still plan on working on?

stuartmorgan-g
stuartmorgan-g approved these changes May 10, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 10, 2023
@auto-submit
auto-submitBot merged commit a1929a6 into flutter:mainMay 10, 2023
@beroso

beroso commented May 10, 2023

Copy link
Copy Markdown
ContributorAuthor

Thank you all for the support!

By the way, the release job is running for about 4 hours. Is it normal?

@stuartmorgan-g

stuartmorgan-g commented May 11, 2023

Copy link
Copy Markdown
Collaborator

No, release was completely broken by the 3.10 release, it turns out. I manually released it for now.

@reidbakerreidbaker mentioned this pull request May 12, 2023
Merged
11 tasks
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
a1929a6[image_picker_android] Improved Bitmap resize on Android (flu…
3f0dfa1
…tter/packages#3423)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
a1929a6[image_picker_android] Improved Bitmap resize on Android (flu…
1c90faa
…tter/packages#3423)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
a1929a6[image_picker_android] Improved Bitmap resize on Android (flu…
1b35a0d
…tter/packages#3423)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
Roll Packages from6328cfbto6608b60(22 revisions) (#126865)
96580f5
flutter/packages@6328cfb...6608b60
2023-05-15 stuartmorgan@google.com [ci] Remove unnecessary Linux libraries (flutter/packages#3975)
2023-05-15 stuartmorgan@google.com [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979)
2023-05-15 stuartmorgan@google.com [ci] Disable Windows repo tool tests (flutter/packages#3980)
2023-05-12 stuartmorgan@google.com [ci] Add LUCI repo tool tests (flutter/packages#3964)
2023-05-12 reidbaker@google.com [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973)
2023-05-12 reidbaker@google.com Update build.gradle with a comment explaining version (flutter/packages#3972)
2023-05-12 engine-flutter-autoroll@skia.org Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958)
2023-05-12 stuartmorgan@google.com [image_picker] Fix Android lints (flutter/packages#3887)
2023-05-12 stuartmorgan@google.com [various] Update minimum Flutter version to 3.3 (flutter/packages#3967)
2023-05-12 stuartmorgan@google.com [tool] Target specific Android unit tests (flutter/packages#3955)
2023-05-12 34871572+gmackall@users.noreply.github.com [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960)
2023-05-12 stuartmorgan@google.com [local_auth] Improve iOS test DI (flutter/packages#3959)
2023-05-12 stuartmorgan@google.com [ci] Ensure scripts fail if a command fails (flutter/packages#3963)
2023-05-11 stuartmorgan@google.com [ci] Pin the Flutter version for `release` (flutter/packages#3965)
2023-05-11 tarrinneal@gmail.com [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784)
2023-05-11 stuartmorgan@google.com [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969)
2023-05-11 stuartmorgan@google.com [tool] Ensure that publish credential path is available (flutter/packages#3970)
2023-05-11 63286031+ahmednfwela@users.noreply.github.com [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877)
2023-05-11 stuartmorgan@google.com [tool] Use new pub cache location for publish (flutter/packages#3962)
2023-05-10 engine-flutter-autoroll@skia.org Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961)
2023-05-10 andrelvsousa@gmail.com [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423)
2023-05-10 43054281+camsim99@users.noreply.github.com [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autorollCasey Hillers
Roll Packages from6328cfbto6608b60(22 revisions) (flutter#126865)
e39437c
flutter/packages@6328cfb...6608b60
2023-05-15 stuartmorgan@google.com [ci] Remove unnecessary Linux libraries (flutter/packages#3975)
2023-05-15 stuartmorgan@google.com [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979)
2023-05-15 stuartmorgan@google.com [ci] Disable Windows repo tool tests (flutter/packages#3980)
2023-05-12 stuartmorgan@google.com [ci] Add LUCI repo tool tests (flutter/packages#3964)
2023-05-12 reidbaker@google.com [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973)
2023-05-12 reidbaker@google.com Update build.gradle with a comment explaining version (flutter/packages#3972)
2023-05-12 engine-flutter-autoroll@skia.org Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958)
2023-05-12 stuartmorgan@google.com [image_picker] Fix Android lints (flutter/packages#3887)
2023-05-12 stuartmorgan@google.com [various] Update minimum Flutter version to 3.3 (flutter/packages#3967)
2023-05-12 stuartmorgan@google.com [tool] Target specific Android unit tests (flutter/packages#3955)
2023-05-12 34871572+gmackall@users.noreply.github.com [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960)
2023-05-12 stuartmorgan@google.com [local_auth] Improve iOS test DI (flutter/packages#3959)
2023-05-12 stuartmorgan@google.com [ci] Ensure scripts fail if a command fails (flutter/packages#3963)
2023-05-11 stuartmorgan@google.com [ci] Pin the Flutter version for `release` (flutter/packages#3965)
2023-05-11 tarrinneal@gmail.com [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784)
2023-05-11 stuartmorgan@google.com [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969)
2023-05-11 stuartmorgan@google.com [tool] Ensure that publish credential path is available (flutter/packages#3970)
2023-05-11 63286031+ahmednfwela@users.noreply.github.com [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877)
2023-05-11 stuartmorgan@google.com [tool] Use new pub cache location for publish (flutter/packages#3962)
2023-05-10 engine-flutter-autoroll@skia.org Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961)
2023-05-10 andrelvsousa@gmail.com [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423)
2023-05-10 43054281+camsim99@users.noreply.github.com [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@beroso@nploi
[image_picker_android] Improved Bitmap resize on Android (flutter#3423)
7b9c468
Improves Bitmap load and resize on Android.
Original PR on flutter/plugins: flutter-team-archive/plugins#6947
Issue: flutter/flutter#118383
@reidbakerreidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbakerreidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@beroso
[image_picker_android] Improved Bitmap resize on Android (flutter#3423)
c1e23da
Improves Bitmap load and resize on Android.
Original PR on flutter/plugins: flutter-team-archive/plugins#6947
Issue: flutter/flutter#118383
@berosoberoso mentioned this pull request Jun 13, 2026
Closed
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@beroso
[image_picker_android] Improved Bitmap resize on Android (flutter#3423)
f26b9b6
Improves Bitmap load and resize on Android.
Original PR on flutter/plugins: flutter-team-archive/plugins#6947
Issue: flutter/flutter#118383
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@tarrinnealtarrinnealtarrinneal approved these changes
@gmackallgmackallAwaiting requested review from gmackall

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: image_pickerplatform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@beroso@gmackall@tarrinneal@reidbaker@stuartmorgan-g