Uh oh!
There was an error while loading. Please reload this page.
[webview_flutter][webview_flutter_android] Add android support for handling geolocation permissions - #3475
[webview_flutter][webview_flutter_android] Add android support for handling geolocation permissions#3475yk3372 wants to merge 0 commit into
Conversation
yk3372
commented
Mar 23, 2023
@bparrishMines@stuartmorgan hi, can you review my code? Thanks |
yk3372
commented
Mar 27, 2023
…… |
bparrishMines
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I left some comments on the implementation.
I think you can remove the changes to webview_flutter. Since this feature is Android only, I don't think we need to include an example in webview_flutter. We don't want to have every platform specific feature used as an example in the app-facing package.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
I have finished it. Please review it again, thanks @bparrishMines And why my dart format always fail to the rule? this wasted a lot of my time |
bparrishMines
commented
Apr 10, 2023
@yk3372 The dart formatter was most likely failing because you were using an older version of Flutter. We develop plugins on the latest version of the main branch of flutter/flutter, so running the It looks like this has the new Android lint errors from #3648. I'll update this PR after I update the pigeon version and lint errors in another PR. |
yk3372
commented
Apr 17, 2023
please review again, thanks |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bparrishMines
commented
Apr 20, 2023
I left a few more comments and updated the lint the Java code for the new lint warnings. |
yk3372
commented
Apr 21, 2023
I have finish it, please review again, thanks |
I have made a wrong operation…… |
This PR Add android support for handling geolocation permissions.
(WebChromeClient.onGeolocationPermissionsShowPrompt) api as a platform callback that notify the host application that web content from the specified origin is attempting to use the Geolocation API.
The host application should invoke the specified callback with the desired permission state.
Fixesflutter/flutter#27472
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).