Skip to content

Revert "[flutter_template_images] Add support for new template and shared platform files" - #353

Merged
stuartmorgan-g merged 4 commits into
masterfrom
revert-295-new_template_images
May 14, 2021
Merged

Revert "[flutter_template_images] Add support for new template and shared platform files"#353
stuartmorgan-g merged 4 commits into
masterfrom
revert-295-new_template_images

Conversation

@stuartmorgan-g

@stuartmorgan-gstuartmorgan-g commented May 13, 2021

Copy link
Copy Markdown
Collaborator

Reverts #295

The corresponding flutter/flutter changes never landed, so that package layout is unusable for now. Since 2.0 was published already, to minimize long-term confusion this uses 3.0 rather than going back to 1.0.

@jonahwilliamsjonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g

Copy link
Copy Markdown
CollaboratorAuthor

Looks like I need to fix the tooling to allow reverts.

@cbrackencbracken mentioned this pull request May 14, 2021
11 tasks
@stuartmorgan-g

Copy link
Copy Markdown
CollaboratorAuthor

In the interests of time, we'll just make this 3.0. Annoying, but since we don't know for sure the final layout won't change when it actually lands, probably less confusing in long run.

@stuartmorgan-g
stuartmorgan-g merged commit 6081b46 into masterMay 14, 2021
@stuartmorgan-g
stuartmorgan-g deleted the revert-295-new_template_images branch May 14, 2021 20:39
austinstoker pushed a commit to austinstoker/packages that referenced this pull request Apr 29, 2022
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…ared platform files" (flutter#353)
Reverts flutter#295
The corresponding flutter/flutter changes never landed, so that package layout is unusable for now. Since 2.0 was published already, to minimize long-term confusion this uses 3.0 rather than going back to 1.0.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@stuartmorgan-g@jonahwilliams@stuartmorgan