Skip to content

Update image_picker_ios to the latest pigeon - #3563

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
natebosch:image-picker-latest-pigeon
Mar 27, 2023
Merged

Update image_picker_ios to the latest pigeon#3563
auto-submit[bot] merged 2 commits into
flutter:mainfrom
natebosch:image-picker-latest-pigeon

Conversation

@natebosch

@nateboschnatebosch commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

The current version is incompatible with the latest analyzer, which is a blocker for getting the latest mockito, which is a blocker for getting the latest test_api, which is pinned by flutter_test and will be breaking in the next package roll.G

@natebosch
Update image_picker_ios to the latest pigeon
f7c47af
The current version is incompatible with the latest `analyzer`, which is
a blocker for getting the latest `mockito`, which is a blocker for
getting the latest `test_api`, which is pinned by `flutter_test` and
will be breaking in the next package roll.
@flutter-dashboard

flutter-dashboardBot commented Mar 27, 2023

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

stuartmorgan-g
stuartmorgan-g approved these changes Mar 27, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

Comment threadpackages/image_picker/image_picker_ios/CHANGELOG.md Outdated
Comment threadpackages/image_picker/image_picker_ios/CHANGELOG.md Outdated
@Hixie

Hixie commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

test-exempt: dependency roll

@nateboschnatebosch added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2023
@auto-submit
auto-submitBot merged commit ded5482 into flutter:mainMar 27, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Mar 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
ded5482Update image_picker_ios to the latest pigeon (flutter/package…
c69b968
…s#3563)
@natebosch
natebosch deleted the image-picker-latest-pigeon branch March 28, 2023 17:41
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@natebosch@nploi
Update image_picker_ios to the latest pigeon (flutter#3563)
d615256
Update image_picker_ios to the latest pigeon
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@natebosch
Update image_picker_ios to the latest pigeon (flutter#3563)
3f49435
Update image_picker_ios to the latest pigeon
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@natebosch
Update image_picker_ios to the latest pigeon (flutter#3563)
54f067b
Update image_picker_ios to the latest pigeon
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@vashworthvashworthAwaiting requested review from vashworth

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appneeds testsp: image_pickerplatform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@natebosch@Hixie@stuartmorgan-g