Uh oh!
There was an error while loading. Please reload this page.
[go_router_builder] Adds support for required $extra parameter - #3627
Conversation
chunhtai
commented
Apr 3, 2023
Hi @Hangyujin Can you take a look at this PR? |
dancamdev
commented
Apr 6, 2023
Fixed the merge conflicts with |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
dancamdev
commented
Apr 6, 2023
Thanks @Michele-x98 for the fix! |
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, once the ci failure are fixed
dancamdev
commented
Apr 7, 2023
@chunhtai should be good to go |
chunhtai
commented
Apr 7, 2023
It looks like there are still some failures |
Due to the following:
But this is a CI issue because If that's not it, mind pointing me to the issue you're seeing? Thanks |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
dancamdev
commented
Apr 7, 2023
@chunhtai Got it working! |
…er#3627) [go_router_builder] Adds support for required $extra parameter
…er#3627) [go_router_builder] Adds support for required $extra parameter
As per title, because of contributing to the following PRs: [flutter#3702](flutter#3702) [flutter#3665](flutter#3665) [flutter#3627](flutter#3627)
…er#3627) [go_router_builder] Adds support for required $extra parameter
As per title, because of contributing to the following PRs: [flutter#3702](flutter#3702) [flutter#3665](flutter#3665) [flutter#3627](flutter#3627)
This PR includes support for having type-safe non-nullable
$extraparameters when working withTypedGoRoutes. Optional$extrais still supported so this isn't a breaking change.List which issues are fixed by this PR. You must list at least one issue.
#117261
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.