[google_maps_flutter] Cloud-based map styling support by amuramoto · Pull Request #3682 · flutter/packages

amuramoto · 2023-04-10T23:12:30Z

Recreates flutter-team-archive/plugins#6553 form flutter/plugins which had approvals in-progress.

amuramoto · 2023-04-11T16:39:02Z

@stuartmorgan I believe review for this one was in progress with you in the plugins repo

ditman

Web bits look great, thanks for the test! I have a small nitpick, and a couple of questions. My biggest concern is the one about having separate MapIDs per platform, not sure how we want that to work. (In the current version it seems not supported directly by the plugin.)

stuartmorgan-g · 2023-04-12T03:00:29Z

Thanks for picking this up! I'll try to review this later this week. In the meantime, there are a ton of CI failures mostly due to Dart compilation errors that will need to be addressed. There's one from the use of both super.key and : super(key: key) on the same constructor; there may be others as well.

leighajarett · 2023-04-12T12:52:15Z

@jokerttu could you help look into the CI failures?

stuartmorgan-g

I fixed the Dart compilation errors so we can get real CI runs.

reidbaker · 2023-05-04T18:48:54Z

@amuramoto is this something you still plan to work on?

amuramoto · 2023-05-16T20:47:46Z

@amuramoto is this something you still plan to work on?

I believe @jokerttu and team at Codemate are handling this. Please let me know if there's anything you need from me

stuartmorgan-g · 2023-05-31T17:18:01Z

 For details, see [the Android README](https://pub.dev/packages/google_maps_flutter_android#display-mode).

+#### Cloud-based map styling
+Cloud-based map styling works on Android platform only if `AndroidMapRenderer.latest` map renderer has been initialized.


Nit: Blank line above this, matching the rest of the file.

stuartmorgan-g · 2023-05-31T17:18:15Z

 For details, see [the Android README](https://pub.dev/packages/google_maps_flutter_android#display-mode).

+#### Cloud-based map styling
+Cloud-based map styling works on Android platform only if `AndroidMapRenderer.latest` map renderer has been initialized.


Nit: remove "platform"

stuartmorgan-g · 2023-05-31T17:25:05Z

@@ -1,5 +1,5 @@
-# Uncomment this line to define a global platform for your project
-# platform :ios, '11.0'
+# Global platform version is set to 12 for this example project to support cloud-based maps styling


The iOS 11 example should not be changed to use iOS 12. That's what the iOS 12 and iOS 13 examples are for.

Of course not, accidentally missed this in rebase. Change reverted.

stuartmorgan-g · 2023-05-31T17:28:07Z

It's fine to go ahead and split out the platform interface sub-PR at this point, there's nothing controversial about that part of the change.

jokerttu · 2023-08-25T10:33:50Z

Integration tests for web platform seems to hang and timeout after and hour. This is something new; I need to check tomorrow what's causing this. Or if it is even related to this PR.

@stuartmorgan @bparrishMines integration tests for web fixed at fb7a3ea

bparrishMines

LGTM

…r/packages#3682)

flutter/packages@e7d812c...22d4754 2023-09-07 engine-flutter-autoroll@skia.org Roll Flutter (stable) from ff5b5b5 to 2524052 (6 revisions) (flutter/packages#4866) 2023-09-07 maurits@vnbskm.nl [webview_flutter_platform_interface] Adds option to override console log (flutter/packages#4701) 2023-09-01 stuartmorgan@google.com [tools,pigeon] Update tooling to handle Windows build output changes (flutter/packages#4826) 2023-08-31 amuramoto@users.noreply.github.com [google_maps_flutter] Cloud-based map styling support (flutter/packages#3682) 2023-08-31 stuartmorgan@google.com [ci] Convert version presubmit check to LUCI (flutter/packages#4822) 2023-08-31 rajveer0malviya@gmail.com [url_launcher_android] Add support for Custom Tabs (flutter/packages#4739) 2023-08-31 tarrinneal@gmail.com [webview_flutter] update pigeon to 11 (flutter/packages#4821) 2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter (stable) from e1e4722 to ff5b5b5 (1 revision) (flutter/packages#4823) 2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter from 1fe2495 to c175cf8 (30 revisions) (flutter/packages#4825) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…map styling (#4141) This PR is sub-PR splitted out from the flutter/packages#3682 containing only the platform_interface package changes. Related to issue flutter/flutter#67631

This PR is sub-PR splitted out from the flutter/packages#3682 containing only following packages: - google_maps_flutter_web - google_maps_flutter_android - google_maps_flutter_ios Related to issue flutter/flutter#67631

…map styling (flutter#4141) This PR is sub-PR splitted out from the flutter#3682 containing only the platform_interface package changes. Related to issue flutter/flutter#67631

…#4638) This PR is sub-PR splitted out from the flutter#3682 containing only following packages: - google_maps_flutter_web - google_maps_flutter_android - google_maps_flutter_ios Related to issue flutter/flutter#67631

Recreates flutter-team-archive/plugins#6553 form flutter/plugins which had approvals in-progress. Fixesflutter/flutter#67631

…map styling (flutter#4141) This PR is sub-PR splitted out from the flutter#3682 containing only the platform_interface package changes. Related to issue flutter/flutter#67631

…#4638) This PR is sub-PR splitted out from the flutter#3682 containing only following packages: - google_maps_flutter_web - google_maps_flutter_android - google_maps_flutter_ios Related to issue flutter/flutter#67631

Recreates flutter-team-archive/plugins#6553 form flutter/plugins which had approvals in-progress. Fixesflutter/flutter#67631

amuramoto requested review from cyanglaz, ditman, reidbaker and stuartmorgan-g as code owners April 10, 2023 23:12

github-actionsBot added p: google_maps_flutter platform-android platform-ios platform-web labels Apr 10, 2023

amuramoto marked this pull request as draft April 10, 2023 23:14

amuramoto force-pushed the cbms branch from 0a64bb1 to 7bcaa86Compare April 10, 2023 23:29

github-actionsBot added the p: flutter_migrate label Apr 10, 2023

amuramoto marked this pull request as ready for review April 10, 2023 23:29

amuramoto marked this pull request as draft April 10, 2023 23:32

github-actionsBot removed the p: flutter_migrate label Apr 10, 2023

amuramoto marked this pull request as ready for review April 10, 2023 23:39

amuramoto mentioned this pull request Apr 11, 2023
[google_map_flutter] New Cloud-based map style feature support request flutter/flutter#67631
Closed

ditman reviewed Apr 12, 2023
View reviewed changes

stuartmorgan-g changed the title ~~[google_maps_flutter] Recreating PR #6553 from flutter/plugins~~[google_maps_flutter] Cloud-based map styling supportApr 12, 2023

stuartmorgan-g requested changes Apr 18, 2023
View reviewed changes

jokerttu mentioned this pull request Apr 27, 2023
[google_maps_flutter] fixes amuramoto/packages#1
Merged

stuartmorgan-g reviewed Apr 28, 2023
View reviewed changes

amuramoto requested a review from stuartmorgan-g May 24, 2023 20:48

stuartmorgan-g previously requested changes May 31, 2023
View reviewed changes

jokerttu mentioned this pull request Jun 5, 2023
[google_maps_flutter_platform_interface] Add support for cloud-based map styling #4141
Merged
11 tasks

jokerttu added 2 commits August 25, 2023 09:25

[google_maps_flutter] fix web tests for cloudMapId
fb7a3ea

Merge branch 'main' into cbms
991d197

jokerttu added 2 commits August 29, 2023 21:23

Merge branch 'main' into cbms
c5edd38

Merge branch 'main' into cbms
49aa3a1

bparrishMines approved these changes Aug 31, 2023
View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2023

auto-submitBot merged commit cd94db1 into flutter:mainAug 31, 2023

jokerttu deleted the cbms branch September 1, 2023 04:37

engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Roll Packages from e7d812cefce0 to b8b84b2304f0 (7 revisions) flutter/flutter#133865
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 1, 2023
cd94db1[google_maps_flutter] Cloud-based map styling support (flutte…
e2870dd
…r/packages#3682)

engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Roll Packages from e7d812cefce0 to b8b84b2304f0 (7 revisions) flutter/flutter#133875
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 1, 2023
cd94db1[google_maps_flutter] Cloud-based map styling support (flutte…
1927b5d
…r/packages#3682)

engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Roll Packages from e7d812cefce0 to b8b84b2304f0 (7 revisions) flutter/flutter#133988
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 4, 2023
cd94db1[google_maps_flutter] Cloud-based map styling support (flutte…
e25fb1f
…r/packages#3682)

engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Roll Packages from e7d812cefce0 to 1598ccd89665 (8 revisions) flutter/flutter#134224
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2023
cd94db1[google_maps_flutter] Cloud-based map styling support (flutte…
ad2a664
…r/packages#3682)

engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Roll Packages from e7d812cefce0 to 22d475491502 (9 revisions) flutter/flutter#134232
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2023
cd94db1[google_maps_flutter] Cloud-based map styling support (flutte…
d1562d0
…r/packages#3682)

reidbaker mentioned this pull request Sep 15, 2023
Update annotations deps to 1.7 #4935
Merged
11 tasks

bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
[google_maps_flutter] Cloud-based map styling support (flutter#3682)
49a4526
Recreates flutter-team-archive/plugins#6553 form flutter/plugins which had approvals in-progress. Fixesflutter/flutter#67631

Uh oh!

Conversation

amuramoto commented Apr 10, 2023• edited by stuartmorgan-g Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amuramoto commented Apr 11, 2023

Uh oh!

ditman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g commented Apr 12, 2023

Uh oh!

leighajarett commented Apr 12, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reidbaker commented May 4, 2023

Uh oh!

amuramoto commented May 16, 2023

Uh oh!

stuartmorgan-gMay 31, 2023

Choose a reason for hiding this comment

Uh oh!

jokerttuJun 1, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-gMay 31, 2023

Choose a reason for hiding this comment

Uh oh!

jokerttuJun 1, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-gMay 31, 2023

Choose a reason for hiding this comment

Uh oh!

jokerttuJun 1, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented May 31, 2023

Uh oh!

jokerttu commented Aug 25, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

amuramoto commented Apr 10, 2023•
edited by stuartmorgan-g
Loading

leighajarett commented Apr 12, 2023•
edited
Loading

jokerttu commented Aug 25, 2023•
edited
Loading