Skip to content

[go_router_builder] Use only one .where() - #3698

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
GP4cK:refacto-inline-function
Apr 13, 2023
Merged

[go_router_builder] Use only one .where()#3698
auto-submit[bot] merged 1 commit into
flutter:mainfrom
GP4cK:refacto-inline-function

Conversation

@GP4cK

@GP4cKGP4cK commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

Resolves this comment: https://github.com/flutter/packages/pull/3439/files/6b4ccf1dafb29b2a914b278bdb137da2885a3737#r1164685330

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@GP4cK
GP4cK requested a review from chunhtai as a code ownerApril 13, 2023 00:49
@flutter-dashboard

flutter-dashboardBot commented Apr 13, 2023

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@GP4cKGP4cK mentioned this pull request Apr 13, 2023
Merged
11 tasks
@GP4cK

GP4cK commented Apr 13, 2023

Copy link
Copy Markdown
ContributorAuthor

@kevmoo can you add "override: no versioning needed" to fix the repo_checks step?

@kevmookevmoo added the override: no versioning needed Override the check requiring version bumps for most changes label Apr 13, 2023
@Hixie

Hixie commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

test-exempt: code refactor with no semantic change

@GP4cK

GP4cK commented Apr 13, 2023

Copy link
Copy Markdown
ContributorAuthor

Do I need to do anything else?

@kevmookevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 13, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 13, 2023
@auto-submit

auto-submitBot commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages, pr: 3698, due to This PR has not met approval requirements for merging. You have project association CONTRIBUTOR and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit

auto-submitBot commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages, pr: 3698, due to - The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit

auto-submitBot commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages, pr: 3698, due to Validations Fail.

chunhtai
chunhtai approved these changes Apr 13, 2023
View reviewed changes

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtaichunhtai added override: no changelog needed Override the check requiring CHANGELOG updates for most changes autosubmit Merge PR when tree becomes green via auto submit App and removed needs tests labels Apr 13, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 13, 2023
@auto-submit

auto-submitBot commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages, pr: 3698, due to - The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtaichunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 13, 2023
@auto-submit
auto-submitBot merged commit 38f7714 into flutter:mainApr 13, 2023
@GP4cK
GP4cK deleted the refacto-inline-function branch April 13, 2023 23:40
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 14, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2023
@engine-flutter-autoroll
38f7714[go_router_builder] Use only one .where() (flutter/packages#3698
efb5295
)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Apr 14, 2023
@engine-flutter-autoroll
Roll Packages fromd01f4eatoe4ec155(5 revisions) (#124863)
5dbab86
flutter/packages@d01f4ea...e4ec155
2023-04-14 stuartmorgan@google.com [shared_preferences] Remove Android lint baseline (flutter/packages#3707)
2023-04-13 37607224+AmanNegi@users.noreply.github.com [shared_preferences] Ports SharedPreferencesAndroid to Pigeon (flutter/packages#3321)
2023-04-13 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Fix Android lint warnings (flutter/packages#3675)
2023-04-13 gautier.bayzelon@gmail.com [go_router_builder] Use only one .where() (flutter/packages#3698)
2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter from 3b4b149 to be45eb2 (21 revisions) (flutter/packages#3701)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73 pushed a commit to exaby73/flutter_nevercode that referenced this pull request Apr 17, 2023
@engine-flutter-autoroll@exaby73
Roll Packages fromd01f4eatoe4ec155(5 revisions) (flutter#124863)
a04688f
flutter/packages@d01f4ea...e4ec155
2023-04-14 stuartmorgan@google.com [shared_preferences] Remove Android lint baseline (flutter/packages#3707)
2023-04-13 37607224+AmanNegi@users.noreply.github.com [shared_preferences] Ports SharedPreferencesAndroid to Pigeon (flutter/packages#3321)
2023-04-13 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Fix Android lint warnings (flutter/packages#3675)
2023-04-13 gautier.bayzelon@gmail.com [go_router_builder] Use only one .where() (flutter/packages#3698)
2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter from 3b4b149 to be45eb2 (21 revisions) (flutter/packages#3701)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Apr 25, 2023
Merged
11 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@GP4cK@nploi
[go_router_builder] Use only one .where() (flutter#3698)
e17212e
[go_router_builder] Use only one .where()
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@GP4cK
[go_router_builder] Use only one .where() (flutter#3698)
d4f7073
[go_router_builder] Use only one .where()
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@GP4cK
[go_router_builder] Use only one .where() (flutter#3698)
62b0684
[go_router_builder] Use only one .where()
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevmookevmookevmoo approved these changes
@johnpryanjohnpryanjohnpryan approved these changes
@chunhtaichunhtaichunhtai approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appoverride: no changelog neededOverride the check requiring CHANGELOG updates for most changesoverride: no versioning neededOverride the check requiring version bumps for most changesp: go_router_builder

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GP4cK@Hixie@kevmoo@johnpryan@chunhtai