Skip to content

[file_selector] Add getDirectoryPaths implementation for macOS - #3703

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
stuartmorgan-g:file-selector-macos-get-directories
May 1, 2023
Merged

[file_selector] Add getDirectoryPaths implementation for macOS#3703
auto-submit[bot] merged 3 commits into
flutter:mainfrom
stuartmorgan-g:file-selector-macos-get-directories

Conversation

@stuartmorgan-g

@stuartmorgan-gstuartmorgan-g commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

Implements the new getDirectoryPaths platform interface method.

This is a recreation of flutter-team-archive/plugins#7115 with very minor (pubspec version and CHANGELOG) updates for conflicts with main.

Part of flutter/flutter#74323

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Implements the new `getDirectoryPaths` platform interface method.
Part of flutter/flutter#74323

@cbrackencbracken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2023
@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages, pr: 3703, due to This PR has not met approval requirements for merging. You have project association MEMBER and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2023
@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages, pr: 3703, due to Validations Fail.

@stuartmorgan-g

Copy link
Copy Markdown
CollaboratorAuthor

@cbracken Looks like you clicked the wrong button with the LGTM. Thanks autosubmit bot, for noticing when I didn't :)

@cbrackencbracken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This time with actual approval!

@cbrackencbracken added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2023
@auto-submit
auto-submitBot merged commit 251010e into flutter:mainMay 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 2, 2023
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request May 2, 2023
flutter/packages@de6131d...f163786
2023-05-01 43054281+camsim99@users.noreply.github.com [camerax] Retrieve exposure and zoom camera information (flutter/packages#3798)
2023-05-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 66fa4c5 to 828a040 (79 revisions) (flutter/packages#3874)
2023-05-01 vashworth@google.com [video_player, google_sign_in] Updates functions without a prototype to avoid deprecation warning (flutter/packages#3873)
2023-05-01 reidbaker@google.com [various] Speed up build-examples (flutter/packages#3849)
2023-05-01 stuartmorgan@google.com [file_selector] Remove uses of `macUTIs` (flutter/packages#3859)
2023-05-01 stuartmorgan@google.com [file_selector] Add getDirectoryPaths implementation for macOS (flutter/packages#3703)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
…er#3703)
Implements the new `getDirectoryPaths` platform interface method.
This is a recreation of flutter-team-archive/plugins#7115 with very minor (pubspec version and CHANGELOG) updates for conflicts with main.
Part of flutter/flutter#74323
@reidbakerreidbaker mentioned this pull request Aug 4, 2023
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…er#3703)
Implements the new `getDirectoryPaths` platform interface method.
This is a recreation of flutter-team-archive/plugins#7115 with very minor (pubspec version and CHANGELOG) updates for conflicts with main.
Part of flutter/flutter#74323
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…er#3703)
Implements the new `getDirectoryPaths` platform interface method.
This is a recreation of flutter-team-archive/plugins#7115 with very minor (pubspec version and CHANGELOG) updates for conflicts with main.
Part of flutter/flutter#74323
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: file_selectorplatform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g@cbracken