Skip to content

[go_router] Remove unused navigator keys - #3708

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
GP4cK:remove-unused-navigator-key
Apr 28, 2023
Merged

[go_router] Remove unused navigator keys#3708
auto-submit[bot] merged 3 commits into
flutter:mainfrom
GP4cK:remove-unused-navigator-key

Conversation

@GP4cK

@GP4cKGP4cK commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

Remove unused navigator keys from GoRouteData and ShellRouteData.
Closesflutter/flutter#124497

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@GP4cK
GP4cK requested a review from chunhtai as a code ownerApril 14, 2023 00:39
chunhtai
chunhtai approved these changes Apr 14, 2023
View reviewed changes

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up

@chunhtai
chunhtai requested review from hannah-hyj and johnpryan and removed request for johnpryanApril 14, 2023 15:58
hannah-hyj
hannah-hyj approved these changes Apr 21, 2023
View reviewed changes

@hannah-hyjhannah-hyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtaichunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 27, 2023
@auto-submit
auto-submitBot merged commit 5bc70c7 into flutter:mainApr 28, 2023
@GP4cK
GP4cK deleted the remove-unused-navigator-key branch April 28, 2023 23:06
sybrands-place pushed a commit to sybrands-place/packages that referenced this pull request May 1, 2023
Jeremy
Merge branch 'main' into webview_patchedv5
9965c00
* main: (46 commits)
[go_router] Cleans up route match API and introduces dart fix (flutter#3819)
[camerax] Add `LifecycleOwner` Proxy (flutter#3837)
[file_selector] Add getDirectoryPaths implementation for Windows (flutter#3704)
[various] Update Android example min SDKs (flutter#3847)
Bump github/codeql-action from 2.2.12 to 2.3.2 (flutter#3838)
[camerax] Implement Image Streaming (flutter#3454)
[various] update agp and gradle for all examples in packages (flutter#3822)
Update xcode to 14c18 (flutter#3774)
[camera_android] Add NV21 as an image stream format flutter#3277 (flutter#3639)
[go_router] Remove unused navigator keys (flutter#3708)
[image_picker] Move I/O operations to a separate thread (flutter#3506)
[pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.20 to 1.8.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter#3824)
[pigeon] Reland: Add an initial example app (flutter#3832)
Roll Flutter from c9004ff to 66fa4c5 (68 revisions) (flutter#3830)
[various] Conditionalize the namespace in all Android plugins (flutter#3836)
[in_app_pur]: Bump com.android.billingclient:billing from 5.1.0 to 5.2.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter#3672)
[auick_action_ios] Retries multiple times to not fail ci when there is a flake (flutter#3823)
Swap some iOS package CODEOWNERS (flutter#3793)
[various] Add `targetCompatibility` to build.gradle (flutter#3825)
[various] Set cmake_policy versions (flutter#3828)
...
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2023
@engine-flutter-autoroll
5bc70c7[go_router] Remove unused navigator keys (flutter/packages#3708)
7b67e3e
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2023
@engine-flutter-autoroll
5bc70c7[go_router] Remove unused navigator keys (flutter/packages#3708)
fa556e0
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request May 1, 2023
@engine-flutter-autoroll
Roll Packages from7e3f5datode6131d(41 revisions) (#125811)
ff248d2
Roll Packages from 7e3f5da to de6131d (41 revisions)
flutter/packages@7e3f5da...de6131d
2023-05-01 reidbaker@google.com I122213 update non examples (flutter/packages#3846)
2023-04-29 47866232+chunhtai@users.noreply.github.com [go_router] Cleans up route match API and introduces dart fix (flutter/packages#3819)
2023-04-29 43054281+camsim99@users.noreply.github.com [camerax] Add `LifecycleOwner` Proxy (flutter/packages#3837)
2023-04-29 stuartmorgan@google.com [file_selector] Add getDirectoryPaths implementation for Windows (flutter/packages#3704)
2023-04-29 stuartmorgan@google.com [various] Update Android example min SDKs (flutter/packages#3847)
2023-04-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.2.12 to 2.3.2 (flutter/packages#3838)
2023-04-28 43054281+camsim99@users.noreply.github.com [camerax] Implement Image Streaming (flutter/packages#3454)
2023-04-28 reidbaker@google.com [various] update agp and gradle for all examples in packages (flutter/packages#3822)
2023-04-28 54558023+keyonghan@users.noreply.github.com Update xcode to 14c18 (flutter/packages#3774)
2023-04-28 andrewjohncoutts@gmail.com [camera_android] Add NV21 as an image stream format #3277 (flutter/packages#3639)
2023-04-28 gautier.bayzelon@gmail.com [go_router] Remove unused navigator keys (flutter/packages#3708)
2023-04-28 JeroenWeener@users.noreply.github.com [image_picker] Move I/O operations to a separate thread (flutter/packages#3506)
2023-04-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.20 to 1.8.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3824)
2023-04-28 stuartmorgan@google.com [pigeon] Reland: Add an initial example app (flutter/packages#3832)
2023-04-28 engine-flutter-autoroll@skia.org Roll Flutter from c9004ff to 66fa4c5 (68 revisions) (flutter/packages#3830)
2023-04-28 stuartmorgan@google.com [various] Conditionalize the namespace in all Android plugins (flutter/packages#3836)
2023-04-27 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.billingclient:billing from 5.1.0 to 5.2.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3672)
2023-04-27 ychris@google.com [auick_action_ios] Retries multiple times to not fail ci when there is a flake (flutter/packages#3823)
2023-04-26 magder@google.com Swap some iOS package CODEOWNERS (flutter/packages#3793)
2023-04-26 stuartmorgan@google.com [various] Add `targetCompatibility` to build.gradle (flutter/packages#3825)
2023-04-26 stuartmorgan@google.com [various] Set cmake_policy versions (flutter/packages#3828)
2023-04-26 stuartmorgan@google.com [path_provider] Allow `win32` up to version 4.x (flutter/packages#3820)
2023-04-26 stuartmorgan@google.com [tool] Move Android lint checks (flutter/packages#3816)
2023-04-25 evace93@gmail.com [google_maps_flutter_android] Fix Android lint warnings (flutter/packages#3751)
2023-04-25 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.5.0 to 1.6.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3381)
2023-04-25 jason-simmons@users.noreply.github.com Update test golden images for the latest Skia roll (flutter/packages#3787)
2023-04-25 stuartmorgan@google.com [various] Adds Android namespace (flutter/packages#3791)
2023-04-25 reidbaker@google.com [shared_preferences] Update gradle/agp in example apps (flutter/packages#3809)
2023-04-24 43640732+dancamdev@users.noreply.github.com [go_router] Adds name to TypedGoRoute (flutter/packages#3702)
2023-04-22 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support to receive permission requests (flutter/packages#3543)
2023-04-21 stuartmorgan@google.com [google_sign_in] Fix Android Java warnings (flutter/packages#3762)
2023-04-21 stuartmorgan@google.com [local_auth] Fix enum return on Android (flutter/packages#3780)
2023-04-21 stuartmorgan@google.com [pigeon] Warn when trying to use enums in collections (flutter/packages#3782)
2023-04-21 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] [webview_flutter_wkwebview] Platform implementations for supporting permission requests (flutter/packages#3792)
2023-04-21 scheglov@google.com [pigeon] Update for compatibility with a future change to the analyzer. (flutter/packages#3789)
2023-04-21 10687576+bparrishMines@users.noreply.github.com [camera_android] Fix Android lint warnings (flutter/packages#3716)
2023-04-21 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds method to receive permission requests (flutter/packages#3767)
2023-04-21 magder@google.com [image_picker_ios] In unit test write and read kCGImagePropertyExifUserComment property (flutter/packages#3783)
2023-04-21 widrans@gmail.com [go_router_builder] Fixed the return value of the generated push method (flutter/packages#3650)
2023-04-21 JeroenWeener@users.noreply.github.com [image_picker] Mention `launchMode: singleInstance` in README (flutter/packages#3759)
2023-04-21 stuartmorgan@google.com Revert "[pigeon] Add an initial example app" (flutter/packages#3785)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
...
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@GP4cK@nploi
[go_router] Remove unused navigator keys (flutter#3708)
3e78b25
Remove unused navigator keys from GoRouteData and ShellRouteData.
Closesflutter/flutter#124497
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@GP4cK
[go_router] Remove unused navigator keys (flutter#3708)
60afba7
Remove unused navigator keys from GoRouteData and ShellRouteData.
Closesflutter/flutter#124497
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@GP4cK
[go_router] Remove unused navigator keys (flutter#3708)
baf3561
Remove unused navigator keys from GoRouteData and ShellRouteData.
Closesflutter/flutter#124497
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtaichunhtaichunhtai approved these changes
@hannah-hyjhannah-hyjhannah-hyj approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: go_router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[go_router_builder] Pass GoRouteData.navigatorKey to generated GoRoute parentNavigatorKey

3 participants

@GP4cK@chunhtai@hannah-hyj