Skip to content

[Pigeon] enum ios unittest - #376

Merged
gaaclarke merged 2 commits into
flutter:masterfrom
gaaclarke:pigeon_enum_ios_unittest
Jun 14, 2021
Merged

[Pigeon] enum ios unittest#376
gaaclarke merged 2 commits into
flutter:masterfrom
gaaclarke:pigeon_enum_ios_unittest

Conversation

@gaaclarke

@gaaclarkegaaclarke commented Jun 8, 2021•
edited
Loading

Copy link
Copy Markdown
Member

addendum to: #375
depends on: #373

cc @GaryQian

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke
gaaclarkeforce-pushed the pigeon_enum_ios_unittest branch from 72b85eb to 84edb9bCompareJune 14, 2021 18:33
@gaaclarke
gaaclarkeforce-pushed the pigeon_enum_ios_unittest branch from 84edb9b to aea7e78CompareJune 14, 2021 18:37
@gaaclarke
gaaclarke marked this pull request as ready for review June 14, 2021 18:39
@gaaclarke

gaaclarke commented Jun 14, 2021

Copy link
Copy Markdown
MemberAuthor

(one sec, I forgot to upload pigeons/enum.dart and subsequently deleted it)

GaryQian
GaryQian approved these changes Jun 14, 2021
View reviewed changes

@GaryQianGaryQian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@GaryQian

GaryQian commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

Oh i assumed it was already in pigeons. Guess not.

@gaaclarke

gaaclarke commented Jun 14, 2021

Copy link
Copy Markdown
MemberAuthor

Added it now if you want to double check it.

@GaryQian

GaryQian commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

Yep, still lgtm.

@gaaclarke
gaaclarke merged commit 5bd986b into flutter:masterJun 14, 2021
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@gaaclarke
[Pigeon] enum ios unittest (flutter#376)
311d10b
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gAwaiting requested review from stuartmorgan-g
1 more reviewer
@GaryQianGaryQianGaryQian approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesp: pigeon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaaclarke@GaryQian