Uh oh!
There was an error while loading. Please reload this page.
[go_router_builder] fixed typo in README - #3835
Conversation
Replaced "were" in line 344 of the README with "where".
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, you will need to sign CLA in order to contribute to go_router
stuartmorgan-g
commented
Apr 28, 2023
@chunhtai When adding override labels, please leave a comment explaining why, per the last paragraphs here and here. Since overriding for READMEs is the opposite of the documented policy it should include a clear explanation of why. (That's not to say that overriding it is necessariy incorrect in this instance, just that it should be explained.) |
stuartmorgan-g
commented
Apr 28, 2023
@TheUltimateOptimist In the future please don't delete the checklist when submitting PRs; you skipped several steps in it. |
chunhtai
commented
Apr 28, 2023
override version and change logs The changes to the readme is insignificant enough to not affect the readability. the change also doesn't worth mentioning in change logs since it doesn't affect developers |
auto label is removed for flutter/packages, pr: 3835, due to - The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@6bd59cd...a0f8fd8 2023-05-05 tarrinneal@gmail.com tree fix (flutter/packages#3910) 2023-05-05 tarrinneal@gmail.com manual roll and fix (flutter/packages#3903) 2023-05-04 stuartmorgan@google.com [file_selector] Add `getDirectoryPaths` (flutter/packages#3871) 2023-05-04 75943909+TheUltimateOptimist@users.noreply.github.com [go_router_builder] fixed typo in README (flutter/packages#3835) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Replaced "were" in line 344 of the README with "where".
Replaced "were" in line 344 of the README with "where".
Replaced "were" in line 344 of the README with "where".
Replaced "were" in line 344 of the README with "where".