Skip to content

[flutter_markdown] Add TableCellVerticalAlignment property in markdown stylesheet - #3880

Merged
auto-submit[bot] merged 7 commits into
flutter:mainfrom
joshpetit:main
Jul 5, 2023
Merged

[flutter_markdown] Add TableCellVerticalAlignment property in markdown stylesheet#3880
auto-submit[bot] merged 7 commits into
flutter:mainfrom
joshpetit:main

Conversation

@joshpetit

@joshpetitjoshpetit commented May 2, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Add property tableVerticalAlignment to markdown style sheet that sets the vertical alignment of table properties.

flutter/flutter#125872

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard

flutter-dashboardBot commented May 2, 2023

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@joshpetit

joshpetit commented May 9, 2023

Copy link
Copy Markdown
ContributorAuthor

I see this was approved but still needs to be merged in. Is there any ETA on that? I'm planning on using this fix in a release and am wondering if I can wait till this is merged or if it'll take some more time.

@stuartmorgan-g

stuartmorgan-g commented May 9, 2023

Copy link
Copy Markdown
Collaborator

I see this was approved but still needs to be merged in.

It needs a second review, per https://github.com/flutter/flutter/wiki/Tree-hygiene#getting-a-code-review. It's in my queue.

stuartmorgan-g
stuartmorgan-g requested changes May 14, 2023
View reviewed changes
Comment threadpackages/flutter_markdown/CHANGELOG.md Outdated
Comment threadpackages/flutter_markdown/CHANGELOG.md Outdated
Comment threadpackages/flutter_markdown/lib/src/style_sheet.dart Outdated
Comment threadpackages/flutter_markdown/test/table_test.dart
@joshpetit

joshpetit commented May 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@stuartmorgan just addressed the requests 👍

@stuartmorgan-g
stuartmorgan-g self-requested a review May 23, 2023 19:45
stuartmorgan-g
stuartmorgan-g requested changes Jun 13, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one small change, sorry for the delay.

Comment threadpackages/flutter_markdown/test/table_test.dart Outdated
);

testWidgets(
'table cell vertical alignment should follow stylesheet',

@stuartmorgan-gstuartmorgan-gJun 13, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two different tests should not have the same name; these need to distinguish what is different between the tests.

@stuartmorgan-g

stuartmorgan-g commented Jun 29, 2023

Copy link
Copy Markdown
Collaborator

@joshpetit Are you still planning on updating this to resolve the last issue? Once that's done it should be good to land.

@joshpetit

joshpetit commented Jun 29, 2023

Copy link
Copy Markdown
ContributorAuthor

Oh thanks for the ping, I'll look at your comments tonight.

@stuartmorgan-gstuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App and removed needs tests labels Jul 5, 2023
@auto-submit
auto-submitBot merged commit d472347 into flutter:mainJul 5, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jul 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 6, 2023
@engine-flutter-autoroll
d472347[flutter_markdown] Add TableCellVerticalAlignment property in…
f256688
… markdown stylesheet (flutter/packages#3880)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jul 6, 2023
@engine-flutter-autoroll
Roll Packages from7042079to771ec9b(12 revisions) (#130077)
7e2f1f5
flutter/packages@7042079...771ec9b
2023-07-06 stuartmorgan@google.com [ci] Enable LUCI Dart unit tests (flutter/packages#4378)
2023-07-06 stuartmorgan@google.com [ci] Bring up LUCI Linux custom package tests (flutter/packages#4382)
2023-07-06 tarrinneal@gmail.com [pigeon] adds generate option for example pigeons (flutter/packages#4370)
2023-07-06 47866232+chunhtai@users.noreply.github.com [go_router] Allows redirect only GoRoute to be part of RouteMatchList (flutter/packages#4315)
2023-07-06 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.android.gms:play-services-auth from 20.5.0 to 20.6.0 in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4359)
2023-07-06 41930132+hellohuanlin@users.noreply.github.com [pigeon]fix a crash when casting NSNull to an Array (flutter/packages#4289)
2023-07-06 hello@kamil.id [google_sign_in_web] Fixes force unwrap on values that can be null (flutter/packages#4374)
2023-07-05 engine-flutter-autoroll@skia.org Roll Flutter from 590ef2d to 35085c3 (3 revisions) (flutter/packages#4379)
2023-07-05 43054281+camsim99@users.noreply.github.com [camerax] Fixes `unawaited_futures` violations (flutter/packages#4337)
2023-07-05 stuartmorgan@google.com [ci] Remove `starqlteue` from FTL tests (flutter/packages#4375)
2023-07-05 stuartmorgan@google.com [tools] Switch to `flutter test` (flutter/packages#4348)
2023-07-05 joshuapetitma@yahoo.com [flutter_markdown] Add TableCellVerticalAlignment property in markdown stylesheet (flutter/packages#3880)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbakerreidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbakerreidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@joshpetit
[flutter_markdown] Add TableCellVerticalAlignment property in markdow…
53aa9cd
…n stylesheet (flutter#3880)
Add property `tableVerticalAlignment` to markdown style sheet that sets the vertical alignment of table properties.
flutter/flutter#125872
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@joshpetit
[flutter_markdown] Add TableCellVerticalAlignment property in markdow…
9d09409
…n stylesheet (flutter#3880)
Add property `tableVerticalAlignment` to markdown style sheet that sets the vertical alignment of table properties.
flutter/flutter#125872
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domesticmousedomesticmousedomesticmouse approved these changes
@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: flutter_markdown

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshpetit@stuartmorgan-g@domesticmouse