Uh oh!
There was an error while loading. Please reload this page.
Adding setup for TestInstanceManagerHostApi in zoom and exposure tests - #3947
Merged
Merged
Conversation
gmackall
commented
May 8, 2023
MemberAuthor
I believe these changes should be version/changelog exempt as they are test-only changes. |
11 tasks
camsim99
commented
May 8, 2023
Contributor
Oh can you update the CHANGELOG? |
MemberAuthor
Is this change not CHANGELOG exempt (the second sentence here https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog)? I don't mind updating it either way but just want to make sure I understand the policy! |
camsim99
commented
May 8, 2023
Contributor
Oh no you're right! Thanks!! |
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2023
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2023
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2023
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 9, 2023
flutter/packages@4800d65...1f91710 2023-05-09 43054281+camsim99@users.noreply.github.com [camerax] Update README with plugin overview (flutter/packages#3891) 2023-05-09 jmccandless@google.com Fix nullability in docs (flutter/packages#3876) 2023-05-08 stuartmorgan@google.com [tools] Check version ranges when pathifying deps (flutter/packages#3943) 2023-05-08 stuartmorgan@google.com [quick_actions] Update minimum iOS version to 11 (flutter/packages#3946) 2023-05-08 stuartmorgan@google.com [shared_preferences] Update minimum iOS version to 11 (flutter/packages#3945) 2023-05-08 stuartmorgan@google.com [path_provider] Update minimum iOS version to 11 (flutter/packages#3944) 2023-05-08 34871572+gmackall@users.noreply.github.com Adding setup for TestInstanceManagerHostApi in zoom and exposure tests (flutter/packages#3947) 2023-05-08 engine-flutter-autoroll@skia.org Roll Flutter from 43ac23b to 4ed1c92 (16 revisions) (flutter/packages#3942) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
This was referenced Jul 7, 2023
nploi pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
flutter#3947) Fixesflutter/flutter#126285. Running the tests locally without this change, they fail around 1/4 of the time. With this change, I haven't seen them fail.
11 tasks
11 tasks
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
flutter#3947) Fixesflutter/flutter#126285. Running the tests locally without this change, they fail around 1/4 of the time. With this change, I haven't seen them fail.
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
flutter#3947) Fixesflutter/flutter#126285. Running the tests locally without this change, they fail around 1/4 of the time. With this change, I haven't seen them fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixesflutter/flutter#126285.
Running the tests locally without this change, they fail around 1/4 of the time. With this change, I haven't seen them fail.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.