[webview_flutter_wkwebview] Adds the `isInspectable` to `WebKitWebViewController`. by GwonHyeok · Pull Request #3984 · flutter/packages

GwonHyeok · 2023-05-14T17:36:25Z

Starting from iOS version 16.4, it is now possible to change the value of the isInspectable property in WKWebView.

https://developer.apple.com/documentation/webkit/wkwebview/4111163-isinspectable

Since iOS 16.4, the Web Inspector feature is disabled by default.
Therefore, to use Web Inspector, need to change the value of isInspectable.

Here is a blog post from WebKit that discusses this
https://webkit.org/blog/13936/enabling-the-inspection-of-web-content-in-apps/

Apple Developer Forums thread (iOS 16.4 webview can not debug in safari web inspector)
https://developer.apple.com/forums/thread/727049

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…wController`. Starting from iOS version 16.4, it is now possible to change the value of the isInspectable property in WKWebView.

stuartmorgan-g · 2023-05-15T19:18:55Z

Thanks for the contribution!

I listed at least one issue that this PR fixes in the description above.

Could you file an issue providing more context on this, especially since the Apple docs don't explain it? That would be helpful for reviewers, and for future understanding of this PR in context.

This will also need native unit tests that validate that it's actually calling the relevant API.

GwonHyeok · 2023-05-16T02:52:33Z

Since iOS 16.4, the Web Inspector feature is disabled by default.
Therefore, to use Web Inspector, need to change the value of isInspectable.

Here is a blog post from WebKit that discusses this
https://webkit.org/blog/13936/enabling-the-inspection-of-web-content-in-apps/

Apple Developer Forums thread (iOS 16.4 webview can not debug in safari web inspector)
https://developer.apple.com/forums/thread/727049

cyanglaz · 2023-05-16T04:18:31Z

@GwonHyeok Thanks for the explanation! This makes sense.

Please follow the instructions in #3984 (comment) before we can review and land this.

I think your comment is clear enough so you can copy it over to the issue that you will create.

GwonHyeok · 2023-05-16T05:01:55Z

@cyanglaz

I have created an issue for this PR and assigned it.

cyanglaz · 2023-05-16T15:40:43Z

I have created an issue for this PR and assigned it.

Awesome, thank you!

Please also do this:

This will also need native unit tests that validate that it's actually calling the relevant API.

GwonHyeok · 2023-05-16T16:22:40Z

@cyanglaz

I added native unit tests for this PR. 👍🏻

bparrishMines

Thanks for the contribution!

GwonHyeok · 2023-05-20T08:03:59Z

@bparrishMines

I have reviewed all the feedback you provided and have committed the changes.

bparrishMines

LGTM

cc @stuartmorgan / @cyanglaz for secondary review

…_kit/web_kit.dart Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>

…kit_webview_controller.dart Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>

# Conflicts: # packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md # packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml

GwonHyeok · 2023-05-26T09:11:24Z

@stuartmorgan @cyanglaz

resolved the issue caused by a conflict with the release of version 3.4.4.

GwonHyeok · 2023-05-31T02:25:00Z

@bparrishMines @cyanglaz @stuartmorgan

Hello,
Why hasn't the this PR been reviewed yet?

stuartmorgan-g · 2023-05-31T15:58:05Z

Because I was out of office for a significant portion of the time since I was added to the review list, and this review is only one of many things I have on my plate.

cyanglaz

LGTM % nits

cyanglaz

LGTM

bparrishMines · 2023-06-15T16:37:16Z

+- (void)setInspectableForWebViewWithIdentifier:(NSNumber *)identifier
+ inspectable:(NSNumber *)inspectable
+ error:(FlutterError *_Nullable *_Nonnull)error {
+ if (@available(macOS 13.3, iOS 16.4, tvOS 16.4, *)) {


This should also provide a FlutterError for unsupported versions. See https://github.com/flutter/packages/blob/main/packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFUserContentControllerHostApi.m#L55

FWFUnsupportedVersionError has been added.

…portedVersionError

…bview_inspectable

# Conflicts: # packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md

bparrishMines

LGTM

tall-nuts · 2023-06-27T10:39:13Z

ARC Semantic Issue (Xcode): No visible @interface for 'FWFWebView' declares the selector 'setInspectable:'
/Users/xxx/.pub-cache/hosted/pub.dev/webview_flutter_wkwebview-3.6.0/ios/Classes/FWFWebViewHostApi.m:203:44

stuartmorgan-g · 2023-06-27T10:47:44Z

@PengfeiGao In the future, please use the issue tracker to report issues. That's flutter/flutter#129587

…itWebViewController`. (flutter/packages#3984)

flutter/packages@6b70804...f89ce02 2023-06-27 hansmuller@google.com Updated rfw/test/material_widgets_test.dart for M3 (flutter/packages#4316) 2023-06-27 tarrinneal@gmail.com [shared_preferences] Adds new `clearWithParameters` and `getAllWithParameters` methods to platform interface. (flutter/packages#4261) 2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter from 042c036 to 96a2c05 (60 revisions) (flutter/packages#4313) 2023-06-26 10687576+bparrishMines@users.noreply.github.com [file_selector_android] Create initial Android implementation of the file_selector package (flutter/packages#3814) 2023-06-26 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20230227 to 20230618 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#4244) 2023-06-26 me@ghyeok.io [webview_flutter_wkwebview] Adds the `isInspectable` to `WebKitWebViewController`. (flutter/packages#3984) 2023-06-26 stuartmorgan@google.com [ci] Remove jcenter from legacy project (flutter/packages#4306) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[webview_flutter_wkwebview] Adds the isInspectable to `WebKitWebVie…
d81eecd
…wController`. Starting from iOS version 16.4, it is now possible to change the value of the isInspectable property in WKWebView.

GwonHyeok requested a review from cyanglaz as a code owner May 14, 2023 17:36

github-actionsBot added p: webview_flutter platform-ios labels May 14, 2023

stuartmorgan-g requested a review from bparrishMines May 15, 2023 19:19

cyanglaz self-assigned this May 15, 2023

[webview_flutter_wkwebview] Adds the setInspectable native unit tests
156b4a3

bparrishMines reviewed May 19, 2023
View reviewed changes

GwonHyeok added 3 commits May 20, 2023 16:59

[webview_flutter_wkwebview] Update setInspectable Comment
e67f084

[webview_flutter_wkwebview] Update CHANGELOG.md
5d0f22d

[webview_flutter_wkwebview] change version to 3.5.0
128da28

leighajarett requested a review from stuartmorgan-g May 22, 2023 19:10

bparrishMines approved these changes May 23, 2023
View reviewed changes

Comment threadpackages/webview_flutter/webview_flutter_wkwebview/lib/src/web_kit/web_kit.dart Outdated
Comment threadpackages/webview_flutter/webview_flutter_wkwebview/lib/src/webkit_webview_controller.dart

GwonHyeokand others added 3 commits May 24, 2023 09:38

Update packages/webview_flutter/webview_flutter_wkwebview/lib/src/web…
d3ec324
…_kit/web_kit.dart Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>

Update packages/webview_flutter/webview_flutter_wkwebview/lib/src/web…
2e6330b
…kit_webview_controller.dart Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>

Merge branch 'main' into wkwebview_inspectable
3c2d892
# Conflicts: # packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md # packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml

cyanglaz approved these changes Jun 12, 2023
View reviewed changes

Comment threadpackages/webview_flutter/webview_flutter_wkwebview/lib/src/web_kit/web_kit.dart Outdated

[webview_flutter_wkwebview] Update setInspectable Comment
4629c89

cyanglaz approved these changes Jun 13, 2023
View reviewed changes

Merge branch 'main' into wkwebview_inspectable
8d68866

bparrishMines reviewed Jun 15, 2023
View reviewed changes

GwonHyeok added 4 commits June 17, 2023 00:02

[webview_flutter_wkwebview] Add FWWebViewHostApi setInspectable Unsup…
fa5ef8e
…portedVersionError

Merge remote-tracking branch 'ghyeok/wkwebview_inspectable' into wkwe…
f4713d8
…bview_inspectable

Merge branch 'main' into wkwebview_inspectable
45bdfa9
# Conflicts: # packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md

[webview_flutter_wkwebview] change version to 3.6.0
0dae615

bparrishMines approved these changes Jun 26, 2023
View reviewed changes

bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2023

auto-submitBot merged commit 96c8e2d into flutter:mainJun 26, 2023

engine-flutter-autoroll mentioned this pull request Jun 27, 2023
Roll Packages from 6b70804799a9 to f89ce028d764 (7 revisions) flutter/flutter#129630
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 27, 2023
96c8e2d[webview_flutter_wkwebview] Adds theisInspectableto `WebK…
d620005
…itWebViewController`. (flutter/packages#3984)

This comment was marked as off-topic.
Sign in to view

flutter locked as off-topic and limited conversation to collaborators Jun 29, 2023

Uh oh!

Conversation

GwonHyeok commented May 14, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

stuartmorgan-g commented May 15, 2023

Uh oh!

GwonHyeok commented May 16, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cyanglaz commented May 16, 2023

Uh oh!

GwonHyeok commented May 16, 2023

Uh oh!

cyanglaz commented May 16, 2023

Uh oh!

GwonHyeok commented May 16, 2023

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GwonHyeok commented May 20, 2023

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

GwonHyeok commented May 26, 2023

Uh oh!

GwonHyeok commented May 31, 2023

Uh oh!

stuartmorgan-g commented May 31, 2023

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

bparrishMinesJun 15, 2023

Choose a reason for hiding this comment

Uh oh!

GwonHyeokJun 16, 2023

Choose a reason for hiding this comment

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

tall-nuts commented Jun 27, 2023

Uh oh!

stuartmorgan-g commented Jun 27, 2023

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

GwonHyeok commented May 14, 2023•
edited
Loading

GwonHyeok commented May 16, 2023•
edited
Loading