Skip to content

[ci] Manual flutter roll - #4033

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
ditman:manual-flutter-roll
May 18, 2023
Merged

[ci] Manual flutter roll#4033
auto-submit[bot] merged 4 commits into
flutter:mainfrom
ditman:manual-flutter-roll

Conversation

@ditman

@ditmanditman commented May 17, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Attempt to manually roll flutter (stable and master), fixing what's preventing the auto-rolls:

  • [flutter_markdown] Teach a mock AssetManager of the new .smcbin asset file format.
  • [google_sign_in] dart format .
  • [webview_flutter] dart format .

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard

This comment was marked as resolved.

Sign in to view
@ditman
ditmanforce-pushed the manual-flutter-roll branch from 24c1745 to 4075ac4CompareMay 17, 2023 21:42
@ditman

ditman commented May 17, 2023

Copy link
Copy Markdown
MemberAuthor
 google_sign_in_web:
Missing version change
webview_flutter_android:
Missing version change
webview_flutter_web:
Missing version change

The changes in those packages are only dart format .; do we need to release those?

@ditmanditman added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels May 17, 2023
@ditman

ditman commented May 17, 2023

Copy link
Copy Markdown
MemberAuthor

(Overridden version/changelog after talking to @stuartmorgan on discord.)

@ditman

ditman commented May 17, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

This PR actually allows tests to run in newer versions of Flutter.

stuartmorgan-g
stuartmorgan-g approved these changes May 18, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ditmanditman added the autosubmit Merge PR when tree becomes green via auto submit App label May 18, 2023
@auto-submit
auto-submitBot merged commit 3b377bd into flutter:mainMay 18, 2023
@ditman
ditman deleted the manual-flutter-roll branch May 18, 2023 00:31
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2023
@engine-flutter-autoroll
3b377bd[ci] Manual flutter roll (flutter/packages#4033)
7d9a803
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request May 18, 2023
@engine-flutter-autoroll
Roll Packages from5c69914tob31a128(9 revisions) (#127109)
5381e82
flutter/packages@5c69914...b31a128
2023-05-18 stuartmorgan@google.com [flutter_plugin_android_lifecycle] Fix lints (flutter/packages#4030)
2023-05-18 ian@hixie.ch [rfw] Fix a typo in the API documentation (flutter/packages#4023)
2023-05-18 ditman@gmail.com [ci] Manual flutter roll (flutter/packages#4033)
2023-05-17 4195507+fmt-Println-MKO@users.noreply.github.com [flutter_adaptive_scaffold] exchange BottomNavigationBar with NavigationBar (flutter/packages#3746)
2023-05-17 stuartmorgan@google.com [tools] Ignore comments in federated safety check (flutter/packages#4028)
2023-05-17 reidbaker@google.com Revert "[url_launcher] Set broadcast reciever visability as required by target api 34" (flutter/packages#4027)
2023-05-17 stuartmorgan@google.com [camera] Fix Java lints in camerax version (flutter/packages#3966)
2023-05-17 34871572+gmackall@users.noreply.github.com [image_picker] Upgrade androidx.activity to 1.7.0 and add a dependency on kotlin-bom to align kotlin transitive dependencies (flutter/packages#3968)
2023-05-17 49699333+dependabot[bot]@users.noreply.github.com [espresso]: Bump com.squareup.okhttp3:okhttp from 4.10.0 to 4.11.0 in /packages/espresso/android (flutter/packages#3804)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autorollCasey Hillers
Roll Packages from5c69914tob31a128(9 revisions) (flutter#127109)
abf1bad
flutter/packages@5c69914...b31a128
2023-05-18 stuartmorgan@google.com [flutter_plugin_android_lifecycle] Fix lints (flutter/packages#4030)
2023-05-18 ian@hixie.ch [rfw] Fix a typo in the API documentation (flutter/packages#4023)
2023-05-18 ditman@gmail.com [ci] Manual flutter roll (flutter/packages#4033)
2023-05-17 4195507+fmt-Println-MKO@users.noreply.github.com [flutter_adaptive_scaffold] exchange BottomNavigationBar with NavigationBar (flutter/packages#3746)
2023-05-17 stuartmorgan@google.com [tools] Ignore comments in federated safety check (flutter/packages#4028)
2023-05-17 reidbaker@google.com Revert "[url_launcher] Set broadcast reciever visability as required by target api 34" (flutter/packages#4027)
2023-05-17 stuartmorgan@google.com [camera] Fix Java lints in camerax version (flutter/packages#3966)
2023-05-17 34871572+gmackall@users.noreply.github.com [image_picker] Upgrade androidx.activity to 1.7.0 and add a dependency on kotlin-bom to align kotlin transitive dependencies (flutter/packages#3968)
2023-05-17 49699333+dependabot[bot]@users.noreply.github.com [espresso]: Bump com.squareup.okhttp3:okhttp from 4.10.0 to 4.11.0 in /packages/espresso/android (flutter/packages#3804)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@ditman@nploi
[ci] Manual flutter roll (flutter#4033)
d4992ce
Attempt to manually roll flutter (stable and master), fixing what's preventing the auto-rolls:
* [flutter_markdown] Teach a mock AssetManager of the new .smcbin asset file format.
* [google_sign_in] dart format .
* [webview_flutter] dart format .
@reidbakerreidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@ditmanditman mentioned this pull request Aug 1, 2023
Merged
8 tasks
@reidbakerreidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@ditman
[ci] Manual flutter roll (flutter#4033)
185cc00
Attempt to manually roll flutter (stable and master), fixing what's preventing the auto-rolls:
* [flutter_markdown] Teach a mock AssetManager of the new .smcbin asset file format.
* [google_sign_in] dart format .
* [webview_flutter] dart format .
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@ditman
[ci] Manual flutter roll (flutter#4033)
4bdb7a7
Attempt to manually roll flutter (stable and master), fixing what's preventing the auto-rolls:
* [flutter_markdown] Teach a mock AssetManager of the new .smcbin asset file format.
* [google_sign_in] dart format .
* [webview_flutter] dart format .
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@domesticmousedomesticmouseAwaiting requested review from domesticmouse
@bparrishMinesbparrishMinesAwaiting requested review from bparrishMines

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appoverride: no changelog neededOverride the check requiring CHANGELOG updates for most changesoverride: no versioning neededOverride the check requiring version bumps for most changesp: flutter_markdownp: google_sign_inp: webview_flutterplatform-androidplatform-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ditman@stuartmorgan-g