Skip to content

Fix stale ignore: prefer_const_constructors from flutter/packages - #4154

Merged
auto-submit[bot] merged 12 commits into
flutter:mainfrom
ayinloya:remove-stale-ignore-prefer-const-constructors
Jun 8, 2023
Merged

Fix stale ignore: prefer_const_constructors from flutter/packages#4154
auto-submit[bot] merged 12 commits into
flutter:mainfrom
ayinloya:remove-stale-ignore-prefer-const-constructors

Conversation

@ayinloya

@ayinloyaayinloya commented Jun 6, 2023•
edited by stuartmorgan-g
Loading

Copy link
Copy Markdown
Contributor

Update the flutter version in affected packages to 3.10.0
Fix stale ignore: prefer_const_constructors from flutter/packages

Fixesflutter/flutter#128141

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan-gstuartmorgan-g added the override: no versioning needed Override the check requiring version bumps for most changes label Jun 7, 2023
@stuartmorgan-g

stuartmorgan-g commented Jun 7, 2023

Copy link
Copy Markdown
Collaborator

Overriding version check: The changes that are being flagged are:

  • example main.dart files, but having that updated on pub.dev isn't important enough to publish just for that, and
  • upping minimum SDK versions, which we deliberately don't publish for without other changes per the exemption list

stuartmorgan-g
stuartmorgan-g requested changes Jun 7, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! Just a few minor nits, then it'll be good to land.

Comment threadpackages/flutter_adaptive_scaffold/CHANGELOG.md Outdated
Comment threadpackages/url_launcher/url_launcher/example/ios/Runner.xcodeproj/project.pbxproj Outdated
Comment thread...rl_launcher/url_launcher/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme Outdated
Comment threadscript/configs/windows_unit_tests_exceptions.yaml Outdated
@ayinloya
ayinloya requested a review from tarrinneal as a code ownerJune 7, 2023 19:06
@ayinloya
ayinloyaforce-pushed the remove-stale-ignore-prefer-const-constructors branch from 58f5dbe to af9ae24CompareJune 7, 2023 20:09
@ayinloya
ayinloyaforce-pushed the remove-stale-ignore-prefer-const-constructors branch from af9ae24 to 54179b5CompareJune 7, 2023 21:50
stuartmorgan-g
stuartmorgan-g approved these changes Jun 8, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2023
@auto-submit
auto-submitBot merged commit 3e0a170 into flutter:mainJun 8, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jun 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
3e0a170Fix stale ignore: prefer_const_constructors from flutter/pack…
4484ff7
…ages (flutter/packages#4154)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
Roll Packages frome13b8c4toafe2f05(7 revisions) (#128582)
f655843
flutter/packages@e13b8c4...afe2f05
2023-06-08 stuartmorgan@google.com [image_picker] Add desktop support - platform interface (flutter/packages#4161)
2023-06-08 nils@reichardt.io [go_router] Update link to example for query and path parameters (flutter/packages#3994)
2023-06-08 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.0 to 1.8.21 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3839)
2023-06-08 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.0 to 1.7.1 in /packages/image_picker/image_picker_android/android (flutter/packages#3768)
2023-06-08 stuartmorgan@google.com [webview_flutter] Explicitly disable ATS in example apps (flutter/packages#4166)
2023-06-08 engine-flutter-autoroll@skia.org Roll Flutter from 8a5c22e to 6e254a3 (12 revisions) (flutter/packages#4165)
2023-06-08 banasco@gmail.com Fix stale ignore: prefer_const_constructors from flutter/packages (flutter/packages#4154)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbakerreidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbakerreidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@ayinloya
Fix stale ignore: prefer_const_constructors from flutter/packages (fl…
418f5b3
…utter#4154)
Update the flutter version in affected packages to 3.10.0
Fix stale ignore: prefer_const_constructors from flutter/packages
Fixesflutter/flutter#128141
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@ayinloya
Fix stale ignore: prefer_const_constructors from flutter/packages (fl…
7f0c08d
…utter#4154)
Update the flutter version in affected packages to 3.10.0
Fix stale ignore: prefer_const_constructors from flutter/packages
Fixesflutter/flutter#128141
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domesticmousedomesticmousedomesticmouse approved these changes
@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@gspencergooggspencergooggspencergoog approved these changes
@cbrackencbrackenAwaiting requested review from cbracken
@LouiseHsuLouiseHsuAwaiting requested review from LouiseHsu
@camsim99camsim99Awaiting requested review from camsim99
@HixieHixieAwaiting requested review from Hixie
@bparrishMinesbparrishMinesAwaiting requested review from bparrishMines
@tarrinnealtarrinnealAwaiting requested review from tarrinneal

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appoverride: no versioning neededOverride the check requiring version bumps for most changesp: flutter_adaptive_scaffoldp: flutter_markdownp: google_maps_flutterp: local_authp: rfwRemote Flutter Widgetsp: url_launcherplatform-androidplatform-iosplatform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix stale ignore: prefer_const_constructors from flutter/packages

4 participants

@ayinloya@stuartmorgan-g@domesticmouse@gspencergoog