Skip to content

[go_router] Adds parent navigator key to ShellRoute and StatefulShell… - #4201

Merged
auto-submit[bot] merged 6 commits into
flutter:mainfrom
chunhtai:issues/111678
Jun 21, 2023
Merged

[go_router] Adds parent navigator key to ShellRoute and StatefulShell…#4201
auto-submit[bot] merged 6 commits into
flutter:mainfrom
chunhtai:issues/111678

Conversation

@chunhtai

@chunhtaichunhtai commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

…Route.

fixesflutter/flutter#111678
fixesflutter/flutter#128793

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Walrus117

Copy link
Copy Markdown

@chunhtai Is it possible to use your PR yet in pubspec_yaml. It's somewhat cleaner than the notes I sent to you of how I modified the code?

@Walrus117

Copy link
Copy Markdown

@chunhtai Is it possible to use your PR yet in pubspec_yaml. It's somewhat cleaner than the notes I sent to you of how I modified the code?

Never mind, I worked it out. At some point I should probably get accustomed to gitHub.

@chunhtai
chunhtai requested a review from hannah-hyjJune 15, 2023 17:46

@hannah-hyjhannah-hyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtaichunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 16, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 16, 2023
@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages, pr: 4201, due to - The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtaichunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 21, 2023
@auto-submit
auto-submitBot merged commit b321f2c into flutter:mainJun 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 22, 2023
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jun 22, 2023
flutter/packages@9af50d4...95bc1c6
2023-06-22 stuartmorgan@google.com [ci] Switch analyze tests to LUCI (flutter/packages#4264)
2023-06-22 ditman@gmail.com Roll Flutter from fc8856e to c40baf4 (57 revisions) (flutter/packages#4270)
2023-06-22 stuartmorgan@google.com [ci] Add LUCI version of build-all for Android (flutter/packages#4236)
2023-06-21 47866232+chunhtai@users.noreply.github.com [go_router] Adds parent navigator key to ShellRoute and StatefulShell� (flutter/packages#4201)
2023-06-21 stuartmorgan@google.com [pigeon] Add macOS Obj-C support (flutter/packages#4267)
2023-06-21 stuartmorgan@google.com [tools] Fix format instructions (flutter/packages#4259)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Aug 4, 2023
11 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: go_router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[go_router] Nested ShellRoute - Unable to exit app [go_router] Add parentNavigatorKey to ShellRoute

3 participants

@chunhtai@Walrus117@hannah-hyj