Skip to content

[go_router] implemented helpers for StatefulShellRoute - #4228

Merged
auto-submit[bot] merged 10 commits into
flutter:mainfrom
hannah-hyj:statefulshellroute
Jul 7, 2023
Merged

[go_router] implemented helpers for StatefulShellRoute#4228
auto-submit[bot] merged 10 commits into
flutter:mainfrom
hannah-hyj:statefulshellroute

Conversation

@hannah-hyj

@hannah-hyjhannah-hyj commented Jun 16, 2023•
edited
Loading

Copy link
Copy Markdown
Member

issue: #127371

go_router_builder_pr #4238

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai

chunhtai commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

Can you also link a go_router_builder pr?

@hannah-hyjhannah-hyj changed the title implemented helpers for StatefulShellRoute[go_router] implemented helpers for StatefulShellRouteJun 16, 2023
@hannah-hyj

hannah-hyj commented Jun 16, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Yes, but the go_router_builder PR is still a draft because I need to merge the go_router pr first and update the dependency in go_router_builder

@chunhtai

chunhtai commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

that is fine, it is easier to review after knowing the whole picture

chunhtai
chunhtai reviewed Jun 21, 2023
View reviewed changes
Comment threadpackages/go_router/lib/src/route_data.dart Outdated
Comment threadpackages/go_router/lib/src/route_data.dart Outdated
Comment threadpackages/go_router/lib/src/route_data.dart Outdated
Comment threadpackages/go_router/lib/src/route_data.dart Outdated
Comment threadpackages/go_router/lib/src/route_data.dart
Comment threadpackages/go_router/lib/src/route_data.dart
@hannah-hyj
hannah-hyj requested a review from chunhtaiJune 26, 2023 18:55
chunhtai
chunhtai reviewed Jun 28, 2023
View reviewed changes

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of the code LGTM, can you also update the go_router_builder pr so that i can review as a whole?

Comment threadpackages/go_router/lib/src/route.dart
Comment threadpackages/go_router/lib/src/route_data.dart Outdated
Comment threadpackages/go_router/lib/src/route_data.dart
Comment threadpackages/go_router/test/route_data_test.dart Outdated
Comment threadpackages/go_router/test/route_data_test.dart Outdated
@hannah-hyj

hannah-hyj commented Jun 28, 2023

Copy link
Copy Markdown
MemberAuthor

updated the go_router_builder pr

@hannah-hyj
hannah-hyj requested a review from chunhtaiJuly 5, 2023 17:16
chunhtai
chunhtai reviewed Jul 5, 2023
View reviewed changes
Comment threadpackages/go_router/lib/src/route_data.dart
branches: branches,
builder: builder,
pageBuilder: pageBuilder,
restorationScopeId: restorationScopeId,

@chunhtaichunhtaiJul 5, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also be in line 260, also how would one specify this in TypeStatefulShellRoute?

@chunhtaichunhtaiJul 5, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also consider adding this to TypedShellRoute

@hannah-hyjhannah-hyjJul 5, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment threadpackages/go_router/lib/src/route_data.dart
List<RouteBase> routes = const <RouteBase>[],
}) {
return StatefulShellBranch(
routes: routes,

@chunhtaichunhtaiJul 5, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does one specify initialLocation and restorationScopeId? we may also want a way to specify observers

@hannah-hyjhannah-hyjJul 5, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@hannah-hyj
hannah-hyj requested a review from chunhtaiJuly 5, 2023 21:24
chunhtai
chunhtai approved these changes Jul 7, 2023
View reviewed changes

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannah-hyjhannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2023
@auto-submit
auto-submitBot merged commit 1c78359 into flutter:mainJul 7, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jul 10, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 10, 2023
@engine-flutter-autoroll
1c78359[go_router] implemented helpers for StatefulShellRoute (flutt…
960944c
…er/packages#4228)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jul 10, 2023
@engine-flutter-autoroll
Roll Packages fromb61eea1to4469c5e(15 revisions) (#130266)
2eaec8f
flutter/packages@b61eea1...4469c5e
2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter from d55a7d8 to 65ff3cb (21 revisions) (flutter/packages#4413)
2023-07-08 stuartmorgan@google.com [tool] Update Dart SDK version (flutter/packages#4402)
2023-07-08 stuartmorgan@google.com [url_lancher] Don't use `canLaunchUrl` in Link (flutter/packages#4400)
2023-07-08 32242716+ricardoamador@users.noreply.github.com Remove unused autosubmit configuration file (flutter/packages#4410)
2023-07-07 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.5.0 to 1.6.0 in /packages/file_selector/file_selector_android/android (flutter/packages#4312)
2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter from bc49cd1 to d55a7d8 (17 revisions) (flutter/packages#4403)
2023-07-07 tarrinneal@gmail.com [shared_preferences] Variable binding in a condition requires an initializer fix (flutter/packages#4407)
2023-07-07 jhy03261997@gmail.com [go_router] implemented helpers for StatefulShellRoute (flutter/packages#4228)
2023-07-07 34871572+gmackall@users.noreply.github.com [in_app_purchase_android] Bump com.android.billingclient:billing from 5.2.0 to 6.0.0. (flutter/packages#4390)
2023-07-07 stuartmorgan@google.com [tool] Use 'flutter pub get' for Flutter packages (flutter/packages#4397)
2023-07-07 stuartmorgan@google.com [ci] Enable LUCI stable custom Linux tests (flutter/packages#4404)
2023-07-07 stuartmorgan@google.com [tool] Fix --current-package for app-facing packages (flutter/packages#4399)
2023-07-07 stuartmorgan@google.com [ci] Switch some tests to LUCI (flutter/packages#4395)
2023-07-07 tarrinneal@gmail.com [flutter_markdown] Pass parent TextStyle down to MarkdownElementBuilder.visitElementAfter (flutter/packages#4393)
2023-07-07 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.3 to 2.20.3 (flutter/packages#4394)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Jul 14, 2023
Merged
11 tasks
@reidbakerreidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbakerreidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
gbtb16 pushed a commit to gbtb16/flutter that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll@gbtb16
Roll Packages fromb61eea1to4469c5e(15 revisions) (flutter#130266)
891e458
flutter/packages@b61eea1...4469c5e
2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter from d55a7d8 to 65ff3cb (21 revisions) (flutter/packages#4413)
2023-07-08 stuartmorgan@google.com [tool] Update Dart SDK version (flutter/packages#4402)
2023-07-08 stuartmorgan@google.com [url_lancher] Don't use `canLaunchUrl` in Link (flutter/packages#4400)
2023-07-08 32242716+ricardoamador@users.noreply.github.com Remove unused autosubmit configuration file (flutter/packages#4410)
2023-07-07 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.5.0 to 1.6.0 in /packages/file_selector/file_selector_android/android (flutter/packages#4312)
2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter from bc49cd1 to d55a7d8 (17 revisions) (flutter/packages#4403)
2023-07-07 tarrinneal@gmail.com [shared_preferences] Variable binding in a condition requires an initializer fix (flutter/packages#4407)
2023-07-07 jhy03261997@gmail.com [go_router] implemented helpers for StatefulShellRoute (flutter/packages#4228)
2023-07-07 34871572+gmackall@users.noreply.github.com [in_app_purchase_android] Bump com.android.billingclient:billing from 5.2.0 to 6.0.0. (flutter/packages#4390)
2023-07-07 stuartmorgan@google.com [tool] Use 'flutter pub get' for Flutter packages (flutter/packages#4397)
2023-07-07 stuartmorgan@google.com [ci] Enable LUCI stable custom Linux tests (flutter/packages#4404)
2023-07-07 stuartmorgan@google.com [tool] Fix --current-package for app-facing packages (flutter/packages#4399)
2023-07-07 stuartmorgan@google.com [ci] Switch some tests to LUCI (flutter/packages#4395)
2023-07-07 tarrinneal@gmail.com [flutter_markdown] Pass parent TextStyle down to MarkdownElementBuilder.visitElementAfter (flutter/packages#4393)
2023-07-07 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.3 to 2.20.3 (flutter/packages#4394)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@hannah-hyj
[go_router] implemented helpers for StatefulShellRoute (flutter#4228)
38d4828
issue: [#127371](flutter/flutter#127371)
go_router_builder_pr flutter#4238
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@hannah-hyj
[go_router] implemented helpers for StatefulShellRoute (flutter#4228)
011a01b
issue: [#127371](flutter/flutter#127371)
go_router_builder_pr flutter#4238
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtaichunhtaichunhtai approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: go_router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hannah-hyj@chunhtai